Skip to contentSkip to conversation

ntsync: Fix reference leaks in the remaining create ioctls.

PATCH New Elizabeth Figura 1 participant 1 message Jan 16, 2025

Subsystems (2)
lore
Share & tools
lore

Elizabeth Figura

author maintainer
#0 lore raw

PATCH 1/1 ntsync: Fix reference leaks in the remaining create ioctls.

When ntsync_obj_get_fd() fails, we free the ntsync object but forget to drop the "file" member.

This was fixed for semaphores in 0e7d523b5f7a23b1dc6ceceb04e31a60e9e3321d, but that commit did not fix the similar leak for events and mutexes, since they were part of patches not yet in the mainline kernel. Fix those cases.

Fixes 5bc2479a3585b "ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX."
Fixes 4c7404b9c2b57 "ntsync: Introduce NTSYNC_IOC_CREATE_EVENT."
---
 drivers/misc/ntsync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/ntsync.c +2 -2
index b6441e978974..055395cde42b 100644
@@ -781,7 +781,7 @@ static int ntsync_create_mutex(struct ntsync_device *dev, void __user *argp)
 	mutex->u.mutex.owner = args.owner;
 	fd = ntsync_obj_get_fd(mutex);
 	if (fd < 0)
-		kfree(mutex);
+		ntsync_free_obj(mutex);
 
 	return fd;
 }
@@ -802,7 +802,7 @@ static int ntsync_create_event(struct ntsync_device *dev, void __user *argp)
 	event->u.event.signaled = args.signaled;
 	fd = ntsync_obj_get_fd(event);
 	if (fd < 0)
-		kfree(event);
+		ntsync_free_obj(event);
 
 	return fd;
 }

base-commit: 0e7d523b5f7a23b1dc6ceceb04e31a60e9e3321d

Signature · 1 line
2.45.2