mm/damon/core: Use str_high_low() helper in damos_wmark_wait_us()
Subsystems (2)
PATCH 1/1 mm/damon/core: Use str_high_low() helper in damos_wmark_wait_us()
Remove hard-coded strings by using the str_high_low() helper function.
Signed-off-by Thorsten Blum <[email protected]>
--- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/damon/core.c +3 -3
@@ -14,6 +14,7 @@#include <linux/psi.h> #include <linux/slab.h> #include <linux/string.h> +#include <linux/string_choices.h> #define CREATE_TRACE_POINTS #include <trace/events/damon.h>
@@ -1894,9 +1895,8 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme)if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) {if (scheme->wmarks.activated)pr_debug ("deactivate a scheme (%d) for %s wmark\n" , - scheme->action, - metric > scheme->wmarks.high ? -"high" :"low" ); + scheme->action, +str_high_low (metric > scheme->wmarks.high)); scheme->wmarks.activated = false;return scheme->wmarks.interval; }
Signature · 1 line
2.48.0
Hello Thorsten,
Quoted 1 line · On Thu, 16 Jan 2025 21:42:16 +0100 Thorsten Blum <[email protected]>…
Remove hard-coded strings by using the
str_high_low()helper function.
Thank you for this patch!
Quoted 2 lines
Signed-off-by Thorsten Blum <[email protected]>
Reviewed-by SeongJae Park <[email protected]>
Thanks,
SJ
Quoted 30 lines
--- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)mm/damon/core.c +3
-3@@ -14,6 +14,7 @@#include <linux/psi.h> #include <linux/slab.h> #include <linux/string.h> +#include <linux/string_choices.h> #define CREATE_TRACE_POINTS #include <trace/events/damon.h> @@ -1894,9 +1895,8 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme)if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) {if (scheme->wmarks.activated)pr_debug ("deactivate a scheme (%d) for %s wmark\n" , - scheme->action, - metric > scheme->wmarks.high ? -"high" :"low" ); + scheme->action, +str_high_low (metric > scheme->wmarks.high)); scheme->wmarks.activated = false;return scheme->wmarks.interval; }Signature · 1 line
2.48.0