Skip to contentSkip to conversation

multipath-tools: Merge Infinidat with Lenovo in hwtable

PATCH In review Xose Vazquez Perez 2 participants 4 messages Jan 16, 2025 – Jan 17, 2025 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 multipath-tools: Merge Infinidat with Lenovo in hwtable

Lenovo to acquire Infinidat:
https://www.infinidat.com/en/news/press-releases/lenovo-acquire-infinidat-further-expanding-enterprise-storage-portfolio

Cc Martin Wilck <[email protected]>
Cc Benjamin Marzinski <[email protected]>
Cc Christophe Varoqui <[email protected]>
Cc DM-DEVEL ML <[email protected]>
---
 libmultipath/hwtable.c | 37 ++++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 19 deletions(-)
libmultipath/hwtable.c +18 -19
index 543f0bc1..2c26b42a 100644
@@ -788,6 +788,24 @@ static struct hwentry default_hw[] = {
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 30,
 	},
+	{
+		/*
+		 * Infinidat InfiniBox
+		 *
+		 * Maintainer: Arnon Yaari <[email protected]>
+		 */
+		.vendor        = "NFINIDAT",
+		.product       = "InfiniBox",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.pgfailback    = 30,
+		.prio_name     = PRIO_ALUA,
+		.selector      = "round-robin 0",
+		.rr_weight     = RR_WEIGHT_PRIO,
+		.no_path_retry = NO_PATH_RETRY_FAIL,
+		.minio         = 1,
+		.minio_rq      = 1,
+		.fast_io_fail  = 15,
+	},
 	/*
 	 * NetApp
 	 */
@@ -1121,25 +1139,6 @@ static struct hwentry default_hw[] = {
 		.product       = "XPD",
 		.pgpolicy      = MULTIBUS,
 	},
-	/*
-	 * Infinidat
-	 *
-	 * Maintainer: Arnon Yaari <[email protected]>
-	 */
-	{
-		/* InfiniBox */
-		.vendor        = "NFINIDAT",
-		.product       = "InfiniBox",
-		.pgpolicy      = GROUP_BY_PRIO,
-		.pgfailback    = 30,
-		.prio_name     = PRIO_ALUA,
-		.selector      = "round-robin 0",
-		.rr_weight     = RR_WEIGHT_PRIO,
-		.no_path_retry = NO_PATH_RETRY_FAIL,
-		.minio         = 1,
-		.minio_rq      = 1,
-		.fast_io_fail  = 15,
-	},
 	/*
 	 * Kaminario
 	 */
Signature · 1 line
2.48.1
#3 lore raw

Hello Xose,

Quoted 10 lines · Xose Vazquez Perez
Quoted 6 lines · Martin Wilck
Quoted 3 lines · Xose Vazquez Perez

Lenovo to acquire Infinidat:
https://www.infinidat.com/en/news/press-releases/lenovo-acquire-infinidat-further-expanding-enterprise-storage-portfolio

Does our hwtable have to reflect company acquisitions?

Not directly, but it's order by vendors. So..

If device names change, any time. But just because vendor A has bought vendor B, I don't think a code change is warranted. This kind of change makes git blame more cumbersome to use, with almost no benefit. The sort order in hwtable.c is not guaranteed in any way. Users who are interested in the defaults for a given device will search for the vendor and/or device name anyway.

Regards
Martin