Add AST2600 LPC PCC support
Subsystems (2)
cover Add AST2600 LPC PCC support
The AST2600 has PCC controller in LPC, placed in LPC node. As a result, add LPC PCC controller driver to support POST code capture.
Kevin Chen (3):
dt-binding: aspeed: Add LPC PCC controller
ARM: dts: aspeed-g6: Add AST2600 LPC PCC support
soc: aspeed: lpc-pcc: Add PCC controller support
.../bindings/soc/aspeed/lpc-pcc.yaml | 51 ++ arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 + drivers/soc/aspeed/Kconfig | 10 + drivers/soc/aspeed/Makefile | 1 + drivers/soc/aspeed/aspeed-lpc-pcc.c | 505 ++++++++++++++++++ 5 files changed, 574 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml create mode 100644 drivers/soc/aspeed/aspeed-lpc-pcc.c
Signature · 1 line
2.34.1
PATCH 1/3 dt-binding: aspeed: Add LPC PCC controller
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
--- .../bindings/soc/aspeed/lpc-pcc.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml
Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml new file +51 -0
@@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# # Copyright (c) 2024 Aspeed Technology Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed Post Cost Capture Controller + +maintainers: + - Kevin Chen <[email protected]> + - Chia-Wei Wang <[email protected]> + +description: + The Aspeed PCC control allow to capture POST code from Host. + + This driver is for the BMC side. POST code data can be access by + /dev/aspeed-lpc-pcc0. For example, POST code data is below. + ~# hexdump /dev/aspeed-lpc-pcc0 + 0000000 40b3 40a0 40a3 40a2 40a2 40b4 40a5 40ee + 0000010 40ee 40ee 40ee 40ee 40ee 40ee 40ee 40ee + 0000020 40ee 40ee 40ee 40ee 40ee 40ee 40ee 40a6 + +properties: + compatible: + items: + - enum: + - aspeed,ast2600-lpc-pcc + reg: + maxItems: 1 + +required: + - compatible + +additionalProperties: false + +examples: + - | + lpc: lpc@1e789000 { + compatible = "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon"; + reg = <0x1e789000 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e789000 0x1000>; + + lpc_pcc: lpc-pcc@0 { + compatible = "aspeed,ast2600-lpc-pcc"; + reg = <0x0 0x140>; + }; + };
Signature · 1 line
2.34.1
Re: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller
Quoted 4 lines · Kevin Chen
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
Signed-off-by Kevin Chen <[email protected]>---
Patchsets start from 1, not 0.
This wasn't tested as it has obvious errors, so no review. Test your patches before you send them.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.
Please kindly resend and include all necessary To/Cc entries. </form letter>
Best regards,
Krzysztof
RE: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller
Quoted 7 lines · Kevin Chen
Quoted 4 lines
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
Signed-off-by Kevin Chen <[email protected]>---
Patchsets start from 1, not 0.
Agree, I will resend the patchsets of v1.
Quoted 3 lines
This wasn't tested as it has obvious errors, so no review. Test your patches before you send them.
Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to check result is clean before the next commits.
Quoted 23 lines
<form letter>
Please usescripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Tools like b4 or
scripts/get_maintainer.plprovide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember aboutb4 prep --auto-to-ccif you added new patches to the patchset.You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.
Please kindly resend and include all necessary To/Cc entries. </form letter>
Best regards,
Krzysztof
Re: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller
Quoted 6 lines · Kevin Chen
Quoted 6 lines · Kevin Chen
Quoted 4 lines
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
Signed-off-by Kevin Chen <[email protected]>---
Quoted 28 lines
Quoted 1 line
Patchsets start from 1, not 0.
Agree, I will resend the patchsets of v1.
Quoted 3 lines
This wasn't tested as it has obvious errors, so no review. Test your patches before you send them.
Agree, I will run "make
dtbs_checkW=1" and " makedt_binding_check" to check result is clean before the next commits.Quoted 20 lines
<form letter>
Please usescripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Tools like b4 or
scripts/get_maintainer.plprovide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember aboutb4 prep --auto-to-ccif you added new patches to the patchset.You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.
Please kindly resend and include all necessary To/Cc entries. </form letter>
How did you implement this feedback?
Best regards,
Krzysztof
RE: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller
Quoted 31 lines · Kevin Chen
Quoted 6 lines
Quoted 6 lines · Kevin Chen
Quoted 4 lines
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
Signed-off-by Kevin Chen <[email protected]>---
Quoted 7 lines
Quoted 1 line
Patchsets start from 1, not 0.
Agree, I will resend the patchsets of v1.
Quoted 3 lines
This wasn't tested as it has obvious errors, so no review. Test your patches before you send them.
Agree, I will run "make
dtbs_checkW=1" and " makedt_binding_check" tocheck result is clean before the next commits.
Quoted 9 lines
Quoted 9 lines
<form letter>
Please usescripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Quoted 3 lines
Quoted 3 lines
Tools like b4 or
scripts/get_maintainer.plprovide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel(don't, instead use mainline).
Quoted 3 lines
Quoted 3 lines
Just use b4 and everything should be fine, although remember about
b4 prep --auto-to-ccif you added new patches to the patchset.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.
Please kindly resend and include all necessary To/Cc entries. </form letter>
How did you implement this feedback?
make dtbs_check W=1
# Check the lpc-pcc or pcc message from the log
make dt_binding_check
# No Error
make coccicheck MODE=report
# Stop at the following log but no related log.
# OCaml scripting is unsupported.
# coccicheck failed
Quoted 3 lines
Best regards,
Krzysztof
Re: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller
Quoted 43 lines · Kevin Chen
Quoted 31 lines · Kevin Chen
Quoted 6 lines
Quoted 6 lines · Kevin Chen
Quoted 4 lines
Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
Signed-off-by Kevin Chen <[email protected]>---
Quoted 7 lines
Quoted 1 line
Patchsets start from 1, not 0.
Agree, I will resend the patchsets of v1.
Quoted 3 lines
This wasn't tested as it has obvious errors, so no review. Test your patches before you send them.
Agree, I will run "make
dtbs_checkW=1" and " makedt_binding_check" tocheck result is clean before the next commits.
Quoted 9 lines
Quoted 9 lines
<form letter>
Please usescripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Quoted 3 lines
Quoted 3 lines
Tools like b4 or
scripts/get_maintainer.plprovide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel(don't, instead use mainline).
Quoted 3 lines
Quoted 3 lines
Just use b4 and everything should be fine, although remember about
b4 prep --auto-to-ccif you added new patches to the patchset.Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.
Please kindly resend and include all necessary To/Cc entries. </form letter>
How did you implement this feedback?
make
dtbs_checkW=1
# Check the lpc-pcc or pcc message from the log
Quoted 7 lines
make
dt_binding_check
# No Errormake coccicheck MODE=report
# Stop at the following log but no related log.
# OCaml scripting is unsupported.
# coccicheck failed
You answered probably to earlier part of email, not to the one I asked about.
Best regards,
Krzysztof
PATCH 2/3 ARM: dts: aspeed-g6: Add AST2600 LPC PCC support
In reply to Kevin ChenThe AST2600 has PCC controller in LPC, placed in LPC node.
--- arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi +7 -0
@@ -626,6 +626,13 @@ lpc_snoop: lpc-snoop@80 { status = "disabled"; }; + lpc_pcc: lpc-pcc@0 { + compatible = "aspeed,ast2600-lpc-pcc"; + reg = <0x0 0x140>; + interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + lhc: lhc@a0 { compatible = "aspeed,ast2600-lhc"; reg = <0xa0 0x24 0xc8 0x8>;
Signature · 1 line
2.34.1
PATCH 3/3 soc: aspeed: lpc-pcc: Add PCC controller support
In reply to Kevin ChenAdd LPC PCC controller driver to support POST code capture.
--- drivers/soc/aspeed/Kconfig | 10 + drivers/soc/aspeed/Makefile | 1 + drivers/soc/aspeed/aspeed-lpc-pcc.c | 505 ++++++++++++++++++++++++++++ 3 files changed, 516 insertions(+) create mode 100644 drivers/soc/aspeed/aspeed-lpc-pcc.c
drivers/soc/aspeed/Kconfig +10 -0
@@ -52,6 +52,16 @@ config ASPEED_SOCINFO help Say yes to support decoding of ASPEED BMC information. +config ASPEED_LPC_PCC + tristate "Aspeed Post Code Capture support" + select REGMAP + select MFD_SYSCON + default ARCH_ASPEED + help + Provides a driver to control the LPC PCC interface, + allowing the BMC to snoop data bytes written by the + the host to an arbitrary LPC I/O port. + endmenu endif
drivers/soc/aspeed/Makefile +1 -0
@@ -4,3 +4,4 @@ obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o obj-$(CONFIG_ASPEED_UART_ROUTING) += aspeed-uart-routing.o obj-$(CONFIG_ASPEED_P2A_CTRL) += aspeed-p2a-ctrl.o obj-$(CONFIG_ASPEED_SOCINFO) += aspeed-socinfo.o +obj-$(CONFIG_ASPEED_LPC_PCC) += aspeed-lpc-pcc.o
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +505 -0
505 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v0 3/3] soc: aspeed: lpc-pcc: Add PCC controller support
Quoted 4 lines · Kevin Chen
Add LPC PCC controller driver to support POST code capture.
Signed-off-by Kevin Chen <[email protected]>---
This patch was never tested with your DTS and bindings. Please do not send untested code.
Quoted 5 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +5
-0+ +/* +* A2600-15 AP note +* +* SW workaround to prevent generating Non-Fatal-Error (NFE)
drivers/soc/aspeed/aspeed-lpc-pcc.c line 245
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+* eSPI response when PCC is used for port I/O byte snooping +* over eSPI. +*/ +static int aspeed_a2600_15 (struct aspeed_pcc *pcc,struct device *dev) +{ +struct device_node *np; +u32 hicrb_en; + +/* abort if snoop is enabled */ + np =of_find_compatible_node (dev->parent->of_node,NULL ,"aspeed,ast2600-lpc-snoop" );
No, don't sprinkle compatible to epxress relationship. Use proper phandles or parent-child relationship.
Quoted 77 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +77
-0+if (np) { +if (of_device_is_available (np)) { +dev_err (dev,"A2600-15 should be applied with snoop disabled\n" ); +return -EPERM ; + } + } + +/* abort if port is not 4-bytes continuous range */ +if (pcc->port_xbits !=0x3 ) { +dev_err (dev,"A2600-15 should be applied on 4-bytes continuous I/O address range\n" ); +return -EINVAL ; + } + +/* set SNPWADR of snoop device */ +regmap_write (pcc->regmap,SNPWADR , pcc->port | ((pcc->port +2 ) <<16 )); + +/* set HICRB[15:14]=11b to enable ACCEPT response for SNPWADR */ + hicrb_en =HICRB_ENSNP0D |HICRB_ENSNP1D ; +regmap_update_bits (pcc->regmap,HICRB , hicrb_en, hicrb_en); + +/* set HICR6[19] to extend SNPWADR to 2x range */ +regmap_update_bits (pcc->regmap,HICR6 ,HICR6_EN2BMODE ,HICR6_EN2BMODE ); + +return 0 ; +} + +static int aspeed_pcc_enable (struct aspeed_pcc *pcc,struct device *dev) +{ +int rc; + +if (pcc->a2600_15) { + rc =aspeed_a2600_15 (pcc, dev); +if (rc) +return rc; + } + +/* record mode */ +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_MODE_SEL_MASK , + pcc->rec_mode <<PCCR0_MODE_SEL_SHIFT ); + +/* port address */ +regmap_update_bits (pcc->regmap,PCCR1 , +PCCR1_BASE_ADDR_MASK , + pcc->port <<PCCR1_BASE_ADDR_SHIFT ); + +/* port address high bits selection or parser control */ +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_ADDR_SEL_MASK , + pcc->port_hbits_select <<PCCR0_ADDR_SEL_SHIFT ); + +/* port address dont care bits */ +regmap_update_bits (pcc->regmap,PCCR1 , +PCCR1_DONT_CARE_BITS_MASK , + pcc->port_xbits <<PCCR1_DONT_CARE_BITS_SHIFT ); + +/* set DMA ring buffer size and enable interrupts */ +if (pcc->dma_mode) { +regmap_write (pcc->regmap,PCCR4 , pcc->dma.addr &0xffffffff ); +regmap_update_bits (pcc->regmap,PCCR5 ,PCCR5_DMA_ADDRH_MASK , + (pcc->dma.addr >>32 ) <<PCCR5_DMA_ADDRH_SHIFT ); +regmap_update_bits (pcc->regmap,PCCR5 ,PCCR5_DMA_LEN_MASK , + (pcc->dma.size /4 ) <<PCCR5_DMA_LEN_SHIFT ); +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_EN_DMA_INT |PCCR0_EN_DMA_MODE , +PCCR0_EN_DMA_INT |PCCR0_EN_DMA_MODE ); + }else { +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_RX_TRIG_LVL_MASK , +PCC_FIFO_THR_4_EIGHTH <<PCCR0_RX_TRIG_LVL_SHIFT ); +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_EN_RX_TMOUT_INT |PCCR0_EN_RX_AVAIL_INT , +PCCR0_EN_RX_TMOUT_INT |PCCR0_EN_RX_AVAIL_INT ); + } + +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_EN ,PCCR0_EN ); + +return 0 ;
drivers/soc/aspeed/aspeed-lpc-pcc.c line 332
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+} + +static int aspeed_pcc_probe (struct platform_device *pdev) +{ +int rc; +struct aspeed_pcc *pcc; +struct device *dev = &pdev->dev; +uint32_t fifo_size =PAGE_SIZE ; + + pcc =devm_kzalloc (&pdev->dev,sizeof (*pcc),GFP_KERNEL );
Why not dev?
drivers/soc/aspeed/aspeed-lpc-pcc.c line 337
Quoted 5 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +5
-0+if (!pcc) +return -ENOMEM ; + + pcc->dev = dev; + rc =of_property_read_u32 (dev->of_node,"port-addr" , &pcc->port);
Nope
drivers/soc/aspeed/aspeed-lpc-pcc.c line 344
Quoted 7 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +7
-0+if (rc) { +dev_err (dev,"cannot get port address\n" ); +return -ENODEV ; + } + +/* optional, by default: 0 -> 1-Byte mode */ +of_property_read_u32 (dev->of_node,"rec-mode" , &pcc->rec_mode);
Nope
drivers/soc/aspeed/aspeed-lpc-pcc.c line 352
Quoted 8 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +8
-0+if (!is_valid_rec_mode (pcc->rec_mode)) { +dev_err (dev,"invalid record mode: %u\n" , + pcc->rec_mode); +return -EINVAL ; + } + +/* optional, by default: 0 -> no don't care bits */ +of_property_read_u32 (dev->of_node,"port-addr-xbits" , &pcc->port_xbits);
Nope
drivers/soc/aspeed/aspeed-lpc-pcc.c line 363
Quoted 11 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +11
-0+ +/* +* optional, by default: 0 -> no high address bits +* +* Note that when record mode is set to 1-Byte, this +* property is ignored and the corresponding HW bits +* behave as read/write cycle parser control with the +* value set to 0b11 +*/ +if (pcc->rec_mode) { + of_property_read_u32(dev->of_node, "port-addr-hbits-select",
Nope, none of these properties exist.
drivers/soc/aspeed/aspeed-lpc-pcc.c line 375
Quoted 12 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +12
-0+ &pcc->port_hbits_select); +if (!is_valid_high_bits_select (pcc->port_hbits_select)) { +dev_err (dev,"invalid high address bits selection: %u\n" , + pcc->port_hbits_select); +return -EINVAL ; + } + }else { + pcc->port_hbits_select =0x3 ; + } + +/* AP note A2600-15 */ + pcc->a2600_15 =of_property_read_bool (dev->of_node,"A2600-15" );
NAK even more.
drivers/soc/aspeed/aspeed-lpc-pcc.c line 385
Quoted 9 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +9
-0+if (pcc->a2600_15) +dev_info (dev,"A2600-15 AP note patch is selected\n" ); +> + rc = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); +if (rc) { +dev_err (dev,"cannot set 64-bits DMA mask\n" ); +return rc; + } + + pcc->dma_mode =of_property_read_bool (dev->of_node,"dma-mode" );
NAK, drop
Quoted 7 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +7
-0+if (pcc->dma_mode) { + pcc->dma.size =PCC_DMA_BUFSZ ; + pcc->dma.virt =dmam_alloc_coherent (dev, + pcc->dma.size, + &pcc->dma.addr, +GFP_KERNEL ); +if (!pcc->dma.virt) {
drivers/soc/aspeed/aspeed-lpc-pcc.c line 402
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+dev_err (dev,"cannot allocate DMA buffer\n" ); +return -ENOMEM ; + } + + fifo_size =roundup (pcc->dma.size,PAGE_SIZE ); + } + + rc =kfifo_alloc (&pcc->fifo, fifo_size,GFP_KERNEL ); +if (rc) { +dev_err (dev,"cannot allocate kFIFO\n" );
Run coccinelle on your code first.
Quoted 51 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +51
-0+return -ENOMEM ; + } + + pcc->regmap =syscon_node_to_regmap (pdev->dev.parent->of_node); +if (IS_ERR (pcc->regmap)) { +dev_err (dev,"cannot map register\n" ); +return -ENODEV ; + } + +/* Disable PCC and DMA Mode for safety */ +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_EN |PCCR0_EN_DMA_MODE ,0 ); + +/* Clear Rx FIFO. */ +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_CLR_RX_FIFO ,1 ); + +/* Clear All interrupts status. */ +regmap_write (pcc->regmap,PCCR2 , +PCCR2_INT_STATUS_RX_OVER |PCCR2_INT_STATUS_DMA_DONE | +PCCR2_INT_STATUS_PATTERN_A |PCCR2_INT_STATUS_PATTERN_B ); + + pcc->irq =platform_get_irq (pdev,0 ); +if (pcc->irq <0 ) { +dev_err (dev,"cannot get IRQ\n" ); + rc = -ENODEV ; + goto err_free_kfifo; + } + + rc =devm_request_irq (dev, pcc->irq, aspeed_pcc_isr,0 ,DEVICE_NAME , pcc); +if (rc <0 ) { +dev_err (dev,"cannot request IRQ handler\n" ); + goto err_free_kfifo; + } + +init_waitqueue_head (&pcc->wq); + + pcc->mdev_id =ida_alloc (&aspeed_pcc_ida,GFP_KERNEL ); +if (pcc->mdev_id <0 ) { +dev_err (dev,"cannot allocate ID\n" ); +return pcc->mdev_id; + } + + pcc->mdev.parent = dev; + pcc->mdev.minor =MISC_DYNAMIC_MINOR ; + pcc->mdev.name =devm_kasprintf (dev,GFP_KERNEL ,"%s%d" ,DEVICE_NAME , + pcc->mdev_id); + pcc->mdev.fops = &pcc_fops; + rc =misc_register (&pcc->mdev); +if (rc) { +dev_err (dev,"cannot register misc device\n" ); + goto err_free_kfifo; + }
drivers/soc/aspeed/aspeed-lpc-pcc.c line 463
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+ + rc =aspeed_pcc_enable (pcc, dev); +if (rc) { +dev_err (dev,"cannot enable PCC\n" ); + goto err_dereg_mdev; + } + +dev_set_drvdata (&pdev->dev, pcc); + +dev_info (dev,"module loaded\n" );
Drop such function success messages, everywhere.
Best regards,
Krzysztof
RE: [PATCH v0 3/3] soc: aspeed: lpc-pcc: Add PCC controller support
Quoted 9 lines · Kevin Chen
Quoted 4 lines
Add LPC PCC controller driver to support POST code capture.
Signed-off-by Kevin Chen <[email protected]>---
This patch was never tested with your DTS and bindings. Please do not send untested code.
For the dts, I asked Google to upstream their dts using lpc_pcc node.
Quoted 12 lines
Quoted 12 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +11
-0+ +/* +* A2600-15 AP note +* +* SW workaround to prevent generating Non-Fatal-Error (NFE) +* eSPI response when PCC is used for port I/O byte snooping +* over eSPI. +*/ +static int aspeed_a2600_15 (struct aspeed_pcc *pcc,struct device +*dev) { +struct device_node *np;
Quoted 8 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 5 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +5
-0+u32 hicrb_en; + +/* abort if snoop is enabled */ + np =of_find_compatible_node (dev->parent->of_node,NULL , +"aspeed,ast2600-lpc-snoop" );No, don't sprinkle compatible to epxress relationship. Use proper phandles or parent-child relationship.
Agree, I will remove it.
Quoted 84 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 4 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +3
-0+if (np) { +if (of_device_is_available (np)) { + dev_err(dev, "A2600-15 should be applied with snoopdisabled\n");
drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 7 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +7
-0+return -EPERM ; + } + } + +/* abort if port is not 4-bytes continuous range */ +if (pcc->port_xbits !=0x3 ) { + dev_err(dev, "A2600-15 should be applied on 4-bytes continuous I/Oaddress range\n");
Quoted 42 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +42
-0+return -EINVAL ; + } + +/* set SNPWADR of snoop device */ +regmap_write (pcc->regmap,SNPWADR , pcc->port | ((pcc->port +2 ) << +16 )); + +/* set HICRB[15:14]=11b to enable ACCEPT response for SNPWADR */ + hicrb_en =HICRB_ENSNP0D |HICRB_ENSNP1D ; +regmap_update_bits (pcc->regmap,HICRB , hicrb_en, hicrb_en); + +/* set HICR6[19] to extend SNPWADR to 2x range */ +regmap_update_bits (pcc->regmap,HICR6 ,HICR6_EN2BMODE , +HICR6_EN2BMODE ); + +return 0 ; +} + +static int aspeed_pcc_enable (struct aspeed_pcc *pcc,struct device +*dev) { +int rc; + +if (pcc->a2600_15) { + rc =aspeed_a2600_15 (pcc, dev); +if (rc) +return rc; + } + +/* record mode */ +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_MODE_SEL_MASK , + pcc->rec_mode <<PCCR0_MODE_SEL_SHIFT ); + +/* port address */ +regmap_update_bits (pcc->regmap,PCCR1 , +PCCR1_BASE_ADDR_MASK , + pcc->port <<PCCR1_BASE_ADDR_SHIFT ); + +/* port address high bits selection or parser control */ +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_ADDR_SEL_MASK , + pcc->port_hbits_select <<PCCR0_ADDR_SEL_SHIFT );drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+ +/* port address dont care bits */ +regmap_update_bits (pcc->regmap,PCCR1 , +PCCR1_DONT_CARE_BITS_MASK , + pcc->port_xbits <<PCCR1_DONT_CARE_BITS_SHIFT ); + +/* set DMA ring buffer size and enable interrupts */ +if (pcc->dma_mode) { +regmap_write (pcc->regmap,PCCR4 , pcc->dma.addr &0xffffffff ); + regmap_update_bits(pcc->regmap, PCCR5,
PCCR5_DMA_ADDRH_MASK,Review
Quoted 1 line
(quoted diff) +1
-0+ (pcc->dma.addr >> 32) <<
PCCR5_DMA_ADDRH_SHIFT);Review
Quoted 1 line
(quoted diff) +1
-0+ regmap_update_bits(pcc->regmap, PCCR5,
PCCR5_DMA_LEN_MASK,drivers/soc/aspeed/aspeed-lpc-pcc.c line 315
Quoted 6 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +6
-0+ (pcc->dma.size / 4) << PCCR5_DMA_LEN_SHIFT); +regmap_update_bits (pcc->regmap,PCCR0 , +PCCR0_EN_DMA_INT |PCCR0_EN_DMA_MODE , +PCCR0_EN_DMA_INT |PCCR0_EN_DMA_MODE ); + }else { + regmap_update_bits(pcc->regmap, PCCR0,
PCCR0_RX_TRIG_LVL_MASK,Review
Quoted 1 line
(quoted diff) +1
-0+ PCC_FIFO_THR_4_EIGHTH <<
PCCR0_RX_TRIG_LVL_SHIFT);Review
Quoted 2 lines
(quoted diff) +2
-0+ regmap_update_bits(pcc->regmap, PCCR0, + PCCR0_EN_RX_TMOUT_INT |
PCCR0_EN_RX_AVAIL_INT,Review
Quoted 1 line
(quoted diff) +1
-0+ PCCR0_EN_RX_TMOUT_INT |
PCCR0_EN_RX_AVAIL_INT);
Quoted 16 lines
Quoted 4 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +4
-0+ } + +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_EN ,PCCR0_EN ); +drivers/soc/aspeed/aspeed-lpc-pcc.c line 332
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+return 0 ; +} + +static int aspeed_pcc_probe (struct platform_device *pdev) { +int rc; +struct aspeed_pcc *pcc; +struct device *dev = &pdev->dev; +uint32_t fifo_size =PAGE_SIZE ; + + pcc =devm_kzalloc (&pdev->dev,sizeof (*pcc),GFP_KERNEL );Why not dev?
Agree, I will change pcc to dev.
Quoted 8 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 337
Quoted 6 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +5
-0+if (!pcc) +return -ENOMEM ; + + pcc->dev = dev; + rc =of_property_read_u32 (dev->of_node,"port-addr" , &pcc->port);Nope
For lpc_snoop node, there is snoop-ports in lpc_snoop to specify which IO port address for use. In lpc_pcc, the usage is the same. Could I add the pcc-ports property?
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 344
Quoted 8 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +7
-0+if (rc) { +dev_err (dev,"cannot get port address\n" ); +return -ENODEV ; + } + +/* optional, by default: 0 -> 1-Byte mode */ +of_property_read_u32 (dev->of_node,"rec-mode" , &pcc->rec_mode);Nope
OK, I will remove the property.
Quoted 12 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +9
-0+if (!is_valid_rec_mode (pcc->rec_mode)) { +dev_err (dev,"invalid record mode: %u\n" , + pcc->rec_mode); +return -EINVAL ; + } + +/* optional, by default: 0 -> no don't care bits */ +of_property_read_u32 (dev->of_node,"port-addr-xbits" , +&pcc->port_xbits);Nope
OK, I will remove the property.
Quoted 14 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 363
Quoted 12 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +11
-0+ +/* +* optional, by default: 0 -> no high address bits +* +* Note that when record mode is set to 1-Byte, this +* property is ignored and the corresponding HW bits +* behave as read/write cycle parser control with the +* value set to 0b11 +*/ +if (pcc->rec_mode) { + of_property_read_u32(dev->of_node, "port-addr-hbits-select",Nope, none of these properties exist.
OK, I will remove the property.
Quoted 15 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 375
Quoted 13 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +12
-0+ &pcc->port_hbits_select); +if (!is_valid_high_bits_select (pcc->port_hbits_select)) { +dev_err (dev,"invalid high address bits selection: %u\n" , + pcc->port_hbits_select); +return -EINVAL ; + } + }else { + pcc->port_hbits_select =0x3 ; + } + +/* AP note A2600-15 */ + pcc->a2600_15 =of_property_read_bool (dev->of_node,"A2600-15" );NAK even more.
OK, I will remove the property.
Quoted 12 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 385
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +9
-0+if (pcc->a2600_15) +dev_info (dev,"A2600-15 AP note patch is selected\n" ); +> + rc = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); +if (rc) { +dev_err (dev,"cannot set 64-bits DMA mask\n" ); +return rc; + } + + pcc->dma_mode =of_property_read_bool (dev->of_node,"dma-mode" );NAK, drop
OK, I will remove the property.
Quoted 12 lines
Quoted 12 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +11
-0+if (pcc->dma_mode) { + pcc->dma.size =PCC_DMA_BUFSZ ; + pcc->dma.virt =dmam_alloc_coherent (dev, + pcc->dma.size, + &pcc->dma.addr, +GFP_KERNEL ); +if (!pcc->dma.virt) { +dev_err (dev,"cannot allocate DMA buffer\n" ); +return -ENOMEM ; + } +
Quoted 8 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 402
Quoted 6 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +6
-0+ fifo_size =roundup (pcc->dma.size,PAGE_SIZE ); + } + + rc =kfifo_alloc (&pcc->fifo, fifo_size,GFP_KERNEL ); +if (rc) { +dev_err (dev,"cannot allocate kFIFO\n" );Run coccinelle on your code first.
OK, I will try to run conccinelle by the following link.
https://docs.kernel.org/dev-tools/coccinelle.html
Quoted 61 lines
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +9
-0+return -ENOMEM ; + } + + pcc->regmap =syscon_node_to_regmap (pdev->dev.parent->of_node); +if (IS_ERR (pcc->regmap)) { +dev_err (dev,"cannot map register\n" ); +return -ENODEV ; + } +drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+/* Disable PCC and DMA Mode for safety */ +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_EN | +PCCR0_EN_DMA_MODE ,0 ); + +/* Clear Rx FIFO. */ +regmap_update_bits (pcc->regmap,PCCR0 ,PCCR0_CLR_RX_FIFO ,1 ); + +/* Clear All interrupts status. */ + regmap_write(pcc->regmap, PCCR2, + PCCR2_INT_STATUS_RX_OVER |
PCCR2_INT_STATUS_DMA_DONE|Review
Quoted 1 line
(quoted diff) +1
-0+ PCCR2_INT_STATUS_PATTERN_A |
PCCR2_INT_STATUS_PATTERN_B);drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 9 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +9
-0+ + pcc->irq =platform_get_irq (pdev,0 ); +if (pcc->irq <0 ) { +dev_err (dev,"cannot get IRQ\n" ); + rc = -ENODEV ; + goto err_free_kfifo; + } + + rc = devm_request_irq(dev, pcc->irq, aspeed_pcc_isr, 0, DEVICE_NAME,pcc);
Quoted 6 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +6
-0+if (rc <0 ) { +dev_err (dev,"cannot request IRQ handler\n" ); + goto err_free_kfifo; + } + +init_waitqueue_head (&pcc->wq);drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 10 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +10
-0+ + pcc->mdev_id =ida_alloc (&aspeed_pcc_ida,GFP_KERNEL ); +if (pcc->mdev_id <0 ) { +dev_err (dev,"cannot allocate ID\n" ); +return pcc->mdev_id; + } + + pcc->mdev.parent = dev; + pcc->mdev.minor =MISC_DYNAMIC_MINOR ; + pcc->mdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
DEVICE_NAME,Quoted 11 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +11
-0+ pcc->mdev_id); + pcc->mdev.fops = &pcc_fops; + rc =misc_register (&pcc->mdev); +if (rc) { +dev_err (dev,"cannot register misc device\n" ); + goto err_free_kfifo; + } + + rc =aspeed_pcc_enable (pcc, dev); +if (rc) { +dev_err (dev,"cannot enable PCC\n" );
Quoted 8 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c line 463
Quoted 6 lines
drivers/soc/aspeed/aspeed-lpc-pcc.c new file +6
-0+ goto err_dereg_mdev; + } + +dev_set_drvdata (&pdev->dev, pcc); + +dev_info (dev,"module loaded\n" );Drop such function success messages, everywhere.
OK, I will remove the messages.
Quoted 3 lines
Best regards,
Krzysztof
Rob Herring (Arm)
maintainerQuoted 17 lines · Kevin Chen
The AST2600 has PCC controller in LPC, placed in LPC node. As a result, add LPC PCC controller driver to support POST code capture.
Kevin Chen (3):
dt-binding: aspeed: Add LPC PCC controller
ARM: dts: aspeed-g6: Add AST2600 LPC PCC support
soc: aspeed: lpc-pcc: Add PCC controller support.../bindings/soc/aspeed/lpc-pcc.yaml | 51 ++ arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 + drivers/soc/aspeed/Kconfig | 10 + drivers/soc/aspeed/Makefile | 1 + drivers/soc/aspeed/aspeed-lpc-pcc.c | 505 ++++++++++++++++++ 5 files changed, 574 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/lpc-pcc.yaml create mode 100644 drivers/soc/aspeed/aspeed-lpc-pcc.c
Quoted 5 lines
--
2.34.1
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for [email protected]:
arch/arm/boot/dts/aspeed/aspeed-bmc-quanta-s6q.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge-4u.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-ast2600-evb-a1.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-inventec-transformers.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-inventec-starscream.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtjefferson.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-1s4u.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-elbert.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-qcom-dc-scm-v1.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ufispace-ncplite.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-fuji.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-greatlakes.dtb: lpc-pcc@0: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/soc/aspeed/lpc-pcc.yaml#