Skip to contentSkip to conversation

net: sxgbe: change conditional statement from if to switch

PATCH In review Jeongjun Park 2 participants 3 messages Jan 16, 2025 – Feb 19, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: sxgbe: change conditional statement from if to switch

Change the if conditional statement in sxgbe_rx_ctxt_wbstatus() to a switch conditional statement to improve readability, and also add processing for cases where all conditions are not satisfied.

---
 .../net/ethernet/samsung/sxgbe/sxgbe_desc.c   | 43 +++++++++++++------
 1 file changed, 30 insertions(+), 13 deletions(-)
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c +30 -13
index b33ebf2dca47..5e69ab8a4b90 100644
@@ -421,31 +421,48 @@ static void sxgbe_rx_ctxt_wbstatus(struct sxgbe_rx_ctxt_desc *p,
 	if (p->tstamp_dropped)
 		x->timestamp_dropped++;
 
-	/* ptp */
-	if (p->ptp_msgtype == RX_NO_PTP)
+	/* PTP Msg type */
+	switch (p->ptp_msgtype) {
+	case RX_NO_PTP:
 		x->rx_msg_type_no_ptp++;
-	else if (p->ptp_msgtype == RX_PTP_SYNC)
+		break;
+	case RX_PTP_SYNC:
 		x->rx_ptp_type_sync++;
-	else if (p->ptp_msgtype == RX_PTP_FOLLOW_UP)
+		break;
+	case RX_PTP_FOLLOW_UP:
 		x->rx_ptp_type_follow_up++;
-	else if (p->ptp_msgtype == RX_PTP_DELAY_REQ)
+		break;
+	case RX_PTP_DELAY_REQ:
 		x->rx_ptp_type_delay_req++;
-	else if (p->ptp_msgtype == RX_PTP_DELAY_RESP)
+		break;
+	case RX_PTP_DELAY_RESP:
 		x->rx_ptp_type_delay_resp++;
-	else if (p->ptp_msgtype == RX_PTP_PDELAY_REQ)
+		break;
+	case RX_PTP_PDELAY_REQ:
 		x->rx_ptp_type_pdelay_req++;
-	else if (p->ptp_msgtype == RX_PTP_PDELAY_RESP)
+		break;
+	case RX_PTP_PDELAY_RESP:
 		x->rx_ptp_type_pdelay_resp++;
-	else if (p->ptp_msgtype == RX_PTP_PDELAY_FOLLOW_UP)
+		break;
+	case RX_PTP_PDELAY_FOLLOW_UP:
 		x->rx_ptp_type_pdelay_follow_up++;
-	else if (p->ptp_msgtype == RX_PTP_ANNOUNCE)
+		break;
+	case RX_PTP_ANNOUNCE:
 		x->rx_ptp_announce++;
-	else if (p->ptp_msgtype == RX_PTP_MGMT)
+		break;
+	case RX_PTP_MGMT:
 		x->rx_ptp_mgmt++;
-	else if (p->ptp_msgtype == RX_PTP_SIGNAL)
+		break;
+	case RX_PTP_SIGNAL:
 		x->rx_ptp_signal++;
-	else if (p->ptp_msgtype == RX_PTP_RESV_MSG)
+		break;
+	case RX_PTP_RESV_MSG:
 		x->rx_ptp_resv_msg_type++;
+		break;
+	default:
+		pr_err("Invalid PTP Message type\n");
+		break;
+	}
 }
 
 /* Get rx timestamp status */

--

reviewer
#1 lore raw
Quoted 14 lines · Jeongjun Park

Change the if conditional statement in sxgbe_rx_ctxt_wbstatus() to a switch conditional statement to improve readability, and also add processing for cases where all conditions are not satisfied.

---
 .../net/ethernet/samsung/sxgbe/sxgbe_desc.c   | 43 +++++++++++++------
 1 file changed, 30 insertions(+), 13 deletions(-)
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c +0 -0
index b33ebf2dca47..5e69ab8a4b90 100644
@@ -421,31 +421,48 @@ static void sxgbe_rx_ctxt_wbstatus(struct sxgbe_rx_ctxt_desc *p,

...

drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c static void sxgbe_rx_ctxt_wbstatus(struct sxgbe_rx_ctxt_desc *p, · line 466

Quoted 5 lines
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c +4 -0
+	default:
+		pr_err("Invalid PTP Message type\n");
+		break;
+	}
 }

Hi Jeongjun,

I was wondering if it would be best if the error message above should be rate limited, or perhaps the callback enhanced to return an error in such cases. But that depends on where sxgbe_rx_ctxt_wbstatus is called. And I'm unable to find where the it called.

I see that sxgbe_rx_ctxt_wbstatus is registered as a get_rx_ctxt_tstamp_status callback. But is the get_rx_ctxt_tstamp_status callback called anywhere?

#2 lore raw
Quoted 27 lines · Simon Horman
Quoted 14 lines · Jeongjun Park

Change the if conditional statement in sxgbe_rx_ctxt_wbstatus() to a switch conditional statement to improve readability, and also add processing for cases where all conditions are not satisfied.

---
 .../net/ethernet/samsung/sxgbe/sxgbe_desc.c   | 43 +++++++++++++------
 1 file changed, 30 insertions(+), 13 deletions(-)
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c +0 -0
index b33ebf2dca47..5e69ab8a4b90 100644
@@ -421,31 +421,48 @@ static void sxgbe_rx_ctxt_wbstatus(struct sxgbe_rx_ctxt_desc *p,

...

drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c static void sxgbe_rx_ctxt_wbstatus(struct sxgbe_rx_ctxt_desc *p, · line 466

Quoted 5 lines
drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c +4 -0
+     default:
+             pr_err("Invalid PTP Message type\n");
+             break;
+     }
 }

Hi Jeongjun,

Quoted 7 lines

I was wondering if it would be best if the error message above should be rate limited, or perhaps the callback enhanced to return an error in such cases. But that depends on where sxgbe_rx_ctxt_wbstatus is called. And I'm unable to find where the it called.

I see that sxgbe_rx_ctxt_wbstatus is registered as a get_rx_ctxt_tstamp_status callback. But is the get_rx_ctxt_tstamp_status callback called anywhere?

Hello. Sorry for the late reply.

I still don't know exactly where sxgbe_rx_ctxt_wbstatus() is called. What I do know is that I can't find a function that calls this function within the Linux kernel. When I wrote this patch, I thought it would be good to refactor this function, so I wrote the patch, but I didn't know exactly where this function
was being used. I think it might be a function called from an external kernel driver
written by Samsung itself.

Regards,

Jeongjun Park