PCI: dwc: Simplify config resource lookup
PATCH 1/1 PCI: dwc: Simplify config resource lookup
From: Bjorn Helgaas <[email protected]>
If platform_get_resource_byname("config") fails, return error immediately and unindent the normal path. No functional change intended.
--- .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/pci/controller/dwc/pcie-designware-host.c +8 -8
@@ -436,18 +436,18 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)return ret; res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"config" ); -if (res) { - pp->cfg0_size =resource_size (res); - pp->cfg0_base = res->start; - - pp->va_cfg0_base =devm_pci_remap_cfg_resource (dev, res); -if (IS_ERR (pp->va_cfg0_base)) -return PTR_ERR (pp->va_cfg0_base); - }else { +if (!res) {dev_err (dev,"Missing *config* reg space\n" );return -ENODEV ; } + pp->cfg0_size =resource_size (res); + pp->cfg0_base = res->start; + + pp->va_cfg0_base =devm_pci_remap_cfg_resource (dev, res); +if (IS_ERR (pp->va_cfg0_base)) +return PTR_ERR (pp->va_cfg0_base); + bridge =devm_pci_alloc_host_bridge (dev,0 );if (!bridge)return -ENOMEM ;
Signature · 1 line
2.34.1
Quoted 6 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
If
platform_get_resource_byname("config")fails, return error immediately and unindent the normal path. No functional change intended.Signed-off-by Bjorn Helgaas <[email protected]>
Quoted 38 lines
--- .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/pci/controller/dwc/pcie-designware-host.c +8
-9@@ -436,18 +436,18 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)return ret; res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"config" ); -if (res) { - pp->cfg0_size =resource_size (res); - pp->cfg0_base = res->start; - - pp->va_cfg0_base =devm_pci_remap_cfg_resource (dev, res); -if (IS_ERR (pp->va_cfg0_base)) -return PTR_ERR (pp->va_cfg0_base); - }else { +if (!res) {dev_err (dev,"Missing *config* reg space\n" );return -ENODEV ; } + pp->cfg0_size =resource_size (res); + pp->cfg0_base = res->start; + + pp->va_cfg0_base =devm_pci_remap_cfg_resource (dev, res); +if (IS_ERR (pp->va_cfg0_base)) +return PTR_ERR (pp->va_cfg0_base); + bridge =devm_pci_alloc_host_bridge (dev,0 );if (!bridge)return -ENOMEM ; --2.34.1
Quoted 6 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
If
platform_get_resource_byname("config")fails, return error immediately and unindent the normal path. No functional change intended.Signed-off-by Bjorn Helgaas <[email protected]>
One nit below.
Quoted 12 lines
--- .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/pci/controller/dwc/pcie-designware-host.c +0
-0@@ -436,18 +436,18 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)return ret; res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"config" );
drivers/pci/controller/dwc/pcie-designware-host.c int dw_pcie_host_init(struct dw_pcie_rp *pp) · line 440
Quoted 10 lines
drivers/pci/controller/dwc/pcie-designware-host.c +1
-8-if (res) { - pp->cfg0_size =resource_size (res); - pp->cfg0_base = res->start; - - pp->va_cfg0_base =devm_pci_remap_cfg_resource (dev, res); -if (IS_ERR (pp->va_cfg0_base)) -return PTR_ERR (pp->va_cfg0_base); - }else { +if (!res) {dev_err (dev,"Missing *config* reg space\n" );
nit: How about:
"Missing \"config\" reg space"?
- Mani
Signature · 1 line
மணிவண்ணன் சதாசிவம்