Skip to contentSkip to conversation

linux-next: build failure after merge of the crc and sound trees

DISCUSSION Stephen Rothwell 3 participants 3 messages Jan 20, 2025 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the crc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

In file included from lib/gen_crc32table.c:5:
lib/crc32defs.h:13:10: warning: "CRC_LE_BITS" redefined
13 | # define CRC_LE_BITS 8

      |          ^~~~~~~~~~~
lib/crc32defs.h:5:10: note: this is the location of the previous definition
    5 | # define CRC_LE_BITS 64
      |          ^~~~~~~~~~~
lib/crc32defs.h:14:10: warning: "CRC_BE_BITS" redefined
   14 | # define CRC_BE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:6:10: note: this is the location of the previous definition
    6 | # define CRC_BE_BITS 64
      |          ^~~~~~~~~~~
In file included from lib/crc32.c:34:
lib/crc32defs.h:13:10: error: "CRC_LE_BITS" redefined [-Werror]
   13 | # define CRC_LE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:5:10: note: this is the location of the previous definition
    5 | # define CRC_LE_BITS 64
      |          ^~~~~~~~~~~
lib/crc32defs.h:14:10: error: "CRC_BE_BITS" redefined [-Werror]
   14 | # define CRC_BE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:6:10: note: this is the location of the previous definition
    6 | # define CRC_BE_BITS 64
      |          ^~~~~~~~~~~

cc1: all warnings being treated as errors

Probably caused by commit

bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")

from the sound tree - it selects CRC32_SARWATE.

$ grep CONFIG_CRC32_ .config
CONFIG_CRC32_IMPL_ARCH_PLUS_SLICEBY8=y
# CONFIG_CRC32_IMPL_ARCH_PLUS_SLICEBY1 is not set
# CONFIG_CRC32_IMPL_SLICEBY8 is not set
# CONFIG_CRC32_IMPL_SLICEBY4 is not set
# CONFIG_CRC32_IMPL_SLICEBY1 is not set
# CONFIG_CRC32_IMPL_BIT is not set
CONFIG_CRC32_ARCH=y
CONFIG_CRC32_SLICEBY8=y
CONFIG_CRC32_SARWATE=y

It looks like lib/crc32defs.h does not expect these last 2 to be enabled at the same time.

I have reverted the above sound tree commit for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 5 lines · Stephen Rothwell

Probably caused by commit

bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")

from the sound tree - it selects CRC32_SARWATE.

It needs to select CRC32, not CRC32_SARWATE. See 86c96e7289c5 where I already fixed the last one. Not sure why the same bug is getting added again.

- Eric

#2 lore raw
Quoted 10 lines · Eric Biggers
Quoted 5 lines · Stephen Rothwell

Probably caused by commit

bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")

from the sound tree - it selects CRC32_SARWATE.

It needs to select CRC32, not CRC32_SARWATE. See 86c96e7289c5 where I already fixed the last one. Not sure why the same bug is getting added again.

Sorry for the overlook. That's a new driver from the past after long development time, and obviously we overlooked this upstream change for i2c driver.

Will queue up your suggested fix.

thanks,

Takashi