Documentation/networking: Fix basic node example document ISO 15765-2
Subsystems (4)
PATCH 1/1 Documentation/networking: Fix basic node example document ISO 15765-2
In the current struct sockaddr_can tp is member of can_addr. tp is not member of struct sockaddr_can.
Signed-off-by Reyders Morales <[email protected]>
--- Documentation/networking/iso15765-2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/networking/iso15765-2.rst +2 -2
@@ -369,8 +369,8 @@ to their default. addr.can_family = AF_CAN; addr.can_ifindex = if_nametoindex("can0"); - addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG; - addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG; + addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG; + addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG; ret = bind(s, (struct sockaddr *)&addr, sizeof(addr)); if (ret < 0)
Signature · 1 line
2.43.0
Jonathan Corbet
maintainer[CC += netdev - they may want a resend after the merge window though]
Quoted 25 lines · Reyders Morales
In the current struct
sockaddr_cantp is member ofcan_addr. tp is not member of structsockaddr_can.Signed-off-by Reyders Morales <[email protected]>--- Documentation/networking/iso15765-2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Documentation/networking/iso15765-2.rst +2
-2@@ -369,8 +369,8 @@ to their default. addr.can_family = AF_CAN; addr.can_ifindex = if_nametoindex("can0"); - addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG; - addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG; + addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG; + addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG; ret = bind(s, (struct sockaddr *)&addr, sizeof(addr)); if (ret < 0)Signature · 1 line
2.43.0
Jakub Kicinski
maintainerQuoted 1 line · On Tue, 21 Jan 2025 17:06:08 -0700 Jonathan Corbet wrote:
[CC += netdev - they may want a resend after the merge window though]
Thanks! Yes, please resend after the merge window, and also include [email protected] at that time (ideally just run the patch thru scripts/get_maintainer.pl to get the full CC list).