event/dlb2: fix event weight handling in SSE code path
PATCH 1/1 event/dlb2: fix event weight handling in SSE code path
Commit 6e2e98d6775b ("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version.
Bugzilla ID: 1616
--- drivers/event/dlb2/dlb2_sse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/event/dlb2/dlb2_sse.c +6 -5
@@ -190,11 +190,11 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[3 ].data = ev[3 ].u64;/* will only be set for DLB 2.5 + */ -if (qm_port->cq_weight) { - qe[0 ].weight = ev[0 ].impl_opaque &3 ; - qe[1 ].weight = ev[1 ].impl_opaque &3 ; - qe[2 ].weight = ev[2 ].impl_opaque &3 ; - qe[3 ].weight = ev[3 ].impl_opaque &3 ; +if (qm_port->dlb2->enable_cq_weight) { + qe[0 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[0 ]); + qe[1 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[1 ]); + qe[2 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[2 ]); + qe[3 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[3 ]); }break ;
@@ -205,6 +205,7 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[i].cmd_byte = cmd_byte_map[qm_port->is_directed][ev[i].op]; qe[i].sched_type = sched_type[i]; + qe[i].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[i]); qe[i].data = ev[i].u64; qe[i].qid = queue_id[i]; qe[i].priority =EV_TO_DLB2_PRIO (ev[i].priority);
Signature · 1 line
2.43.0
Quoted 21 lines
-----Original Message-----
From: Bruce Richardson <[email protected]>
Sent: Tuesday, January 21, 2025 10:42 PM
To: [email protected]
Cc: Pravin Pathak <[email protected]>; Bruce Richardson <[email protected]>; [email protected]
Subject: [EXTERNAL] [PATCH] event/dlb2: fix event weight handling in SSE code pathCommit
6e2e98d6775b("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function
Commit6e2e98d6775b("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version.
Quoted 3 lines
Bugzilla ID: 1616
Fixes 6e2e98d6775b ("event/dlb2: support independent enqueue")
@Pravin Pathak Please review and ack to merge for rc1.
Quoted 43 lines
Signed-off-by Bruce Richardson <[email protected]>--- drivers/event/dlb2/dlb2_sse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)drivers/event/dlb2/dlb2_sse.c index renamed from drivers/event/dlb2/dlb2_sse.c +0
-0
248d7519d5..f2e1f9fb7e100644drivers/event/dlb2/dlb2_sse.c +5
-5@@ -190,11 +190,11 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[3 ].data = ev[3 ].u64;/* will only be set for DLB 2.5 + */ -if (qm_port->cq_weight) { - qe[0 ].weight = ev[0 ].impl_opaque &3 ; - qe[1 ].weight = ev[1 ].impl_opaque &3 ; - qe[2 ].weight = ev[2 ].impl_opaque &3 ; - qe[3 ].weight = ev[3 ].impl_opaque &3 ; +if (qm_port->dlb2->enable_cq_weight) { + qe[0 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[0 ]); + qe[1 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[1 ]); + qe[2 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[2 ]); + qe[3].weight =
RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[3]);drivers/event/dlb2/dlb2_sse.c +1
-0}break ;@@ -205,6 +205,7 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[i].cmd_byte = cmd_byte_map[qm_port- >is_directed][ev[i].op]; qe[i].sched_type = sched_type[i]; + qe[i].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[i]); qe[i].data = ev[i].u64;drivers/event/dlb2/dlb2_sse.c +0
-1qe[i].qid = queue_id[i]; qe[i].priority =EV_TO_DLB2_PRIO (ev[i].priority); --2.43.0
Quoted 61 lines
-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Tuesday, January 21, 2025 12:12 PM
To: [email protected]
Cc: Pathak, Pravin <[email protected]>; Richardson, Bruce <[email protected]>; [email protected]
Subject: [PATCH] event/dlb2: fix event weight handling in SSE code pathCommit
6e2e98d6775b("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version.Bugzilla ID: 1616
Fixes 6e2e98d6775b ("event/dlb2: support independent enqueue")Signed-off-by Bruce Richardson <[email protected]>--- drivers/event/dlb2/dlb2_sse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)drivers/event/dlb2/dlb2_sse.c +4
-5@@ -190,11 +190,11 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[3 ].data = ev[3 ].u64;/* will only be set for DLB 2.5 + */ -if (qm_port->cq_weight) { - qe[0 ].weight = ev[0 ].impl_opaque &3 ; - qe[1 ].weight = ev[1 ].impl_opaque &3 ; - qe[2 ].weight = ev[2 ].impl_opaque &3 ; - qe[3 ].weight = ev[3 ].impl_opaque &3 ; +if (qm_port->dlb2->enable_cq_weight) { + qe[0 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[0 ]); + qe[1 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[1 ]); + qe[2].weight =
RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[2]);drivers/event/dlb2/dlb2_sse.c +1
-0+ qe[3].weight =
RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[3]);drivers/event/dlb2/dlb2_sse.c +1
-0}break ;@@ -205,6 +205,7 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[i].cmd_byte = cmd_byte_map[qm_port- >is_directed][ev[i].op]; qe[i].sched_type = sched_type[i]; + qe[i].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[i]); qe[i].data = ev[i].u64;drivers/event/dlb2/dlb2_sse.c +0
-1qe[i].qid = queue_id[i]; qe[i].priority =EV_TO_DLB2_PRIO (ev[i].priority); --2.43.0
Jerin Jacob
AppliedQuoted 10 lines
-----Original Message-----
From: Pathak, Pravin <[email protected]>
Sent: Thursday, February 6, 2025 8:20 PM
To: Richardson, Bruce <[email protected]>; [email protected]
Cc: [email protected]
Subject: [EXTERNAL] RE: [PATCH] event/dlb2: fix event weight handling in SSE code path
Quoted 5 lines
Reviewed-by Pravin Pathak <pravin. pathak@ intel. com> > -----OriginalMessage----- > From: Richardson, Bruce <bruce. richardson@ intel. com> > Sent:
Tuesday, January 21, 2025 12: 12 PM > To: dev@ dpdk. org > Cc: Pathak, PravinReviewed-by Pravin Pathak <[email protected]>
Applied to dpdk-next-eventdev/for-main. Thanks
Quoted 63 lines
drivers/event/dlb2/dlb2_sse.c dlb2_event_build_hcws(struct dlb2_port
Quoted 30 lines
-----Original Message-----
From: Richardson, Bruce <[email protected]>
Sent: Tuesday, January 21, 2025 12:12 PM
To: [email protected]
Cc: Pathak, Pravin <[email protected]>; Richardson, Bruce <[email protected]>; [email protected]
Subject: [PATCH] event/dlb2: fix event weight handling in SSE code pathCommit
6e2e98d6775b("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version.Bugzilla ID: 1616
Fixes 6e2e98d6775b ("event/dlb2: support independent enqueue")Signed-off-by Bruce Richardson <[email protected]>--- drivers/event/dlb2/dlb2_sse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)(quoted diff) +0
-0
b/drivers/event/dlb2/dlb2_sse.cindex248d7519d5..f2e1f9fb7e100644drivers/event/dlb2/dlb2_sse.c +0
-0@@ -190,11 +190,11 @@ dlb2_event_build_hcws(struct dlb2_port
*qm_port,Quoted 32 lines
drivers/event/dlb2/dlb2_sse.c +5
-5qe[3 ].data = ev[3 ].u64;/* will only be set for DLB 2.5 + */ -if (qm_port->cq_weight) { - qe[0 ].weight = ev[0 ].impl_opaque &3 ; - qe[1 ].weight = ev[1 ].impl_opaque &3 ; - qe[2 ].weight = ev[2 ].impl_opaque &3 ; - qe[3 ].weight = ev[3 ].impl_opaque &3 ; +if (qm_port->dlb2->enable_cq_weight) { + qe[0 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[0 ]); + qe[1 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[1 ]); + qe[2 ].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[2 ]); + qe[3].weight =
RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[3]);drivers/event/dlb2/dlb2_sse.c +1
-0}break ;@@ -205,6 +205,7 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, qe[i].cmd_byte = cmd_byte_map[qm_port- >is_directed][ev[i].op]; qe[i].sched_type = sched_type[i]; + qe[i].weight =RTE_PMD_DLB2_GET_QE_WEIGHT (&ev[i]); qe[i].data = ev[i].u64;drivers/event/dlb2/dlb2_sse.c +0
-1qe[i].qid = queue_id[i]; qe[i].priority =EV_TO_DLB2_PRIO (ev[i].priority); --2.43.0