Skip to contentSkip to conversation

dt-bindings: omap: Add TI Pandaboard A4 variant

PATCH Applied Tom Rini 4 participants 5 messages Jan 23, 2025 – Feb 6, 2025

Subsystems (3)
lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH v2 1/2 dt-bindings: omap: Add TI Pandaboard A4 variant

Document the ti,omap4-panda-a4 compatible string in the appropriate place within the omap family binding file.

---
Changes in v2:
- Include as part of the series with binding addition, make this be first.
- Rework as suggested by Andreas Kemnade (slight rewording after Robert reminded me A4 a production rev and not "alpha" rev.

Cc Aaro Koskinen <[email protected]>
Cc Andreas Kemnade <[email protected]>
Cc Conor Dooley <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Nelson <[email protected]>
Cc Roger Quadros <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/ti/omap.yaml +7 -0
index 93e04a109a12..3603edd7361d 100644
@@ -141,6 +141,13 @@ properties:
           - const: ti,omap4430
           - const: ti,omap4
 
+      - description: OMAP4 PandaBoard Revision A4 and later
+        items:
+          - const: ti,omap4-panda-a4
+          - const: ti,omap4-panda
+          - const: ti,omap4430
+          - const: ti,omap4
+
       - description: OMAP4 DuoVero with Parlor expansion board/daughter board
         items:
           - const: gumstix,omap4-duovero-parlor
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH v2 2/2 ARM: dts: omap4-panda-a4: Add missing model and compatible properties

When moving the model and compatible properties out of the common Pandaboard files and in to the specific boards, the omap4-panda-a4 file wasn't updated as well and so has lacked a model and compatible entry ever since.

Fixes a1a57abaaf82 ("ARM: dts: omap4-panda: Fix model and SoC family details")

---
Changes in v2:
- Include as part of the series with binding addition, make this the second patch.

Cc Conor Dooley <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Nelson <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts +5 -0
index 8fd076e5d1b0..4b8bfd0188ad 100644
@@ -7,6 +7,11 @@
 #include "omap443x.dtsi"
 #include "omap4-panda-common.dtsi"
 
+/ {
+	model = "TI OMAP4 PandaBoard (A4)";
+	compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430", "ti,omap4";
+};
+
 /* Pandaboard Rev A4+ have external pullups on SCL & SDA */
 &dss_hdmi_pins {
 	pinctrl-single,pins = <
Signature · 1 line
2.43.0
Acked-by on v2 1/2
#2 lore raw
In reply to Tom Rini
Quoted 4 lines · Tom Rini

Document the ti,omap4-panda-a4 compatible string in the appropriate place within the omap family binding file.

Quoted 44 lines

---
Changes in v2:
- Include as part of the series with binding addition, make this be first.
- Rework as suggested by Andreas Kemnade (slight rewording after Robert reminded me A4 a production rev and not "alpha" rev.

Cc Aaro Koskinen <[email protected]>
Cc Andreas Kemnade <[email protected]>
Cc Conor Dooley <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Nelson <[email protected]>
Cc Roger Quadros <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/ti/omap.yaml +7 -0
index 93e04a109a12..3603edd7361d 100644
@@ -141,6 +141,13 @@ properties:
           - const: ti,omap4430
           - const: ti,omap4
 
+      - description: OMAP4 PandaBoard Revision A4 and later
+        items:
+          - const: ti,omap4-panda-a4
+          - const: ti,omap4-panda
+          - const: ti,omap4430
+          - const: ti,omap4
+
       - description: OMAP4 DuoVero with Parlor expansion board/daughter board
         items:
           - const: gumstix,omap4-duovero-parlor
Signature · 1 line
2.43.0
maintainer Applied
#4 lore raw
In reply to Tom Rini
Quoted 4 lines · Tom Rini

Document the ti,omap4-panda-a4 compatible string in the appropriate place within the omap family binding file.

Applied, thanks!

[1/2] dt-bindings: omap: Add TI Pandaboard A4 variant

      commit: a4ec13e6101ea750b17dc23f49f21d3f57623099
[2/2] ARM: dts: omap4-panda-a4: Add missing model and compatible properties
      commit: ea07a4775df03852c353514b5b7646a17bd425be

Best regards,

Signature · 1 line
Kevin Hilman <[email protected]>