Skip to contentSkip to conversation

nodejs: upgrade 22.12.0 -> 22.13.1

PATCH In review Jason Schonberg 3 participants 4 messages Jan 23, 2025 – Mar 17, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nodejs: upgrade 22.12.0 -> 22.13.1

Changelog for 22.13.0 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.0
Changelog for 22.13.1 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.1

The 22.13.1 release is a security fix addressing four CVEs.

CVE-2025-23083 - src,loader,permission: throw on InternalWorker use when permission model is enabled (High) CVE-2025-23085 - src: fix HTTP2 mem leak on premature close and ERR_PROTO (Medium) CVE-2025-23084 - path: fix path traversal in normalize() on Windows (Medium) CVE-2025-22150 - Use of Insufficiently Random Values in undici fetch() (Medium)

I introduce a new patch with this recipe 0001-Do-not-use-glob-in-deps.patch to revert https://github.com/nodejs/node/commit/77e2869ca6

I restored 0001-deps-disable-io_uring-support-in-libuv.patch as suggested here : https://lore.kernel.org/all/[email protected]/

---
 .../oe-npm-cache                              |   0
 ....12.bb => nodejs-oe-cache-native_22.13.bb} |   0
 .../nodejs/0001-Do-not-use-glob-in-deps.patch |  22 ++++
 ...ps-disable-io_uring-support-in-libuv.patch | 106 ++++++++++--------
 .../{nodejs_22.12.0.bb => nodejs_22.13.1.bb}  |   3 +-
 5 files changed, 81 insertions(+), 50 deletions(-)
 rename meta-oe/recipes-devtools/nodejs/{nodejs-oe-cache-22.12 => nodejs-oe-cache-22.13}/oe-npm-cache (100%)
 rename meta-oe/recipes-devtools/nodejs/{nodejs-oe-cache-native_22.12.bb => nodejs-oe-cache-native_22.13.bb} (100%)
 create mode 100644 meta-oe/recipes-devtools/nodejs/nodejs/0001-Do-not-use-glob-in-deps.patch
 rename meta-oe/recipes-devtools/nodejs/{nodejs_22.12.0.bb => nodejs_22.13.1.bb} (98%)
meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-22.13/oe-npm-cache renamed from meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-22.12/oe-npm-cache +0 -0
similarity index 100%
rename from meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-22.12/oe-npm-cache
rename to meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-22.13/oe-npm-cache
meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-native_22.13.bb renamed from meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-native_22.12.bb +0 -0
similarity index 100%
rename from meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-native_22.12.bb
rename to meta-oe/recipes-devtools/nodejs/nodejs-oe-cache-native_22.13.bb
meta-oe/recipes-devtools/nodejs/nodejs/0001-Do-not-use-glob-in-deps.patch new file +22 -0
new file mode 100644
index 000000000..551869523
@@ -0,0 +1,22 @@
+// Revert the patch found here https://github.com/nodejs/node/commit/fe1dd26398e1887b96b2dc51ab59371ad4d6bc20?diff=unified&w=0
+// so that the dependencies are still explicitly enumerated.  That way we
+// can pick and choose which pieces to build and which to use existing system
+// packages for.
+
+Upstream-Status: Inappropriate [embedded specific]
+
+
+--- a/Makefile	2025-01-11 14:37:29.059536707 -0500
++++ b/Makefile	2025-01-11 14:39:52.419867046 -0500
+@@ -171,7 +171,8 @@
+ 	$(warning '$@' target is a noop)
+ 
+ out/Makefile: config.gypi common.gypi common_node.gypi node.gyp \
+-	deps/*/*.gyp \
++	deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
++	deps/simdutf/simdutf.gyp deps/ada/ada.gyp deps/nbytes/nbytes.gyp \
+ 	tools/v8_gypfiles/toolchain.gypi \
+ 	tools/v8_gypfiles/features.gypi \
+ 	tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
+
+
meta-oe/recipes-devtools/nodejs/nodejs/0001-deps-disable-io_uring-support-in-libuv.patch +57 -49

109 lines not on this page · raw message

meta-oe/recipes-devtools/nodejs/nodejs_22.13.1.bb renamed from meta-oe/recipes-devtools/nodejs/nodejs_22.12.0.bb +2 -1
similarity index 98%
rename from meta-oe/recipes-devtools/nodejs/nodejs_22.12.0.bb
rename to meta-oe/recipes-devtools/nodejs/nodejs_22.13.1.bb
index 194df4c33..9c145695f 100644
@@ -20,6 +20,7 @@ COMPATIBLE_HOST:riscv32 = "null"
 COMPATIBLE_HOST:powerpc = "null"
 
 SRC_URI = "http://nodejs.org/dist/v${PV}/node-v${PV}.tar.xz \
+           file://0001-Do-not-use-glob-in-deps.patch \
            file://0001-Disable-running-gyp-files-for-bundled-deps.patch \
            file://0004-v8-don-t-override-ARM-CFLAGS.patch \
            file://system-c-ares.patch \
@@ -36,7 +37,7 @@ SRC_URI:append:class-target = " \
 SRC_URI:append:toolchain-clang:powerpc64le = " \
            file://0001-ppc64-Do-not-use-mminimal-toc-with-clang.patch \
            "
-SRC_URI[sha256sum] = "fe1bc4be004dc12721ea2cb671b08a21de01c6976960ef8a1248798589679e16"
+SRC_URI[sha256sum] = "cfce282119390f7e0c2220410924428e90dadcb2df1744c0c4a0e7baae387cc2"
 
 S = "${WORKDIR}/node-v${PV}"
 
Signature · 1 line
2.43.0
#1 lore raw

Re: [oe] [meta-oe][PATCH] nodejs: upgrade 22.12.0 -> 22.13.1 (build failure on Ubuntu 20.04)

Hello,

Quoted 10 lines · J. S. via lists.openembedded.org

Changelog for 22.13.0 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.0
Changelog for 22.13.1 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.1

The 22.13.1 release is a security fix addressing four CVEs.

CVE-2025-23083 - src,loader,permission: throw on InternalWorker use when permission model is enabled (High) CVE-2025-23085 - src: fix HTTP2 mem leak on premature close and ERR_PROTO (Medium) CVE-2025-23084 - path: fix path traversal in normalize() on Windows (Medium) CVE-2025-22150 - Use of Insufficiently Random Values in undici fetch() (Medium)

Quoted 5 lines

I introduce a new patch with this recipe 0001-Do-not-use-glob-in-deps.patch to revert https://github.com/nodejs/node/commit/77e2869ca6

I restored 0001-deps-disable-io_uring-support-in-libuv.patch as suggested here : https://lore.kernel.org/all/[email protected]/

nodejs_22.13.1 has now been merged for a long time but it appears that it fails to build on Ubuntu 20.04:

    g++  -o $TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o ../deps/simdutf/simdutf.cpp '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' -I../deps/simdutf  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -fno-strict-aliasing -std=gnu++20 -MMD -MF $TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/.deps/$TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o.d.raw  -isystem$TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/recipe-sysroot-native/usr/include -O2 -pipe -c

g++: error: unrecognized command line option ‘-std=gnu++20’; did you mean ‘-std=gnu++2a’?
make[1]: *** [deps/simdutf/simdutf.host.mk:80: /home/yocon/Documents/projets/yocto/contribution-yocto/builds/build-qemux86-64/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o] Error 1
make: *** [Makefile:135: node] Error 2
ERROR: oe_runmake failed
WARNING: ./tmp/work/core2-64-poky-linux/nodejs/22.13.1/temp/run.do_compile:182 exit 1 from 'exit 1'

I interpret this as "nodejs wants to build a native binary using g++ but with the wrong std=gnu++20 option for the Ubuntu 20.04 g++ (which is 9.4 and only has --std=gnu++2a)"

This has been seen on autobuilder each time the meta-oe reproducibility
test happens on a ubuntu 20.04 worker :
* https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/36/steps/32/logs/stdio
* https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/33/steps/32/logs/stdio

I've tried to look around but the nodejs build system does not look trivial... I've tried to patch the generated Makefiles to use std=gnu++2a but it broke on a syntax error. So, in the end, I doubt that Ubuntu 20.04 can build this nodejs.

Does anyone has any idea on how to approach this?

Regards,

--
Yoann Congal
Smile ECS

#2 lore raw

Re: [oe] [meta-oe][PATCH] nodejs: upgrade 22.12.0 -> 22.13.1 (build failure on Ubuntu 20.04)

Quoted 38 lines · Yoann Congal via lists.openembedded.org

Hello,

Quoted 10 lines · J. S. via lists.openembedded.org

Changelog for 22.13.0 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.0
Changelog for 22.13.1 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.1

The 22.13.1 release is a security fix addressing four CVEs.

CVE-2025-23083 - src,loader,permission: throw on InternalWorker use when permission model is enabled (High) CVE-2025-23085 - src: fix HTTP2 mem leak on premature close and ERR_PROTO (Medium) CVE-2025-23084 - path: fix path traversal in normalize() on Windows (Medium) CVE-2025-22150 - Use of Insufficiently Random Values in undici fetch() (Medium)

Quoted 5 lines

I introduce a new patch with this recipe 0001-Do-not-use-glob-in-deps.patch to revert https://github.com/nodejs/node/commit/77e2869ca6

I restored 0001-deps-disable-io_uring-support-in-libuv.patch as suggested here : https://lore.kernel.org/all/[email protected]/

nodejs_22.13.1 has now been merged for a long time but it appears that it fails to build on Ubuntu 20.04:

    g++  -o $TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o ../deps/simdutf/simdutf.cpp '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' -I../deps/simdutf  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -fno-strict-aliasing -std=gnu++20 -MMD -MF $TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/.deps/$TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o.d.raw  -isystem$TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/recipe-sysroot-native/usr/include -O2 -pipe -c

g++: error: unrecognized command line option ‘-std=gnu++20’; did you mean ‘-std=gnu++2a’?
make[1]: *** [deps/simdutf/simdutf.host.mk:80: /home/yocon/Documents/projets/yocto/contribution-yocto/builds/build-qemux86-64/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o] Error 1
make: *** [Makefile:135: node] Error 2
ERROR: oe_runmake failed
WARNING: ./tmp/work/core2-64-poky-linux/nodejs/22.13.1/temp/run.do_compile:182 exit 1 from 'exit 1'

I interpret this as "nodejs wants to build a native binary using g++ but with the wrong std=gnu++20 option for the Ubuntu 20.04 g++ (which is 9.4 and only has --std=gnu++2a)"

This has been seen on autobuilder each time the meta-oe reproducibility
test happens on a ubuntu 20.04 worker :
* https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/36/steps/32/logs/stdio
* https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/33/steps/32/logs/stdio

Quoted 6 lines

I've tried to look around but the nodejs build system does not look trivial... I've tried to patch the generated Makefiles to use std=gnu++2a but it broke on a syntax error. So, in the end, I doubt that Ubuntu 20.04 can build this nodejs.

Does anyone has any idea on how to approach this?

yeah it came up before as well, you have two options, there is a gcc10 available for ubuntu 20.04

sudo apt update -y
sudo apt upgrade -y
sudo apt install -y build-essential
sudo apt install -y gcc-10 g++-10 cpp-10
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10

another approach is to use buildtools tarball.

I would recommend to use buildtools tarball, packages like protobuf, grpc are now expecting c++ compiler to support C++17 std by default and it will
only get worse.

Quoted 16 lines

Regards,

--
Yoann Congal
Smile ECS

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#116018): https://lists.openembedded.org/g/openembedded-devel/message/116018
Mute This Topic: https://lists.openembedded.org/mt/111740469/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw

Re: [oe] [meta-oe][PATCH] nodejs: upgrade 22.12.0 -> 22.13.1 (build failure on Ubuntu 20.04)

Quoted 42 lines · Khem Raj
Quoted 38 lines · Yoann Congal via lists.openembedded.org

Hello,

Quoted 10 lines · J. S. via lists.openembedded.org

Changelog for 22.13.0 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.0
Changelog for 22.13.1 : https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.13.1

The 22.13.1 release is a security fix addressing four CVEs.

CVE-2025-23083 - src,loader,permission: throw on InternalWorker use when permission model is enabled (High) CVE-2025-23085 - src: fix HTTP2 mem leak on premature close and ERR_PROTO (Medium) CVE-2025-23084 - path: fix path traversal in normalize() on Windows (Medium) CVE-2025-22150 - Use of Insufficiently Random Values in undici fetch() (Medium)

Quoted 5 lines

I introduce a new patch with this recipe 0001-Do-not-use-glob-in-deps.patch to revert https://github.com/nodejs/node/commit/77e2869ca6

I restored 0001-deps-disable-io_uring-support-in-libuv.patch as suggested here : https://lore.kernel.org/all/[email protected]/

nodejs_22.13.1 has now been merged for a long time but it appears that it fails to build on Ubuntu 20.04:

    g++  -o $TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o ../deps/simdutf/simdutf.cpp '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' -I../deps/simdutf  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -fno-strict-aliasing -std=gnu++20 -MMD -MF $TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/.deps/$TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o.d.raw  -isystem$TOPDIR/tmp/work/core2-64-poky-linux/nodejs/22.13.1/recipe-sysroot-native/usr/include -O2 -pipe -c

g++: error: unrecognized command line option ‘-std=gnu++20’; did you mean ‘-std=gnu++2a’?
make[1]: *** [deps/simdutf/simdutf.host.mk:80: /home/yocon/Documents/projets/yocto/contribution-yocto/builds/build-qemux86-64/tmp/work/core2-64-poky-linux/nodejs/22.13.1/node-v22.13.1/out/Release/obj.host/simdutf/deps/simdutf/simdutf.o] Error 1
make: *** [Makefile:135: node] Error 2
ERROR: oe_runmake failed
WARNING: ./tmp/work/core2-64-poky-linux/nodejs/22.13.1/temp/run.do_compile:182 exit 1 from 'exit 1'

I interpret this as "nodejs wants to build a native binary using g++ but with the wrong std=gnu++20 option for the Ubuntu 20.04 g++ (which is 9.4 and only has --std=gnu++2a)"

This has been seen on autobuilder each time the meta-oe reproducibility
test happens on a ubuntu 20.04 worker :
* https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/36/steps/32/logs/stdio
* https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/33/steps/32/logs/stdio

Quoted 6 lines
Quoted 6 lines

I've tried to look around but the nodejs build system does not look trivial... I've tried to patch the generated Makefiles to use std=gnu++2a but it broke on a syntax error. So, in the end, I doubt that Ubuntu 20.04 can build this nodejs.

Does anyone has any idea on how to approach this?

Hi Khem,

Quoted 11 lines

yeah it came up before as well, you have two options, there is a gcc10 available for ubuntu 20.04

sudo apt update -y
sudo apt upgrade -y
sudo apt install -y build-essential
sudo apt install -y gcc-10 g++-10 cpp-10
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10

Quoted 6 lines

another approach is to use buildtools tarball.

I would recommend to use buildtools tarball, packages like protobuf, grpc are now expecting c++ compiler to support C++17 std by default and it will
only get worse.

Thanks!

Ok, so that is a known problem.

Should we try to avoid the Ubuntu 20.04 workers for the meta-oe reproducibility test?
And maybe document somewhere that, while Ubunutu 20.04 is tested for OE-Core, it does not work for meta-openembedded?

Quoted 16 lines
Quoted 16 lines

Regards,

--
Yoann Congal
Smile ECS

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#116018): https://lists.openembedded.org/g/openembedded-devel/message/116018
Mute This Topic: https://lists.openembedded.org/mt/111740469/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Yoann Congal
Smile ECS - Tech expert