Skip to contentSkip to conversation

ld.lld: error: undefined symbol: curve25519_arch

PATCH In review kernel test robot 3 participants 8 messages Jan 22, 2025 – Feb 24, 2025

Subsystems (10)
Arm (32-bit) x86 PowerPC MIPS +6 more subsystems
lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c4b9570cfb63501638db720f3bee9f6dfd044b82
commit: b42519dbba838c928e82b55f32712fbe3eed2c45 crypto: ppc/curve25519 - Update Kconfig and Makefile for ppc64le
date:   8 months ago
config: powerpc64-randconfig-r111-20250122 (https://download.01.org/0day-ci/archive/20250123/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20250123/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> ld.lld: error: undefined symbol: curve25519_arch
   >>> referenced by curve25519.h:39 (include/crypto/curve25519.h:39)
   >>>               lib/crypto/curve25519-selftest.o:(curve25519_selftest) in archive vmlinux.a
   >>> referenced by curve25519.h:39 (include/crypto/curve25519.h:39)
   >>>               lib/crypto/curve25519-selftest.o:(curve25519_selftest) in archive vmlinux.a
   >>> referenced by curve25519.h:39 (include/crypto/curve25519.h:39)
   >>>               drivers/net/wireguard/noise.o:(wg_noise_precompute_static_static) in archive vmlinux.a
   >>> referenced 1 more times
--
>> ld.lld: error: undefined symbol: curve25519_base_arch
   >>> referenced by curve25519.h:55 (include/crypto/curve25519.h:55)
   >>>               lib/crypto/curve25519-selftest.o:(curve25519_selftest) in archive vmlinux.a
   >>> referenced by curve25519.h:55 (include/crypto/curve25519.h:55)
   >>>               drivers/net/wireguard/noise.o:(wg_noise_set_static_identity_private_key) in archive vmlinux.a
   >>> referenced by curve25519.h:55 (include/crypto/curve25519.h:55)
   >>>               drivers/net/wireguard/noise.o:(wg_noise_handshake_create_initiation) in archive vmlinux.a
   >>> referenced 2 more times
--
>> ld.lld: error: undefined symbol: curve25519_generic
   >>> referenced by curve25519-selftest.c:1307 (lib/crypto/curve25519-selftest.c:1307)
   >>>               lib/crypto/curve25519-selftest.o:(curve25519_selftest) in archive vmlinux.a
--
>> ld.lld: error: undefined symbol: curve25519_null_point
   >>> referenced by curve25519-selftest.c
   >>>               lib/crypto/curve25519-selftest.o:(.toc+0x0) in archive vmlinux.a
   >>> referenced by noise.c
   >>>               drivers/net/wireguard/noise.o:(.toc+0x0) in archive vmlinux.a
   >>> referenced by netlink.c
   >>>               drivers/net/wireguard/netlink.o:(.toc+0x8) in archive vmlinux.a

pahole: .tmp_vmlinux.btf: Invalid argument ld.lld: error: .btf.vmlinux.bin.o: unknown file type

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for CRYPTO_LIB_CURVE25519
Depends on [m]: CRYPTO_ARCH_HAVE_LIB_CURVE25519 [=m] || !CRYPTO_ARCH_HAVE_LIB_CURVE25519 [=m] Selected by [y]:
- WIREGUARD [=y] && NETDEVICES [=y] && NET_CORE [=y] && NET [=y] && INET [=y] && (IPV6 [=y] || !IPV6 [=y]) && !KMSAN [=n]

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
maintainer
#1 lore raw

PATCH 1/1 crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

Quoted 7 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c4b9570cfb63501638db720f3bee9f6dfd044b82
commit: b42519dbba838c928e82b55f32712fbe3eed2c45 crypto: ppc/curve25519 - Update Kconfig and Makefile for ppc64le
date:   8 months ago
config: powerpc64-randconfig-r111-20250122 (https://download.01.org/0day-ci/archive/20250123/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20250123/[email protected]/reproduce)

Thanks for the report. This is the old built-in vs. modular Kconfig problem. This patch should fix it:

---8<---
The HAVE_ARCH Kconfig options in lib/crypto try to solve the modular versus built-in problem, but it still fails when the the LIB option (e.g., CRYPTO_LIB_CURVE25519) is selected externally.

Fix this by introducing a level of indirection with ARCH_MAY_HAVE Kconfig options, these then go on to select the ARCH_HAVE options if the ARCH Kconfig options matches that of the LIB option.

arch/arm/crypto/Kconfig +3 -3
index 32650c8431d9..47d9cc59f254 100644
@@ -6,7 +6,7 @@ config CRYPTO_CURVE25519_NEON
 	tristate "Public key crypto: Curve25519 (NEON)"
 	depends on KERNEL_MODE_NEON
 	select CRYPTO_LIB_CURVE25519_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CURVE25519
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CURVE25519
 	help
 	  Curve25519 algorithm
 
@@ -47,7 +47,7 @@ config CRYPTO_NHPOLY1305_NEON
 config CRYPTO_POLY1305_ARM
 	tristate "Hash functions: Poly1305 (NEON)"
 	select CRYPTO_HASH
-	select CRYPTO_ARCH_HAVE_LIB_POLY1305
+	select CRYPTO_ARCH_MAY_HAVE_LIB_POLY1305
 	help
 	  Poly1305 authenticator algorithm (RFC7539)
 
@@ -214,7 +214,7 @@ config CRYPTO_AES_ARM_CE
 config CRYPTO_CHACHA20_NEON
 	tristate "Ciphers: ChaCha20, XChaCha20, XChaCha12 (NEON)"
 	select CRYPTO_SKCIPHER
-	select CRYPTO_ARCH_HAVE_LIB_CHACHA
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
 	help
 	  Length-preserving ciphers: ChaCha20, XChaCha20, and XChaCha12
 	  stream cipher algorithms
arch/powerpc/crypto/Kconfig +2 -2
index 5b315e9756b3..e453cb0c82d2 100644
@@ -6,7 +6,7 @@ config CRYPTO_CURVE25519_PPC64
 	tristate "Public key crypto: Curve25519 (PowerPC64)"
 	depends on PPC64 && CPU_LITTLE_ENDIAN
 	select CRYPTO_LIB_CURVE25519_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CURVE25519
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CURVE25519
 	help
 	  Curve25519 algorithm
 
@@ -95,7 +95,7 @@ config CRYPTO_CHACHA20_P10
 	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
 	select CRYPTO_SKCIPHER
 	select CRYPTO_LIB_CHACHA_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CHACHA
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
 	help
 	  Length-preserving ciphers: ChaCha20, XChaCha20, and XChaCha12
 	  stream cipher algorithms
arch/x86/crypto/Kconfig +3 -3
index 4757bf922075..c189dad0969b 100644
@@ -6,7 +6,7 @@ config CRYPTO_CURVE25519_X86
 	tristate "Public key crypto: Curve25519 (ADX)"
 	depends on X86 && 64BIT
 	select CRYPTO_LIB_CURVE25519_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CURVE25519
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CURVE25519
 	help
 	  Curve25519 algorithm
 
@@ -352,7 +352,7 @@ config CRYPTO_CHACHA20_X86_64
 	depends on X86 && 64BIT
 	select CRYPTO_SKCIPHER
 	select CRYPTO_LIB_CHACHA_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CHACHA
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
 	help
 	  Length-preserving ciphers: ChaCha20, XChaCha20, and XChaCha12
 	  stream cipher algorithms
@@ -420,7 +420,7 @@ config CRYPTO_POLY1305_X86_64
 	tristate "Hash functions: Poly1305 (SSE2/AVX2)"
 	depends on X86 && 64BIT
 	select CRYPTO_LIB_POLY1305_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_POLY1305
+	select CRYPTO_ARCH_MAY_HAVE_LIB_POLY1305
 	help
 	  Poly1305 authenticator algorithm (RFC7539)
 
lib/crypto/Kconfig +18 -8
index b01253cac70a..c542ef1d64d0 100644
@@ -42,12 +42,17 @@ config CRYPTO_LIB_BLAKE2S_GENERIC
 	  of CRYPTO_LIB_BLAKE2S.
 
 config CRYPTO_ARCH_HAVE_LIB_CHACHA
-	tristate
+	bool
 	help
 	  Declares whether the architecture provides an arch-specific
 	  accelerated implementation of the ChaCha library interface,
 	  either builtin or as a module.
 
+config CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
+	tristate
+	select CRYPTO_ARCH_HAVE_LIB_CHACHA if CRYPTO_LIB_CHACHA=m
+	select CRYPTO_ARCH_HAVE_LIB_CHACHA if CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA=y
+
 config CRYPTO_LIB_CHACHA_GENERIC
 	tristate
 	select CRYPTO_LIB_UTILS
@@ -60,7 +65,6 @@ config CRYPTO_LIB_CHACHA_GENERIC
 
 config CRYPTO_LIB_CHACHA
 	tristate "ChaCha library interface"
-	depends on CRYPTO_ARCH_HAVE_LIB_CHACHA || !CRYPTO_ARCH_HAVE_LIB_CHACHA
 	select CRYPTO_LIB_CHACHA_GENERIC if CRYPTO_ARCH_HAVE_LIB_CHACHA=n
 	help
 	  Enable the ChaCha library interface. This interface may be fulfilled
@@ -68,12 +72,17 @@ config CRYPTO_LIB_CHACHA
 	  is available and enabled.
 
 config CRYPTO_ARCH_HAVE_LIB_CURVE25519
-	tristate
+	bool
 	help
 	  Declares whether the architecture provides an arch-specific
 	  accelerated implementation of the Curve25519 library interface,
 	  either builtin or as a module.
 
+config CRYPTO_ARCH_MAY_HAVE_LIB_CURVE25519
+	tristate
+	select CRYPTO_ARCH_HAVE_LIB_CURVE25519 if CRYPTO_LIB_CURVE25519=m
+	select CRYPTO_ARCH_HAVE_LIB_CURVE25519 if CRYPTO_ARCH_MAY_HAVE_LIB_CURVE25519=y
+
 config CRYPTO_LIB_CURVE25519_GENERIC
 	tristate
 	help
@@ -85,7 +94,6 @@ config CRYPTO_LIB_CURVE25519_GENERIC
 
 config CRYPTO_LIB_CURVE25519
 	tristate "Curve25519 scalar multiplication library"
-	depends on CRYPTO_ARCH_HAVE_LIB_CURVE25519 || !CRYPTO_ARCH_HAVE_LIB_CURVE25519
 	select CRYPTO_LIB_CURVE25519_GENERIC if CRYPTO_ARCH_HAVE_LIB_CURVE25519=n
 	select CRYPTO_LIB_UTILS
 	help
@@ -104,12 +112,17 @@ config CRYPTO_LIB_POLY1305_RSIZE
 	default 1
 
 config CRYPTO_ARCH_HAVE_LIB_POLY1305
-	tristate
+	bool
 	help
 	  Declares whether the architecture provides an arch-specific
 	  accelerated implementation of the Poly1305 library interface,
 	  either builtin or as a module.
 
+config CRYPTO_ARCH_MAY_HAVE_LIB_POLY1305
+	tristate
+	select CRYPTO_ARCH_HAVE_LIB_POLY1305 if CRYPTO_LIB_POLY1305=m
+	select CRYPTO_ARCH_HAVE_LIB_POLY1305 if CRYPTO_ARCH_MAY_HAVE_LIB_POLY1305=y
+
 config CRYPTO_LIB_POLY1305_GENERIC
 	tristate
 	help
@@ -121,7 +134,6 @@ config CRYPTO_LIB_POLY1305_GENERIC
 
 config CRYPTO_LIB_POLY1305
 	tristate "Poly1305 library interface"
-	depends on CRYPTO_ARCH_HAVE_LIB_POLY1305 || !CRYPTO_ARCH_HAVE_LIB_POLY1305
 	select CRYPTO_LIB_POLY1305_GENERIC if CRYPTO_ARCH_HAVE_LIB_POLY1305=n
 	help
 	  Enable the Poly1305 library interface. This interface may be fulfilled
@@ -130,8 +142,6 @@ config CRYPTO_LIB_POLY1305
 
 config CRYPTO_LIB_CHACHA20POLY1305
 	tristate "ChaCha20-Poly1305 AEAD support (8-byte nonce library version)"
-	depends on CRYPTO_ARCH_HAVE_LIB_CHACHA || !CRYPTO_ARCH_HAVE_LIB_CHACHA
-	depends on CRYPTO_ARCH_HAVE_LIB_POLY1305 || !CRYPTO_ARCH_HAVE_LIB_POLY1305
 	depends on CRYPTO
 	select CRYPTO_LIB_CHACHA
 	select CRYPTO_LIB_POLY1305
Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer
#2 lore raw

Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

Quoted 30 lines · Herbert Xu
Quoted 7 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c4b9570cfb63501638db720f3bee9f6dfd044b82
commit: b42519dbba838c928e82b55f32712fbe3eed2c45 crypto: ppc/curve25519 - Update Kconfig and Makefile for ppc64le
date:   8 months ago
config: powerpc64-randconfig-r111-20250122 (https://download.01.org/0day-ci/archive/20250123/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20250123/[email protected]/reproduce)

Thanks for the report. This is the old built-in vs. modular Kconfig problem. This patch should fix it:

---8<---
The HAVE_ARCH Kconfig options in lib/crypto try to solve the modular versus built-in problem, but it still fails when the the LIB option (e.g., CRYPTO_LIB_CURVE25519) is selected externally.

Fix this by introducing a level of indirection with ARCH_MAY_HAVE Kconfig options, these then go on to select the ARCH_HAVE options if the ARCH Kconfig options matches that of the LIB option.

arch/arm/crypto/Kconfig +0 -0
index 32650c8431d9..47d9cc59f254 100644

arch/arm/crypto/Kconfig config CRYPTO_CURVE25519_NEON · line 11

Quoted 7 lines
arch/arm/crypto/Kconfig +1 -1
@@ -6,7 +6,7 @@ config CRYPTO_CURVE25519_NEON
 	tristate "Public key crypto: Curve25519 (NEON)"
 	depends on KERNEL_MODE_NEON
 	select CRYPTO_LIB_CURVE25519_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CURVE25519
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CURVE25519
 	help
 	  Curve25519 algorithm

Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be consistent with the CRC library, the many other ARCH_HAS_* options, and CRYPTO_LIB_CURVE25519_GENERIC. Nothing uses names that contain "MAY_HAVE", which is ambiguous.

FWIW, at some point the arch optimized crypto algorithms also need to just be enabled by default. The fact that they're not is a longstanding bug that is really harmful to users and needs to be fixed.

- Eric

maintainer
#3 lore raw

Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

Quoted 9 lines · Eric Biggers

Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be consistent with the CRC library, the many other ARCH_HAS_* options, and CRYPTO_LIB_CURVE25519_GENERIC. Nothing uses names that contain "MAY_HAVE", which is ambiguous.

FWIW, at some point the arch optimized crypto algorithms also need to just be enabled by default. The fact that they're not is a longstanding bug that is really harmful to users and needs to be fixed.

I'm simply responding to an lkp report. While your suggestions may have merit, I don't have the time to pursue them.

Feel free to send patches if you wish.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer
#4 lore raw

Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

Quoted 7 lines · Herbert Xu
Quoted 6 lines · Eric Biggers

Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be consistent with the CRC library, the many other ARCH_HAS_* options, and CRYPTO_LIB_CURVE25519_GENERIC. Nothing uses names that contain "MAY_HAVE", which is ambiguous.

Quoted 6 lines
Quoted 3 lines

FWIW, at some point the arch optimized crypto algorithms also need to just be enabled by default. The fact that they're not is a longstanding bug that is really harmful to users and needs to be fixed.

I'm simply responding to an lkp report. While your suggestions may have merit, I don't have the time to pursue them.

The way that the arch options are selected is very much related to this issue, but even disregarding that the first paragraph of my response is a review comment directly on this patch about the naming it uses.

- Eric

maintainer
#5 lore raw

Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

Quoted 4 lines · Eric Biggers

The way that the arch options are selected is very much related to this issue, but even disregarding that the first paragraph of my response is a review comment directly on this patch about the naming it uses.

The CRC situation is not the same unfortunately. For better or worse, the crypto API glue code is currently entangled with the lib/crypto arch code. Meaning that a single Kconfig option ends up selecting both.

So I don't see how the MAY_HAVE options can map onto the ones that you've used for CRC.

Sure you can clean this up and perhaps make the lib/crypto arch code always built-in. But that is not something I wish to spend time on.

In any case, none of these new options are publicly exposed so you can rename them down the line with very little effort.

Cheers,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
author build bot
#6 lore raw

Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular

In reply to Herbert Xu
kernel test robot noticed the following build errors:

Hi Herbert,

kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master linus/master v6.14-rc3 next-20250221] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-lib-Kconfig-Fix-lib-built-in-failure-when-arch-is-modular/20250212-125048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/Z6woN4vgdaywOZxm%40gondor.apana.org.au
patch subject: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular
config: s390-randconfig-r072-20250223 (https://download.01.org/0day-ci/archive/20250223/[email protected]/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250223/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

s390x-linux-ld: lib/crypto/chacha20poly1305.o: in function `chacha20poly1305_encrypt':

>> chacha20poly1305.c:(.text+0x27a): undefined reference to `chacha_init_arch'
   s390x-linux-ld: lib/crypto/chacha20poly1305.o: in function `__chacha20poly1305_encrypt':
>> chacha20poly1305.c:(.text+0x5bc): undefined reference to `chacha_crypt_arch'
>> s390x-linux-ld: chacha20poly1305.c:(.text+0x638): undefined reference to `chacha_crypt_arch'
   s390x-linux-ld: lib/crypto/chacha20poly1305.o: in function `xchacha_init':
   chacha20poly1305.c:(.text+0x9f2): undefined reference to `chacha_init_arch'
>> s390x-linux-ld: chacha20poly1305.c:(.text+0xa04): undefined reference to `hchacha_block_arch'
>> s390x-linux-ld: chacha20poly1305.c:(.text+0xa1a): undefined reference to `chacha_init_arch'

s390x-linux-ld: lib/crypto/chacha20poly1305.o: in function `chacha20poly1305_decrypt':
chacha20poly1305.c:(.text+0xeca): undefined reference to `chacha_init_arch'
s390x-linux-ld: lib/crypto/chacha20poly1305.o: in function `__chacha20poly1305_decrypt':
chacha20poly1305.c:(.text+0x126a): undefined reference to `chacha_crypt_arch'
s390x-linux-ld: chacha20poly1305.c:(.text+0x13ca): undefined reference to `chacha_crypt_arch'
s390x-linux-ld: lib/crypto/chacha20poly1305.o: in function `chacha20poly1305_crypt_sg_inplace':
chacha20poly1305.c:(.text+0x18ec): undefined reference to `chacha_init_arch'
s390x-linux-ld: chacha20poly1305.c:(.text+0x190c): undefined reference to `chacha_crypt_arch'
s390x-linux-ld: chacha20poly1305.c:(.text+0x1bb6): undefined reference to `chacha_crypt_arch'
s390x-linux-ld: chacha20poly1305.c:(.text+0x1c24): undefined reference to `chacha_crypt_arch'

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
maintainer
#7 lore raw

PATCH 1/1 crypto: lib/Kconfig - Fix lib built-in and modular failure for arm64/mips/s390

Quoted 9 lines · kernel test robot

kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master linus/master v6.14-rc3 next-20250221] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

Quoted 7 lines
url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-lib-Kconfig-Fix-lib-built-in-failure-when-arch-is-modular/20250212-125048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/Z6woN4vgdaywOZxm%40gondor.apana.org.au
patch subject: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular
config: s390-randconfig-r072-20250223 (https://download.01.org/0day-ci/archive/20250223/[email protected]/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250223/[email protected]/reproduce)

Thanks for the report. I missed a few architectures in the patch:

---8<---
Some architectures were missed in the ARCH_MAY_HAVE patch, do the same for them to stop build failures involving modular arch code and built-in generic code.

Note that this isn't actually a regression since the same build failure was also possible on these architectures before, just with a different set of initial configuration options.

arch/arm64/crypto/Kconfig +2 -2
index 5636ab83f22a..3d90efdcf5a5 100644
@@ -29,7 +29,7 @@ config CRYPTO_POLY1305_NEON
 	tristate "Hash functions: Poly1305 (NEON)"
 	depends on KERNEL_MODE_NEON
 	select CRYPTO_HASH
-	select CRYPTO_ARCH_HAVE_LIB_POLY1305
+	select CRYPTO_ARCH_MAY_HAVE_LIB_POLY1305
 	help
 	  Poly1305 authenticator algorithm (RFC7539)
 
@@ -190,7 +190,7 @@ config CRYPTO_CHACHA20_NEON
 	depends on KERNEL_MODE_NEON
 	select CRYPTO_SKCIPHER
 	select CRYPTO_LIB_CHACHA_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CHACHA
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
 	help
 	  Length-preserving ciphers: ChaCha20, XChaCha20, and XChaCha12
 	  stream cipher algorithms
arch/mips/crypto/Kconfig +2 -2
index 7decd40c4e20..cbeb2f62eb79 100644
@@ -5,7 +5,7 @@ menu "Accelerated Cryptographic Algorithms for CPU (mips)"
 config CRYPTO_POLY1305_MIPS
 	tristate "Hash functions: Poly1305"
 	depends on MIPS
-	select CRYPTO_ARCH_HAVE_LIB_POLY1305
+	select CRYPTO_ARCH_MAY_HAVE_LIB_POLY1305
 	help
 	  Poly1305 authenticator algorithm (RFC7539)
 
@@ -55,7 +55,7 @@ config CRYPTO_CHACHA_MIPS
 	tristate "Ciphers: ChaCha20, XChaCha20, XChaCha12 (MIPS32r2)"
 	depends on CPU_MIPS32_R2
 	select CRYPTO_SKCIPHER
-	select CRYPTO_ARCH_HAVE_LIB_CHACHA
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
 	help
 	  Length-preserving ciphers: ChaCha20, XChaCha20, and XChaCha12
 	  stream cipher algorithms
arch/s390/crypto/Kconfig +1 -1
index b760232537f1..6f7495264943 100644
@@ -112,7 +112,7 @@ config CRYPTO_CHACHA_S390
 	depends on S390
 	select CRYPTO_SKCIPHER
 	select CRYPTO_LIB_CHACHA_GENERIC
-	select CRYPTO_ARCH_HAVE_LIB_CHACHA
+	select CRYPTO_ARCH_MAY_HAVE_LIB_CHACHA
 	help
 	  Length-preserving cipher: ChaCha20 stream cipher (RFC 7539)
 
Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt