Skip to contentSkip to conversation

spi: ca_sflash: Remove redundant dependency

PATCH In review Alexander Dahl 3 participants 6 messages Jan 23, 2025 – Feb 12, 2025 1 message not in the archive SPI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/2 spi: ca_sflash: Remove redundant dependency

This is inside of an 'if DM_SPI' block, and thus always true.

---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
index 96ea033082b..6555142a41e 100644
@@ -135,7 +135,7 @@ config BCMSTB_SPI
 
 config CORTINA_SFLASH
 	bool "Cortina-Access Serial Flash controller driver"
-	depends on DM_SPI && SPI_MEM
+	depends on SPI_MEM
 	help
 	  Enable the Cortina-Access Serial Flash controller driver. This driver
 	  can be used to access the SPI NOR/NAND flash on platforms embedding this
Signature · 1 line
2.39.5
#4 lore raw

PATCH 2/2 spi: atmel-quadspi: Depend on SPI_MEM

In reply to a message not in the archive

Most other spi-mem drivers also depend on SPI_MEM. Fixes this build error:

arm-v5te-linux-gnueabi-ld.bfd: drivers/spi/atmel-quadspi.o: in function `atmel_qspi_supports_op':
/mnt/data/adahl/src/u-boot/drivers/spi/atmel-quadspi.c:460: undefined reference to `spi_mem_default_supports_op' make[1]: *** [/mnt/data/adahl/src/u-boot/Makefile:1821: u-boot] Error 1

---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
index 6555142a41e..a916b711ba8 100644
@@ -85,7 +85,7 @@ config ATH79_SPI
 
 config ATMEL_QSPI
 	bool "Atmel Quad SPI Controller"
-	depends on ARCH_AT91
+	depends on ARCH_AT91 && SPI_MEM
 	help
 	  Enable the Atmel Quad SPI controller in master mode. This driver
 	  does not support generic SPI. The implementation supports only the
Signature · 1 line
2.39.5
Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] spi: atmel-quadspi: Depend on SPI_MEM

Quoted 8 lines · Alexander Dahl

Most other spi-mem drivers also depend on SPI_MEM. Fixes this build error:

arm-v5te-linux-gnueabi-ld.bfd: drivers/spi/atmel-quadspi.o: in function `atmel_qspi_supports_op':
/mnt/data/adahl/src/u-boot/drivers/spi/atmel-quadspi.c:460: undefined reference to `spi_mem_default_supports_op' make[1]: *** [/mnt/data/adahl/src/u-boot/Makefile:1821: u-boot] Error 1

Signature · 1 line
Tom
#6 lore raw

Re: [PATCH 2/2] spi: atmel-quadspi: Depend on SPI_MEM

Quoted 5 lines · Tom Rini
Quoted 3 lines · Alexander Dahl

Most other spi-mem drivers also depend on SPI_MEM. Fixes this build error:

Quoted 8 lines
Quoted 5 lines

arm-v5te-linux-gnueabi-ld.bfd: drivers/spi/atmel-quadspi.o: in function `atmel_qspi_supports_op':
/mnt/data/adahl/src/u-boot/drivers/spi/atmel-quadspi.c:460: undefined reference to `spi_mem_default_supports_op' make[1]: *** [/mnt/data/adahl/src/u-boot/Makefile:1821: u-boot] Error 1

Applied to u-boot-at91/next !
Thanks