Skip to contentSkip to conversation

fix gcc-15 compiling error: too many arguments to function eppic_init

PATCH In review Coiby Xu 2 participants 4 messages Jan 23, 2025 – Feb 19, 2025

Subsystems (2)
lore
Share & tools
lore

Coiby Xu

author
#0 lore raw

PATCH 1/1 fix gcc-15 compiling error: too many arguments to function eppic_init

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2340813

When building makekdumpfile against gcc-15, the following error is shown,

    erase_info.c: In function ‘process_eppic_file’:
    erase_info.c:2226:13: error: too many arguments to function ‘eppic_init’; expected 0, have 1
     2226 |         if (eppic_init(&eppic_cb)) {
          |             ^~~~~~~~~~ ~~~~~~~~~
    make: *** [Makefile:109: erase_info.o] Error 1
---
 erase_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
erase_info.c +1 -1
index cbe1681..af6bfae 100644
@@ -2192,7 +2192,7 @@ process_eppic_file(char *name_config)
 {
 	void *handle;
 	void (*eppic_load)(char *), (*eppic_unload)(char *);
-	int (*eppic_init)();
+	int (*eppic_init)(struct call_back *);
 
 	/*
 	 * Dynamically load the eppic_makedumpfile.so library.
Signature · 1 line
2.48.1
author
#1 lore raw

Re: [PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

Hi Kazuhito,

In case you miss this patch because I forgot to prefix the email subject with "makedumpfile".

Quoted 3 lines · Coiby Xu

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2340813

When building makekdumpfile against gcc-15, the following error is

               ^^^^^^^^^^^^^
               makedumpfile

Oh, there is a typo. Please help me fix it if you are going to merge the patch. Thanks!

Quoted 29 lines

shown,

   erase_info.c: In function ‘process_eppic_file’:
   erase_info.c:2226:13: error: too many arguments to function ‘eppic_init’; expected 0, have 1
    2226 |         if (eppic_init(&eppic_cb)) {
         |             ^~~~~~~~~~ ~~~~~~~~~
   make: *** [Makefile:109: erase_info.o] Error 1

---
erase_info.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
erase_info.c +1 -1
index cbe1681..af6bfae 100644
@@ -2192,7 +2192,7 @@ process_eppic_file(char *name_config)
 {
 	void *handle;
 	void (*eppic_load)(char *), (*eppic_unload)(char *);
-	int (*eppic_init)();
+	int (*eppic_init)(struct call_back *);
 
 	/*
 	 * Dynamically load the eppic_makedumpfile.so library.
Signature · 1 line
2.48.1
Signature · 2 lines
Best regards,
Coiby
#2 lore raw

RE: [PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

Hi Coiby,

Oops. I'm so sorry. I will correct any typos found next.

But, Thanks for finding this building error and fixing. When building makekdumpfile against gcc-14, not problem. However, certainly could not build using gcc-15. Thanks!

Best regards,
Masa

-----Original Message-----
From: kexec <[email protected]> On Behalf Of Coiby Xu
Sent: Tuesday, February 11, 2025 4:18 PM
To: [email protected]; Kazuhito Hagio <[email protected]>
Subject: Re: [PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

Hi Kazuhito,

In case you miss this patch because I forgot to prefix the email subject with "makedumpfile".

Quoted 3 lines · Coiby Xu

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2340813

When building makekdumpfile against gcc-15, the following error is

                ^^^^^^^^^^^^^
                makedumpfile

Oh, there is a typo. Please help me fix it if you are going to merge the patch. Thanks!

Quoted 29 lines

shown,

   erase_info.c: In function ‘process_eppic_file’:
   erase_info.c:2226:13: error: too many arguments to function ‘eppic_init’; expected 0, have 1
    2226 |         if (eppic_init(&eppic_cb)) {
         |             ^~~~~~~~~~ ~~~~~~~~~
   make: *** [Makefile:109: erase_info.o] Error 1

---
erase_info.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
erase_info.c +1 -1
index cbe1681..af6bfae 100644
@@ -2192,7 +2192,7 @@ process_eppic_file(char *name_config)
 {
 	void *handle;
 	void (*eppic_load)(char *), (*eppic_unload)(char *);
-	int (*eppic_init)();
+	int (*eppic_init)(struct call_back *);
 
 	/*
 	 * Dynamically load the eppic_makedumpfile.so library.
Signature · 1 line
2.48.1
Signature · 2 lines
Best regards,
Coiby
author
#3 lore raw

Re: [PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

Quoted 1 line · YAMAZAKI MASAMITSU(山崎 真光)

Hi Coiby,

Hi Masa,

Quoted 1 line

Oops. I'm so sorry. I will correct any typos found next.

No problem. Maybe I can also resend one version with typos corrected next time.

Quoted 4 lines

But, Thanks for finding this building error and fixing. When building makekdumpfile against gcc-14, not problem. However, certainly could not build using gcc-15. Thanks!

Thanks for reviewing and merging the patch!

Quoted 58 lines

Best regards,
Masa

-----Original Message-----
From: kexec <[email protected]> On Behalf Of Coiby Xu
Sent: Tuesday, February 11, 2025 4:18 PM
To: [email protected]; Kazuhito Hagio <[email protected]>
Subject: Re: [PATCH] makedumpfile: fix gcc-15 compiling error: too many arguments to function eppic_init

Hi Kazuhito,

In case you miss this patch because I forgot to prefix the email subject with "makedumpfile".

Quoted 3 lines · Coiby Xu

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2340813

When building makekdumpfile against gcc-15, the following error is

               ^^^^^^^^^^^^^
               makedumpfile

Oh, there is a typo. Please help me fix it if you are going to merge the patch. Thanks!

Quoted 29 lines

shown,

   erase_info.c: In function ‘process_eppic_file’:
   erase_info.c:2226:13: error: too many arguments to function ‘eppic_init’; expected 0, have 1
    2226 |         if (eppic_init(&eppic_cb)) {
         |             ^~~~~~~~~~ ~~~~~~~~~
   make: *** [Makefile:109: erase_info.o] Error 1

---
erase_info.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
erase_info.c +1 -2
index cbe1681..af6bfae 100644
@@ -2192,7 +2192,7 @@ process_eppic_file(char *name_config)
 {
 	void *handle;
 	void (*eppic_load)(char *), (*eppic_unload)(char *);
-	int (*eppic_init)();
+	int (*eppic_init)(struct call_back *);
 
 	/*
 	 * Dynamically load the eppic_makedumpfile.so library.
--

2.48.1

Signature · 2 lines
Best regards,
Coiby
Signature · 2 lines
Best regards,
Coiby