hid: intel-thc: fix CONFIG_HID dependency
Subsystems (10)
PATCH 1/1 hid: intel-thc: fix CONFIG_HID dependency
From: Arnd Bergmann <[email protected]>
In drivers/hid/, most drivers depend on CONFIG_HID, while a couple of the drivers in subdirectories instead depend on CONFIG_HID_SUPPORT and use 'select HID'. With the newly added INTEL_THC_HID, this causes a build warning for a circular dependency:
WARNING: unmet direct dependencies detected for HID
Depends on [m]: HID_SUPPORT [=y] && INPUT [=m]
Selected by [y]:
- INTEL_THC_HID [=y] && HID_SUPPORT [=y] && X86_64 [=y] && PCI [=y] && ACPI [=y]
WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
- HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y]
- GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y]
- HID_WIIMOTE [=y] && HID_SUPPORT [=y] && HID [=y] && LEDS_CLASS [=y]
- ZEROPLUS_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ZEROPLUS [=y] Selected by [m]:
- HID_ACRUX_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ACRUX [=m]
- HID_EMS_FF [=m] && HID_SUPPORT [=y] && HID [=y]
- HID_GOOGLE_STADIA_FF [=m] && HID_SUPPORT [=y] && HID [=y]
- PANTHERLORD_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_PANTHERLORD [=m]
It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem.
Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process.
--- drivers/hid/Kconfig | 10 ++++++---- drivers/hid/amd-sfh-hid/Kconfig | 1 - drivers/hid/i2c-hid/Kconfig | 2 +- drivers/hid/intel-ish-hid/Kconfig | 1 - drivers/hid/intel-thc-hid/Kconfig | 1 - drivers/hid/surface-hid/Kconfig | 2 -- drivers/hid/usbhid/Kconfig | 3 +-- net/bluetooth/hidp/Kconfig | 3 +-- 8 files changed, 9 insertions(+), 14 deletions(-)
drivers/hid/Kconfig +6 -4
@@ -1376,10 +1376,6 @@ endmenu source "drivers/hid/bpf/Kconfig" -endif # HID - -source "drivers/hid/usbhid/Kconfig" - source "drivers/hid/i2c-hid/Kconfig" source "drivers/hid/intel-ish-hid/Kconfig"
@@ -1390,4 +1386,10 @@ source "drivers/hid/surface-hid/Kconfig" source "drivers/hid/intel-thc-hid/Kconfig" +endif # HID + +# USB support may be used with HID disabled + +source "drivers/hid/usbhid/Kconfig" + endif # HID_SUPPORT
drivers/hid/amd-sfh-hid/Kconfig +0 -1
@@ -5,7 +5,6 @@ menu "AMD SFH HID Support" config AMD_SFH_HID tristate "AMD Sensor Fusion Hub" - depends on HID depends on X86 help If you say yes to this option, support will be included for the
drivers/hid/i2c-hid/Kconfig +1 -1
@@ -2,7 +2,7 @@ menuconfig I2C_HID tristate "I2C HID support" default y - depends on I2C && INPUT && HID + depends on I2C if I2C_HID
drivers/hid/intel-ish-hid/Kconfig +0 -1
@@ -6,7 +6,6 @@ config INTEL_ISH_HID tristate "Intel Integrated Sensor Hub" default n depends on X86 - depends on HID help The Integrated Sensor Hub (ISH) enables the ability to offload sensor polling and algorithm processing to a dedicated low power
drivers/hid/intel-thc-hid/Kconfig +0 -1
@@ -7,7 +7,6 @@ menu "Intel THC HID Support" config INTEL_THC_HID tristate "Intel Touch Host Controller" depends on ACPI - select HID help THC (Touch Host Controller) is the name of the IP block in PCH that interfaces with Touch Devices (ex: touchscreen, touchpad etc.). It
drivers/hid/surface-hid/Kconfig +0 -2
@@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0+ menu "Surface System Aggregator Module HID support" depends on SURFACE_AGGREGATOR - depends on INPUT config SURFACE_HID tristate "HID transport driver for Surface System Aggregator Module"
@@ -39,4 +38,3 @@ endmenu config SURFACE_HID_CORE tristate - select HID
drivers/hid/usbhid/Kconfig +1 -2
@@ -5,8 +5,7 @@ menu "USB HID support" config USB_HID tristate "USB HID transport layer" default y - depends on USB && INPUT - select HID + depends on HID help Say Y here if you want to connect USB keyboards, mice, joysticks, graphic tablets, or any other HID based devices
net/bluetooth/hidp/Kconfig +1 -2
@@ -1,8 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config BT_HIDP tristate "HIDP protocol support" - depends on BT_BREDR && INPUT && HID_SUPPORT - select HID + depends on BT_BREDR && HID help HIDP (Human Interface Device Protocol) is a transport layer for HID reports. HIDP is required for the Bluetooth Human
Signature · 1 line
2.39.5
Quoted 143 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
In
drivers/hid/, most drivers depend onCONFIG_HID, while a couple of the drivers in subdirectories instead depend onCONFIG_HID_SUPPORTand use 'select HID'. With the newly addedINTEL_THC_HID, this causes a build warning for a circular dependency:WARNING: unmet direct dependencies detected for HID
Depends on [m]:HID_SUPPORT[=y] && INPUT [=m]
Selected by [y]:
-INTEL_THC_HID[=y] &&HID_SUPPORT[=y] &&X86_64[=y] && PCI [=y] && ACPI [=y]WARNING: unmet direct dependencies detected for
INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
-HID_MICROSOFT[=y] &&HID_SUPPORT[=y] && HID [=y]
-GREENASIA_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_GREENASIA[=y]
-HID_WIIMOTE[=y] &&HID_SUPPORT[=y] && HID [=y] &&LEDS_CLASS[=y]
-ZEROPLUS_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ZEROPLUS[=y] Selected by [m]:
-HID_ACRUX_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ACRUX[=m]
-HID_EMS_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-HID_GOOGLE_STADIA_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-PANTHERLORD_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_PANTHERLORD[=m]It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem.
Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process.
Fixes 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/hid/Kconfig | 10 ++++++---- drivers/hid/amd-sfh-hid/Kconfig | 1 - drivers/hid/i2c-hid/Kconfig | 2 +- drivers/hid/intel-ish-hid/Kconfig | 1 - drivers/hid/intel-thc-hid/Kconfig | 1 - drivers/hid/surface-hid/Kconfig | 2 -- drivers/hid/usbhid/Kconfig | 3 +-- net/bluetooth/hidp/Kconfig | 3 +-- 8 files changed, 9 insertions(+), 14 deletions(-)drivers/hid/Kconfig +6
-4@@ -1376,10 +1376,6 @@ endmenu source "drivers/hid/bpf/Kconfig" -endif # HID - -source "drivers/hid/usbhid/Kconfig" - source "drivers/hid/i2c-hid/Kconfig" source "drivers/hid/intel-ish-hid/Kconfig"@@ -1390,4 +1386,10 @@ source "drivers/hid/surface-hid/Kconfig" source "drivers/hid/intel-thc-hid/Kconfig" +endif # HID + +# USB support may be used with HID disabled + +source "drivers/hid/usbhid/Kconfig" + endif # HID_SUPPORTdrivers/hid/amd-sfh-hid/Kconfig +0
-1@@ -5,7 +5,6 @@ menu "AMD SFH HID Support" config AMD_SFH_HID tristate "AMD Sensor Fusion Hub" - depends on HID depends on X86 help If you say yes to this option, support will be included for thedrivers/hid/i2c-hid/Kconfig +1
-1@@ -2,7 +2,7 @@ menuconfig I2C_HID tristate "I2C HID support" default y - depends on I2C && INPUT && HID + depends on I2C if I2C_HIDdrivers/hid/intel-ish-hid/Kconfig +0
-1@@ -6,7 +6,6 @@ config INTEL_ISH_HID tristate "Intel Integrated Sensor Hub" default n depends on X86 - depends on HID help The Integrated Sensor Hub (ISH) enables the ability to offload sensor polling and algorithm processing to a dedicated low powerdrivers/hid/intel-thc-hid/Kconfig +0
-1@@ -7,7 +7,6 @@ menu "Intel THC HID Support" config INTEL_THC_HID tristate "Intel Touch Host Controller" depends on ACPI - select HID help THC (Touch Host Controller) is the name of the IP block in PCH that interfaces with Touch Devices (ex: touchscreen, touchpad etc.). Itdrivers/hid/surface-hid/Kconfig +0
-2@@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0+ menu "Surface System Aggregator Module HID support" depends on SURFACE_AGGREGATOR - depends on INPUT config SURFACE_HID tristate "HID transport driver for Surface System Aggregator Module"@@ -39,4 +38,3 @@ endmenu config SURFACE_HID_CORE tristate - select HIDdrivers/hid/usbhid/Kconfig +0
-0
drivers/hid/usbhid/Kconfig menu "USB HID support" · line 8
Quoted 6 lines
drivers/hid/usbhid/Kconfig +1
-2@@ -5,8 +5,7 @@ menu "USB HID support" config USB_HID tristate "USB HID transport layer" default y - depends on USB && INPUT - select HID + depends on HID
I didn't exactly like the unrelated removal of USB totally without a prior warning. I suggest you at minimum mention in the commit message that menu covers it.
Signature · 1 line
i.
Quoted 18 lines
drivers/hid/usbhid/Kconfig +0
-0help Say Y here if you want to connect USB keyboards, mice, joysticks, graphic tablets, or any other HID based devicesnet/bluetooth/hidp/Kconfig +1
-2@@ -1,8 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config BT_HIDP tristate "HIDP protocol support" - depends on BT_BREDR && INPUT && HID_SUPPORT - select HID + depends on BT_BREDR && HID help HIDP (Human Interface Device Protocol) is a transport layer for HID reports. HIDP is required for the Bluetooth Human
Quoted 29 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
In
drivers/hid/, most drivers depend onCONFIG_HID, while a couple of the drivers in subdirectories instead depend onCONFIG_HID_SUPPORTand use 'select HID'. With the newly addedINTEL_THC_HID, this causes a build warning for a circular dependency:WARNING: unmet direct dependencies detected for HID
Depends on [m]:HID_SUPPORT[=y] && INPUT [=m]
Selected by [y]:
-INTEL_THC_HID[=y] &&HID_SUPPORT[=y] &&X86_64[=y] && PCI [=y] && ACPI [=y]WARNING: unmet direct dependencies detected for
INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
-HID_MICROSOFT[=y] &&HID_SUPPORT[=y] && HID [=y]
-GREENASIA_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_GREENASIA[=y]
-HID_WIIMOTE[=y] &&HID_SUPPORT[=y] && HID [=y] &&LEDS_CLASS[=y]
-ZEROPLUS_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ZEROPLUS[=y] Selected by [m]:
-HID_ACRUX_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ACRUX[=m]
-HID_EMS_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-HID_GOOGLE_STADIA_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-PANTHERLORD_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_PANTHERLORD[=m]It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem.
Quoted 7 lines
Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process.
Fixes 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")Signed-off-by Arnd Bergmann <[email protected]>---
For hid/surface-hid:
Quoted 187 lines
-----Original Message-----
From: Arnd Bergmann <[email protected]>
Sent: Thursday, January 23, 2025 9:48 PM
To: Jiri Kosina <[email protected]>; Benjamin Tissoires <[email protected]>; Srinivas Pandruvada <[email protected]>; Mark Pearson <[email protected]>
Cc: Arnd Bergmann <[email protected]>; Basavaraj Natikar <[email protected]>; Xu, Even <[email protected]>; Sun, Xinpeng <[email protected]>; Maximilian Luz <[email protected]>; Marcel Holtmann <[email protected]>; Johan Hedberg <[email protected]>; Luiz Augusto von Dentz <[email protected]>; Dmitry Torokhov <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]
Subject: [PATCH] hid: intel-thc: fixCONFIG_HIDdependencyFrom: Arnd Bergmann <[email protected]>
In
drivers/hid/, most drivers depend onCONFIG_HID, while a couple of the drivers in subdirectories instead depend onCONFIG_HID_SUPPORTand use 'select HID'. With the newly addedINTEL_THC_HID, this causes a build warning for a circular dependency:WARNING: unmet direct dependencies detected for HID
Depends on [m]:HID_SUPPORT[=y] && INPUT [=m]
Selected by [y]:
-INTEL_THC_HID[=y] &&HID_SUPPORT[=y] &&X86_64[=y] && PCI [=y] &&
ACPI [=y]WARNING: unmet direct dependencies detected for
INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
-HID_MICROSOFT[=y] &&HID_SUPPORT[=y] && HID [=y]
-GREENASIA_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_GREENASIA
[=y]
-HID_WIIMOTE[=y] &&HID_SUPPORT[=y] && HID [=y] &&LEDS_CLASS[=y]
-ZEROPLUS_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ZEROPLUS
[=y]
Selected by [m]:
-HID_ACRUX_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ACRUX[=m]
-HID_EMS_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-HID_GOOGLE_STADIA_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-PANTHERLORD_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_PANTHERLORD[=m]It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem.
Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process.
Fixes 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/hid/Kconfig | 10 ++++++---- drivers/hid/amd-sfh-hid/Kconfig | 1 - drivers/hid/i2c-hid/Kconfig | 2 +- drivers/hid/intel-ish-hid/Kconfig | 1 - drivers/hid/intel-thc-hid/Kconfig | 1 - drivers/hid/surface-hid/Kconfig | 2 -- drivers/hid/usbhid/Kconfig | 3 +-- net/bluetooth/hidp/Kconfig | 3 +-- 8 files changed, 9 insertions(+), 14 deletions(-)drivers/hid/Kconfig index renamed from drivers/hid/Kconfig +0
-0
8adb745c5b28..ed657ef7281c100644drivers/hid/Kconfig +6
-4@@ -1376,10 +1376,6 @@ endmenu source "drivers/hid/bpf/Kconfig" -endif # HID - -source "drivers/hid/usbhid/Kconfig" - source "drivers/hid/i2c-hid/Kconfig" source "drivers/hid/intel-ish-hid/Kconfig"@@ -1390,4 +1386,10 @@ source "drivers/hid/surface-hid/Kconfig" source "drivers/hid/intel-thc-hid/Kconfig" +endif # HID + +# USB support may be used with HID disabled + +source "drivers/hid/usbhid/Kconfig" + endif # HID_SUPPORTdrivers/hid/amd-sfh-hid/Kconfig +0
-1@@ -5,7 +5,6 @@ menu "AMD SFH HID Support" config AMD_SFH_HID tristate "AMD Sensor Fusion Hub" - depends on HID depends on X86 help If you say yes to this option, support will be included for the diff --gita/drivers/hid/i2c-hid/Kconfig b/drivers/hid/i2c-hid/Kconfig index
ef7c595c9403..e8d51f410cc1100644drivers/hid/i2c-hid/Kconfig +1
-1@@ -2,7 +2,7 @@ menuconfig I2C_HID tristate "I2C HID support" default y - depends on I2C && INPUT && HID + depends on I2C if I2C_HIDdrivers/hid/intel-ish-hid/Kconfig +0
-1@@ -6,7 +6,6 @@ config INTEL_ISH_HID tristate "Intel Integrated Sensor Hub" default n depends on X86 - depends on HID help The Integrated Sensor Hub (ISH) enables the ability to offload sensor polling and algorithm processing to a dedicated low power diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig index
91ec84902db8..0351d1137607100644drivers/hid/intel-thc-hid/Kconfig +0
-1@@ -7,7 +7,6 @@ menu "Intel THC HID Support" config INTEL_THC_HID tristate "Intel Touch Host Controller" depends on ACPI - select HID help THC (Touch Host Controller) is the name of the IP block in PCH that interfaces with Touch Devices (ex: touchscreen, touchpad etc.). It diff --git a/drivers/hid/surface-hid/Kconfig b/drivers/hid/surface-hid/Kconfig index
7ce9b5d641eb..d0cfd0d29926100644drivers/hid/surface-hid/Kconfig +0
-2@@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0+ menu "Surface System Aggregator Module HID support" depends on SURFACE_AGGREGATOR - depends on INPUT config SURFACE_HID tristate "HID transport driver for Surface System Aggregator Module"@@ -39,4 +38,3 @@ endmenu config SURFACE_HID_CORE tristate - select HIDdrivers/hid/usbhid/Kconfig index renamed from drivers/hid/usbhid/Kconfig +0
-0
7c2032f7f44d..f3194767a45e100644drivers/hid/usbhid/Kconfig +1
-2@@ -5,8 +5,7 @@ menu "USB HID support" config USB_HID tristate "USB HID transport layer" default y - depends on USB && INPUT - select HID + depends on HID help Say Y here if you want to connect USB keyboards, mice, joysticks, graphic tablets, or any other HID based devices diff --gita/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig index
6746be07e222..e08aae35351a100644net/bluetooth/hidp/Kconfig +1
-3@@ -1,8 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config BT_HIDP tristate "HIDP protocol support" - depends on BT_BREDR && INPUT && HID_SUPPORT - select HID + depends on BT_BREDR && HID help HIDP (Human Interface Device Protocol) is a transport layer for HID reports. HIDP is required for the Bluetooth Human --
Quoted 1 line
2.39.5
For hid/intel-thc-hid:
Best Regards,
Even Xu
Quoted 29 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
In
drivers/hid/, most drivers depend onCONFIG_HID, while a couple of the drivers in subdirectories instead depend onCONFIG_HID_SUPPORTand use 'select HID'. With the newly addedINTEL_THC_HID, this causes a build warning for a circular dependency:WARNING: unmet direct dependencies detected for HID
Depends on [m]:HID_SUPPORT[=y] && INPUT [=m]
Selected by [y]:
-INTEL_THC_HID[=y] &&HID_SUPPORT[=y] &&X86_64[=y] && PCI [=y] && ACPI [=y]WARNING: unmet direct dependencies detected for
INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
-HID_MICROSOFT[=y] &&HID_SUPPORT[=y] && HID [=y]
-GREENASIA_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_GREENASIA[=y]
-HID_WIIMOTE[=y] &&HID_SUPPORT[=y] && HID [=y] &&LEDS_CLASS[=y]
-ZEROPLUS_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ZEROPLUS[=y] Selected by [m]:
-HID_ACRUX_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_ACRUX[=m]
-HID_EMS_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-HID_GOOGLE_STADIA_FF[=m] &&HID_SUPPORT[=y] && HID [=y]
-PANTHERLORD_FF[=y] &&HID_SUPPORT[=y] && HID [=y] &&HID_PANTHERLORD[=m]It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem.
Quoted 6 lines
Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process.
Fixes 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")Signed-off-by Arnd Bergmann <[email protected]>
Applied to hid.git#for-6.14/upstream-fixes, thanks!
Signature · 2 lines
Jiri Kosina SUSE Labs
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=927825
---Test result---
Test Summary:
CheckPatch PENDING 0.38 seconds GitLint PENDING 0.22 seconds SubjectPrefix FAIL 0.36 seconds BuildKernel PASS 23.92 seconds CheckAllWarning PASS 26.68 seconds CheckSparse PASS 30.26 seconds BuildKernel32 PASS 23.83 seconds TestRunnerSetup PASS 428.49 seconds TestRunner_l2cap-tester FAIL 0.09 seconds TestRunner_iso-tester FAIL 0.09 seconds TestRunner_bnep-tester FAIL 0.14 seconds TestRunner_mgmt-tester FAIL 0.18 seconds TestRunner_rfcomm-tester FAIL 0.16 seconds TestRunner_sco-tester FAIL 0.09 seconds TestRunner_ioctl-tester FAIL 0.08 seconds TestRunner_mesh-tester FAIL 0.09 seconds TestRunner_smp-tester FAIL 0.09 seconds TestRunner_userchan-tester FAIL 0.08 seconds IncrementalBuild PENDING 0.48 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_bnep-tester - FAIL
Desc: Run bnep-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_rfcomm-tester - FAIL
Desc: Run rfcomm-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_ioctl-tester - FAIL
Desc: Run ioctl-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_smp-tester - FAIL
Desc: Run smp-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_userchan-tester - FAIL
Desc: Run userchan-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz
maintainerHi Arkadiusz,
Quoted 134 lines · On Thu, Feb 13, 2025 at 5:27 PM <[email protected]> wrote:
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=927825---Test result---
Test Summary:
CheckPatch PENDING 0.38 seconds GitLint PENDING 0.22 seconds SubjectPrefix FAIL 0.36 seconds BuildKernel PASS 23.92 seconds CheckAllWarning PASS 26.68 seconds CheckSparse PASS 30.26 seconds BuildKernel32 PASS 23.83 seconds TestRunnerSetup PASS 428.49 seconds TestRunner_l2cap-tester FAIL 0.09 seconds TestRunner_iso-tester FAIL 0.09 seconds TestRunner_bnep-tester FAIL 0.14 seconds TestRunner_mgmt-tester FAIL 0.18 seconds TestRunner_rfcomm-tester FAIL 0.16 seconds TestRunner_sco-tester FAIL 0.09 seconds TestRunner_ioctl-tester FAIL 0.08 seconds TestRunner_mesh-tester FAIL 0.09 seconds TestRunner_smp-tester FAIL 0.09 seconds TestRunner_userchan-tester FAIL 0.08 seconds IncrementalBuild PENDING 0.48 secondsDetails
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_bnep-tester - FAIL
Desc: Run bnep-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_rfcomm-tester - FAIL
Desc: Run rfcomm-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_ioctl-tester - FAIL
Desc: Run ioctl-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_smp-tester - FAIL
Desc: Run smp-tester with test-runner
Output:Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
##############################
Test: TestRunner_userchan-tester - FAIL
Desc: Run userchan-tester with test-runner
Output:
Quoted 4 lines
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu-system-x86_64: CPU model 'host' requires KVM
I guess these errors are related to the last change aren't they? Most likely github hosts don't have KVM enabled or something like that.
Quoted 11 lines
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:---
Regards,
Linux Bluetooth
Signature · 1 line
Luiz Augusto von Dentz
Quoted 2 lines
I guess these errors are related to the last change aren't they? Most likely github hosts don't have KVM enabled or something like that.
Yes... It's because of "-cpu host". So, this change must be reverted if CI does not have KVM support. I was not aware of that, sorry.
Regards,
Arek
Another idea is to add an option to the tools/test-runner which will allow to enable "-cpu host" on demand, so for cases like mine (where binaries built on host are not compatible with QEMU setup) it will be an easy workaround. Unfortunately, I won't be able to submit such a patch until Monday.
Regards,
Arek
I've just submitted a "test-runner: Allow to use host CPU on demand" patch which should fix that. Unfortunately, I'm not able to test it right now, but I think that it will work.
I've tested it like that (on my RPi) and it seems to be OK:
$ tools/test-runner -k bzImage -H -q /usr/bin/echo -a Using QEMU binary /usr/bin/echo Using kernel image bzImage -nodefaults -no-user-config -monitor none -display none -machine type=q35,accel=kvm:tcg -m 256M -net none -no-reboot -fsdev local,id=fsdev-root,path=/,readonly=on,security_model=none,multidevs=remap -device virtio-9p-pci,fsdev=fsdev-root,mount_tag=/dev/root -chardev stdio,id=con,mux=on -serial chardev:con -cpu host -kernel bzImage -append console=ttyS0,115200n8 earlyprintk=serial no_hash_pointers=1 rootfstype=9p rootflags=trans=virtio,version=9p2000.u acpi=off pci=noacpi noapic quiet ro init=/home/pi/bluez/build/./tools/test-runner TESTHOME=/home/pi/bluez/build TESTDBUS=0 TESTDAEMON=0 TESTDBUSSESSION=0 XDG_RUNTIME_DIR=/run/user/0 TESTMONITOR=0 TESTEMULATOR=0 TESTDEVS=0 TESTAUTO=1 TESTAUDIO='' TESTARGS='(null)'
I've just noticed a "TESTARGS='(null)'"... However, maybe that's intended. Anyway passing NULL to snprintf is a risky business.
Regards,
Arek
This patch was applied to bluetooth/bluetooth-next.git (master) by Jiri Kosina <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Jiri Kosina <[email protected]>:
Quoted 8 lines · On Thu, 23 Jan 2025 14:48:12 +0100 you wrote:
From: Arnd Bergmann <[email protected]>
In
drivers/hid/, most drivers depend onCONFIG_HID, while a couple of the drivers in subdirectories instead depend onCONFIG_HID_SUPPORTand use 'select HID'. With the newly addedINTEL_THC_HID, this causes a build warning for a circular dependency:[...]
Here is the summary with links:
- hid: intel-thc: fix CONFIG_HID dependency
https://git.kernel.org/bluetooth/bluetooth-next/c/a5a056c8d2ba
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html