oradax: fix typo in dax_dbg message
Subsystems (2)
PATCH 1/1 oradax: fix typo in dax_dbg message
There is a typo in a printk message: copyin -> copying.
Fix it via codespell.
--- drivers/sbus/char/oradax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sbus/char/oradax.c +1 -1
@@ -874,7 +874,7 @@ static int dax_ccb_exec(struct dax_ctx *ctx, const char __user *buf,* user in between validation and submission. */ if (copy_from_user (ctx->ccb_buf, buf, count)) { -dax_dbg ("copyin of user CCB buffer failed" ); +dax_dbg ("copying of user CCB buffer failed" ); ctx->result.exec.status =DAX_SUBMIT_ERR_CCB_ARR_MMU_MISS ;return 0 ; }
Signature · 1 line
2.47.2
That is not a typo. "Copyin" is correct as it refers to copying data in from user space.
Rob
Quoted 22 lines · Andrew Kreimer
There is a typo in a printk message: copyin -> copying.
Fix it via codespell.
Signed-off-by Andrew Kreimer <[email protected]>--- drivers/sbus/char/oradax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/sbus/char/oradax.c +1
-1@@ -874,7 +874,7 @@ static int dax_ccb_exec(struct dax_ctx *ctx, const char __user *buf,* user in between validation and submission. */ if (copy_from_user (ctx->ccb_buf, buf, count)) { -dax_dbg ("copyin of user CCB buffer failed" ); +dax_dbg ("copying of user CCB buffer failed" ); ctx->result.exec.status =DAX_SUBMIT_ERR_CCB_ARR_MMU_MISS ;return 0 ; }
Quoted 2 lines · Rob Gardner
That is not a typo. "Copyin" is correct as it refers to copying data in from user space.
My bad!
Hi Rob,
Quoted 2 lines · Rob Gardner
That is not a typo. "Copyin" is correct as it refers to copying data in from user space.
If it's "copying in" data from user space, it should be spelled "copy in" and not "copyin" unless my English grammar skills are failing me.
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Quoted 8 lines · John Paul Adrian Glaubitz
Hi Rob,
Quoted 2 lines · Rob Gardner
That is not a typo. "Copyin" is correct as it refers to copying data in from user space.
If it's "copying in" data from user space, it should be spelled "copy in" and not "copyin" unless my English grammar skills are failing me.
The resulting phrase "copy in of user CCB buffer" would contain two consecutive prepositions, which is poor English grammar. ;)
There used to be a kernel function called copyin() that was changed to copy_from_user() in the dim past. But I think "copyin" is still widely understood as an /operation/, not an English word, kind of like "ccb".
Apologies to all for cluttering up multiple lists with this trivia.
Rob