target/mips: fix possible int overflow
PATCH 1/1 target/mips: fix possible int overflow
From: Denis Rastyogin <[email protected]>
Fix possible overflow in 1 << (DF_BITS(df) - 2) when DF_BITS(df) is 64 by using a 64-bit integer for the shift operation.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Reported-by Dmitriy Fedin <[email protected]>
Signed-off-by Denis Rastyogin <[email protected]>
--- target/mips/tcg/msa_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
target/mips/tcg/msa_helper.c +3 -3
@@ -5577,7 +5577,7 @@ static inline int64_t msa_mulr_q_df(uint32_t df, int64_t arg1, int64_t arg2) {int64_t q_min =DF_MIN_INT (df);int64_t q_max =DF_MAX_INT (df); -int64_t r_bit =1 << (DF_BITS (df) -2 ); +int64_t r_bit =1LL << (DF_BITS (df) -2 );if (arg1 == q_min && arg2 == q_min) {return q_max;
@@ -5685,7 +5685,7 @@ static inline int64_t msa_maddr_q_df(uint32_t df, int64_t dest, int64_t arg1,int64_t q_max =DF_MAX_INT (df);int64_t q_min =DF_MIN_INT (df); -int64_t r_bit =1 << (DF_BITS (df) -2 ); +int64_t r_bit =1LL << (DF_BITS (df) -2 ); q_prod = arg1 * arg2; q_ret = ((dest << (DF_BITS (df) -1 )) + q_prod + r_bit) >> (DF_BITS (df) -1 );
@@ -5700,7 +5700,7 @@ static inline int64_t msa_msubr_q_df(uint32_t df, int64_t dest, int64_t arg1,int64_t q_max =DF_MAX_INT (df);int64_t q_min =DF_MIN_INT (df); -int64_t r_bit =1 << (DF_BITS (df) -2 ); +int64_t r_bit =1LL << (DF_BITS (df) -2 ); q_prod = arg1 * arg2; q_ret = ((dest << (DF_BITS (df) -1 )) - q_prod + r_bit) >> (DF_BITS (df) -1 );
Signature · 1 line
2.42.2
Quoted 10 lines · On Fri, 24 Jan 2025 at 12:27, <[email protected]> wrote:
From: Denis Rastyogin <[email protected]>
Fix possible overflow in 1 << (
DF_BITS(df)- 2) whenDF_BITS(df)is 64 by using a 64-bit integer for the shift operation.Found by Linux Verification Center (linuxtesting.org) with SVACE.
Reported-by Dmitriy Fedin <[email protected]>Signed-off-by Denis Rastyogin <[email protected]>
Reviewed-by Peter Maydell <[email protected]>
thanks
-- PMM