ASoC: mediatek: mt6358: Remove unused functions
Subsystems (3)
PATCH 1/1 ASoC: mediatek: mt6358: Remove unused functions
From: "Dr. David Alan Gilbert" <[email protected]>
The functions:
mt6358_mtkaif_calibration_disable() mt6358_mtkaif_calibration_enable() mt6358_set_mtkaif_calibration_phase()
were added in the 2019
commit 6a8d4198ca80 ("ASoC: mediatek: mt6358: add codec driver")
but never used.
Remove them.
This leaves mt6358_set_dcxo(), mt6358_set_clksq(), mt6358_set_aud_global_bias(), also unused.
Remove them.
--- sound/soc/codecs/mt6358.c | 104 -------------------------------------- sound/soc/codecs/mt6358.h | 4 -- 2 files changed, 108 deletions(-)
sound/soc/codecs/mt6358.c +0 -104
@@ -162,47 +162,6 @@ static void capture_gpio_reset(struct mt6358_priv *priv) 0xf << 12, 0x0); } -/* use only when not govern by DAPM */ -static int mt6358_set_dcxo (struct mt6358_priv *priv,bool enable) -{ -regmap_update_bits (priv->regmap,MT6358_DCXO_CW14 , -0x1 <<RG_XO_AUDIO_EN_M_SFT , - (enable ?1 :0 ) <<RG_XO_AUDIO_EN_M_SFT ); -return 0 ; -} - -/* use only when not govern by DAPM */ -static int mt6358_set_clksq (struct mt6358_priv *priv,bool enable) -{ -/* audio clk source from internal dcxo */ -regmap_update_bits (priv->regmap,MT6358_AUDENC_ANA_CON6 , -RG_CLKSQ_IN_SEL_TEST_MASK_SFT , -0x0 ); - -/* Enable/disable CLKSQ 26MHz */ -regmap_update_bits (priv->regmap,MT6358_AUDENC_ANA_CON6 , -RG_CLKSQ_EN_MASK_SFT , - (enable ?1 :0 ) <<RG_CLKSQ_EN_SFT ); -return 0 ; -} - -/* use only when not govern by DAPM */ -static int mt6358_set_aud_global_bias (struct mt6358_priv *priv,bool enable) -{ -regmap_update_bits (priv->regmap,MT6358_AUDDEC_ANA_CON13 , -RG_AUDGLB_PWRDN_VA28_MASK_SFT , - (enable ?0 :1 ) <<RG_AUDGLB_PWRDN_VA28_SFT ); -return 0 ; -} - -/* use only when not govern by DAPM */ -static int mt6358_set_topck (struct mt6358_priv *priv,bool enable) -{ -regmap_update_bits (priv->regmap,MT6358_AUD_TOP_CKPDN_CON0 , -0x0066 , enable ?0x0 :0x66 ); -return 0 ; -} -static int mt6358_mtkaif_tx_enable (struct mt6358_priv *priv) {switch (priv->mtkaif_protocol) {
@@ -252,69 +211,6 @@ static int mt6358_mtkaif_tx_disable(struct mt6358_priv *priv)return 0 ; } -int mt6358_mtkaif_calibration_enable (struct snd_soc_component *cmpnt) -{ -struct mt6358_priv *priv =snd_soc_component_get_drvdata (cmpnt); - -playback_gpio_set (priv); -capture_gpio_set (priv); -mt6358_mtkaif_tx_enable (priv); - -mt6358_set_dcxo (priv, true); -mt6358_set_aud_global_bias (priv, true); -mt6358_set_clksq (priv, true); -mt6358_set_topck (priv, true); - -/* set dat_miso_loopback on */ -regmap_update_bits (priv->regmap,MT6358_AUDIO_DIG_CFG , -RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_MASK_SFT , -1 <<RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_SFT ); -regmap_update_bits (priv->regmap,MT6358_AUDIO_DIG_CFG , -RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_MASK_SFT , -1 <<RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT ); -return 0 ; -} -EXPORT_SYMBOL_GPL (mt6358_mtkaif_calibration_enable); - -int mt6358_mtkaif_calibration_disable (struct snd_soc_component *cmpnt) -{ -struct mt6358_priv *priv =snd_soc_component_get_drvdata (cmpnt); - -/* set dat_miso_loopback off */ -regmap_update_bits (priv->regmap,MT6358_AUDIO_DIG_CFG , -RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_MASK_SFT , -0 <<RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_SFT ); -regmap_update_bits (priv->regmap,MT6358_AUDIO_DIG_CFG , -RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_MASK_SFT , -0 <<RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT ); - -mt6358_set_topck (priv, false); -mt6358_set_clksq (priv, false); -mt6358_set_aud_global_bias (priv, false); -mt6358_set_dcxo (priv, false); - -mt6358_mtkaif_tx_disable (priv); -playback_gpio_reset (priv); -capture_gpio_reset (priv); -return 0 ; -} -EXPORT_SYMBOL_GPL (mt6358_mtkaif_calibration_disable); - -int mt6358_set_mtkaif_calibration_phase (struct snd_soc_component *cmpnt, -int phase_1,int phase_2) -{ -struct mt6358_priv *priv =snd_soc_component_get_drvdata (cmpnt); - -regmap_update_bits (priv->regmap,MT6358_AUDIO_DIG_CFG , -RG_AUD_PAD_TOP_PHASE_MODE_MASK_SFT , - phase_1 <<RG_AUD_PAD_TOP_PHASE_MODE_SFT ); -regmap_update_bits (priv->regmap,MT6358_AUDIO_DIG_CFG , -RG_AUD_PAD_TOP_PHASE_MODE2_MASK_SFT , - phase_2 <<RG_AUD_PAD_TOP_PHASE_MODE2_SFT ); -return 0 ; -} -EXPORT_SYMBOL_GPL (mt6358_set_mtkaif_calibration_phase); -/* dl pga gain */ enum {DL_GAIN_8DB =0 ,
sound/soc/codecs/mt6358.h +0 -4
@@ -2307,8 +2307,4 @@ enum {/* set only during init */ int mt6358_set_mtkaif_protocol (struct snd_soc_component *cmpnt,int mtkaif_protocol); -int mt6358_mtkaif_calibration_enable (struct snd_soc_component *cmpnt); -int mt6358_mtkaif_calibration_disable (struct snd_soc_component *cmpnt); -int mt6358_set_mtkaif_calibration_phase (struct snd_soc_component *cmpnt, -int phase_1,int phase_2);#endif /* __MT6358_H__ */
Signature · 1 line
2.48.1
Mark Brown
maintainerQuoted 8 lines · On Tue, 28 Jan 2025 00:52:43 +0000, [email protected] wrote:
The functions:
mt6358_mtkaif_calibration_disable()mt6358_mtkaif_calibration_enable()mt6358_set_mtkaif_calibration_phase()
were added in the 2019
commit6a8d4198ca80("ASoC: mediatek: mt6358: add codec driver")[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: mediatek: mt6358: Remove unused functions
commit: fb6ec1d27608c008bfe1ab0dfec3720990eb2451
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark