xfs/541: _notrun if the file system can't mount
PATCH 1/1 xfs/541: _notrun if the file system can't mount
A file system created without an RT section might not be able to mount with an rtdev specified if the RT device has a larger LBA size.
Instead of letting the test fail, _notrun it for that case.
--- tests/xfs/541 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/541 +1 -1
@@ -26,7 +26,7 @@ _require_scratch # Format scratch fs with no realtime section. SCRATCH_RTDEV="" _scratch_mkfs | _filter_mkfs 2> $tmp.mkfs >> $seqres.full -_scratch_mount +_try_scratch_mount || _notrun "Can't mount file system" # Zoned file systems don't support rtextsize > 1 _require_xfs_scratch_non_zoned
Signature · 1 line
2.45.2
Quoted 2 lines · Christoph Hellwig
A file system created without an RT section might not be able to mount with an rtdev specified if the RT device has a larger LBA size.
Where does the mount failure occur? The initial mount (where we specify -o rtdev but sb_rblocks is still zero) should succeed because xfs_rtmount_init ignores m_rtdev_targp if !rblocks, right? So it's only when you get to growfs and we try to read the device that things fail?
--D
Quoted 24 lines
Instead of letting the test fail,
_notrunit for that case.Signed-off-by Christoph Hellwig <[email protected]>--- tests/xfs/541 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/xfs/541 +1
-1@@ -26,7 +26,7 @@ _require_scratch # Format scratch fs with no realtime section. SCRATCH_RTDEV="" _scratch_mkfs | _filter_mkfs 2> $tmp.mkfs >> $seqres.full -_scratch_mount +_try_scratch_mount || _notrun "Can't mount file system" # Zoned file systems don't support rtextsize > 1 _require_xfs_scratch_non_zonedSignature · 1 line
2.45.2
Quoted 8 lines · Darrick J. Wong
Quoted 2 lines · Christoph Hellwig
A file system created without an RT section might not be able to mount with an rtdev specified if the RT device has a larger LBA size.
Where does the mount failure occur? The initial mount (where we specify -o rtdev but
sb_rblocksis still zero) should succeed becausexfs_rtmount_initignoresm_rtdev_targpif !rblocks, right? So it's only when you get to growfs and we try to read the device that things fail?
There only is a single mount in the test.
The test only clears the rtdev for the mkfs call, not the mount call. As XFS doesn't allow adding a new rtdev at runtime, just expanding the file system to the already passed but not actually used rt device in growfs that's actually needed, even if it sounds counterintuitive.
(that being said I sent the patch directly from my zoned branch, so it won't apply as-is due to context issues)
Darrick J. Wong
Reviewed-byQuoted 12 lines · Christoph Hellwig
Quoted 8 lines · Darrick J. Wong
Quoted 2 lines · Christoph Hellwig
A file system created without an RT section might not be able to mount with an rtdev specified if the RT device has a larger LBA size.
Where does the mount failure occur? The initial mount (where we specify -o rtdev but
sb_rblocksis still zero) should succeed becausexfs_rtmount_initignoresm_rtdev_targpif !rblocks, right? So it's only when you get to growfs and we try to read the device that things fail?There only is a single mount in the test.
Quoted 7 lines
The test only clears the rtdev for the mkfs call, not the mount call. As XFS doesn't allow adding a new rtdev at runtime, just expanding the file system to the already passed but not actually used rt device in growfs that's actually needed, even if it sounds counterintuitive.
(that being said I sent the patch directly from my zoned branch, so it won't apply as-is due to context issues)
Gross, it's the set_blocksize call in xfs_setsize_buftarg that trips everything up. But, it makes sense that one cannot mix sector sizes nor mount an rtdev with a larger sector size than what's configured on the data device.
--D