common: skip tests using LVM when the device is no known
PATCH 1/1 common: skip tests using LVM when the device is no known
LVM has a lot of elaborate code to make the users life painful. This includes claiming the device type is unknown if it doesn't match it's elaborately crafted internal list instead of just letting the user use it. Skip tests using LVM if this is the case to avoid arcane failures due to missing lvm devices when using null_blk.
--- tests/generic/081 | 6 +++++- tests/generic/108 | 6 +++++- tests/generic/459 | 6 +++++- 3 files changed, 15 insertions(+), 3 deletions(-)
tests/generic/081 +5 -1
@@ -66,7 +66,11 @@ lvsize=$((size * 85 / 100)) # ~256M # make sure there's enough disk space for 256M lv, test for 300M here in case # lvm uses some space for metadata _scratch_mkfs_sized $((size * 1024 * 1024)) >>$seqres.full 2>&1 -$LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 + +# lvm has a hardcoded list of valid devices and fails with +# "device type is unknown" for those not in the list like null_blk +$LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 || \ + _notrun "LVM is too stupid for this device" # We use yes pipe instead of 'lvcreate --yes' because old version of lvm # (like 2.02.95 in RHEL6) don't support --yes option yes | $LVM_PROG lvcreate -L ${lvsize}M -n $lvname $vgname >>$seqres.full 2>&1
tests/generic/108 +5 -1
@@ -51,7 +51,11 @@ test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device" echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full # create striped volume with 4MB stripe size -$LVM_PROG pvcreate -f $SCSI_DEBUG_DEV $SCRATCH_DEV >>$seqres.full 2>&1 +# +# lvm has a hardcoded list of valid devices and fails with +# "device type is unknown" for those not in the list like null_blk +$LVM_PROG pvcreate -f $SCSI_DEBUG_DEV $SCRATCH_DEV >>$seqres.full 2>&1 || \ + _notrun "LVM is too stupid for this device" $LVM_PROG vgcreate -f $vgname $SCSI_DEBUG_DEV $SCRATCH_DEV >>$seqres.full 2>&1 # We use yes pipe instead of 'lvcreate --yes' because old version of lvm # (like 2.02.95 in RHEL6) don't support --yes option
tests/generic/459 +5 -1
@@ -84,7 +84,11 @@ is_shutdown_or_ro() _scratch_mkfs_sized $((350 * 1024 * 1024)) >>$seqres.full 2>&1 # Create a 200MB dm-thin POOL -$LVM_PROG pvcreate -f $SCRATCH_DEV >>$seqres.full 2>&1 +# +# lvm has a hardcoded list of valid devices and fails with +# "device type is unknown" for those not in the list like null_blk +$LVM_PROG pvcreate -f $SCRATCH_DEV >>$seqres.full 2>&1 || \ + _notrun "LVM is too stupid for this device" $LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 $LVM_PROG lvcreate --thinpool $poolname --errorwhenfull y \
Signature · 1 line
2.45.2
Quoted 18 lines · Christoph Hellwig
LVM has a lot of elaborate code to make the users life painful. This includes claiming the device type is unknown if it doesn't match it's elaborately crafted internal list instead of just letting the user use it. Skip tests using LVM if this is the case to avoid arcane failures due to missing lvm devices when using
null_blk.Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/081 | 6 +++++- tests/generic/108 | 6 +++++- tests/generic/459 | 6 +++++- 3 files changed, 15 insertions(+), 3 deletions(-)tests/generic/081 +0
-0
tests/generic/081 lvsize=$((size * 85 / 100)) # ~256M · line 73
Quoted 9 lines
tests/generic/081 +5
-1@@ -66,7 +66,11 @@ lvsize=$((size * 85 / 100)) # ~256M # make sure there's enough disk space for 256M lv, test for 300M here in case # lvm uses some space for metadata _scratch_mkfs_sized $((size * 1024 * 1024)) >>$seqres.full 2>&1 -$LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 + +# lvm has a hardcoded list of valid devices and fails with +# "device type is unknown" for those not in the list like null_blk +$LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 || \ + _notrun "LVM is too stupid for this device"
Should this get turned into a common helper?
_require_lvm_support() {
local bdev="$1"
$LVM_PROG pvcreate --test "$bdev" || \
_notrun "$bdev: cannot use lvm here"
}I guess the downside is that pvcreate on my system (Debian 12) will trip over any existing disk label and ask if you want to wipe it. If you say no then it returns nonzero, and if you say yes then it goes into an infinite loop.
You can of course $WIPEFS_PROG -a $bdev but ugghh.
--D
Quoted 41 lines
tests/generic/081 +0
-0# We use yes pipe instead of 'lvcreate --yes' because old version of lvm # (like 2.02.95 in RHEL6) don't support --yes option yes | $LVM_PROG lvcreate -L ${lvsize}M -n $lvname $vgname >>$seqres.full 2>&1tests/generic/108 +5
-1@@ -51,7 +51,11 @@ test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device" echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full # create striped volume with 4MB stripe size -$LVM_PROG pvcreate -f $SCSI_DEBUG_DEV $SCRATCH_DEV >>$seqres.full 2>&1 +# +# lvm has a hardcoded list of valid devices and fails with +# "device type is unknown" for those not in the list like null_blk +$LVM_PROG pvcreate -f $SCSI_DEBUG_DEV $SCRATCH_DEV >>$seqres.full 2>&1 || \ + _notrun "LVM is too stupid for this device" $LVM_PROG vgcreate -f $vgname $SCSI_DEBUG_DEV $SCRATCH_DEV >>$seqres.full 2>&1 # We use yes pipe instead of 'lvcreate --yes' because old version of lvm # (like 2.02.95 in RHEL6) don't support --yes optiontests/generic/459 +5
-1@@ -84,7 +84,11 @@ is_shutdown_or_ro() _scratch_mkfs_sized $((350 * 1024 * 1024)) >>$seqres.full 2>&1 # Create a 200MB dm-thin POOL -$LVM_PROG pvcreate -f $SCRATCH_DEV >>$seqres.full 2>&1 +# +# lvm has a hardcoded list of valid devices and fails with +# "device type is unknown" for those not in the list like null_blk +$LVM_PROG pvcreate -f $SCRATCH_DEV >>$seqres.full 2>&1 || \ + _notrun "LVM is too stupid for this device" $LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 $LVM_PROG lvcreate --thinpool $poolname --errorwhenfull y \Signature · 1 line
2.45.2
Quoted 8 lines · Darrick J. Wong
Should this get turned into a common helper?
I guess the downside is that pvcreate on my system (Debian 12) will trip over any existing disk label and ask if you want to wipe it. If you say no then it returns nonzero, and if you say yes then it goes into an infinite loop.
You can of course $WIPEFS_PROG -a $bdev but ugghh.
Honestly, for now I just want to avoid the tests failing due to lvm stupidity. If someone has the time to do something more elaborate (I don't right now), the proper thing is to stop using lvm and replace it with something less stupid. That might be direct use of dm, or simulating failures with null_blk or scsi_debug.
Darrick J. Wong
Reviewed-byQuoted 8 lines · Christoph Hellwig
Quoted 7 lines · Darrick J. Wong
Should this get turned into a common helper?
I guess the downside is that pvcreate on my system (Debian 12) will trip over any existing disk label and ask if you want to wipe it. If you say no then it returns nonzero, and if you say yes then it goes into an infinite loop.
Quoted 7 lines
Quoted 1 line
You can of course $WIPEFS_PROG -a $bdev but ugghh.
Honestly, for now I just want to avoid the tests failing due to lvm stupidity. If someone has the time to do something more elaborate (I don't right now), the proper thing is to stop using lvm and replace it with something less stupid. That might be direct use of dm, or simulating failures with
null_blkorscsi_debug.
Eh, I'm not that into a weird wipefs and pvcreate --test. If someone feels so motivated to test that on a bunch of distros they can do that refactoring. I already have too many patches stuck in djwong-dev.
--D