generic/418: use min_dio_alignment
PATCH 1/1 generic/418: use min_dio_alignment
Otherwise this test uses the wrong sector size on the RT device.
--- tests/generic/418 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/418 +1 -1
@@ -28,7 +28,7 @@ _require_test_program "feature" diotest=$here/src/dio-invalidate-cache testfile=$TEST_DIR/$seq-diotest -sectorsize=`blockdev --getss $TEST_DEV` +sectorsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV` pagesize=`$here/src/feature -s` # test case array, test different write/read combinations
Signature · 1 line
2.45.2
Quoted 12 lines · Christoph Hellwig
Otherwise this test uses the wrong sector size on the RT device.
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/418 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/418 +0
-0
tests/generic/418 _require_test_program "feature" · line 31
Quoted 5 lines
tests/generic/418 +1
-1@@ -28,7 +28,7 @@ _require_test_program "feature" diotest=$here/src/dio-invalidate-cache testfile=$TEST_DIR/$seq-diotest -sectorsize=`blockdev --getss $TEST_DEV` +sectorsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV`
BTW is min_dio_alignment going to get an upgrade to report STATX_DIO_READ_ALIGN ?
The changes here look correct to me
--D
Quoted 7 lines
tests/generic/418 +0
-0pagesize=`$here/src/feature -s` # test case array, test different write/read combinationsSignature · 1 line
2.45.2
Quoted 7 lines · Darrick J. Wong
tests/generic/418 _require_test_program "feature" · line 31
Quoted 4 lines
diotest=$here/src/dio-invalidate-cache
testfile=$TEST_DIR/$seq-diotesttests/generic/418 +1
-1-sectorsize=`blockdev --getss $TEST_DEV` +sectorsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV`BTW is
min_dio_alignmentgoing to get an upgrade to reportSTATX_DIO_READ_ALIGN?
Sorta. For most tests we really expect a symmetic output that can be used for reads and writes. But for say fsx we can actually plug in different read and write sized, and I did prototype that a while ago.