dts: add sudo to linux link up
PATCH 1/1 dts: add sudo to linux link up
Fixes 41d133d6c62f ("dts: automatically bring up link on interfaces")
Signed-off-by Patrick Robb <[email protected]>
--- dts/framework/testbed_model/linux_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
dts/framework/testbed_model/linux_session.py +1 -1
@@ -169,7 +169,7 @@ def update_ports(self, ports: list[Port]) -> None: def bring_up_link(self, ports: list[Port]) -> None: """Overrides :meth:`~.os_session.OSSession.bring_up_link`.""" for port in ports: - self.send_command(f"ip link set dev {port.logical_name} up") + self.send_command(f"sudo ip link set dev {port.logical_name} up", verify=True) def _get_lshw_info(self) -> list[LshwOutput]: output = self.send_command("lshw -quiet -json -C network", verify=True)
Signature · 1 line
2.48.1
Hi Patrick,
thank you for the prompt fix!
Quoted 13 lines · Patrick Robb
Fixes 41d133d6c62f ("dts: automatically bring up link on interfaces")Signed-off-by Patrick Robb <[email protected]>--- dts/framework/testbed_model/linux_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)dts/framework/testbed_model/linux_session.py +0
-0
dts/framework/testbed_model/linux_session.py def update_ports(self, ports: list[Port]) -> None: · line 172
Quoted 5 lines
dts/framework/testbed_model/linux_session.py +1
-1@@ -169,7 +169,7 @@ def update_ports(self, ports: list[Port]) -> None: def bring_up_link(self, ports: list[Port]) -> None: """Overrides :meth:`~.os_session.OSSession.bring_up_link`.""" for port in ports: - self.send_command(f"ip link set dev {port.logical_name} up") + self.send_command(f"sudo ip link set dev {port.logical_name} up", verify=True)
sudo should be performed with privileged:
self.send_command(f"ip link set dev {port.logical_name} up",
privileged=True, verify=True)
Quoted 3 lines
dts/framework/testbed_model/linux_session.py +0
-0def _get_lshw_info(self) -> list[LshwOutput]: output = self.send_command("lshw -quiet -json -C network", verify=True)
PATCH 1/1 dts: add sudo to linux link up
In reply to Patrick RobbFixes 41d133d6c62f ("dts: automatically bring up link on interfaces")
Signed-off-by Patrick Robb <[email protected]>
--- dts/framework/testbed_model/linux_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
dts/framework/testbed_model/linux_session.py +1 -1
@@ -169,7 +169,7 @@ def update_ports(self, ports: list[Port]) -> None: def bring_up_link(self, ports: list[Port]) -> None: """Overrides :meth:`~.os_session.OSSession.bring_up_link`.""" for port in ports: - self.send_command(f"ip link set dev {port.logical_name} up") + self.send_command(f"ip link set dev {port.logical_name} up", privileged=True, verify=True) def _get_lshw_info(self) -> list[LshwOutput]: output = self.send_command("lshw -quiet -json -C network", verify=True)
Signature · 1 line
2.48.1
Reviewed-by Luca Vizzarro <[email protected]>