Skip to contentSkip to conversation

dev-manual/packages: add information about signing changes

PATCH Superseded Zoltán Böszörményi 2 participants 7 messages Jan 29, 2025 – Feb 12, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dev-manual/packages: add information about signing changes

---
 documentation/dev-manual/packages.rst | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
documentation/dev-manual/packages.rst +13 -3
index 4ba2dcae3..dba07a2c6 100644
@@ -819,9 +819,19 @@ to use signed package feeds (repositories) when doing a build.
 Signing RPM Packages
 --------------------
 
-To enable signing RPM packages, you must set up the following
-configurations in either your ``local.config`` or ``distro.config``
-file::
+To enable signing RPM packages, you must modify the RPM package
+configuration to include support for OpenPGP signing. That may
+be done either in a recipe addendum called ``rpm_%.bbappend``:
+
+   PACKAGECONFIG:append = " sequoia"
+
+or in either your ``local.config`` or ``distro.config`` file:
+
+   PACKAGECONFIG:append:pn-rpm-native = " sequoia"
+   PACKAGECONFIG:append:pn-rpm = " sequoia"
+
+You must also set up the following configurations in either your
+``local.config`` or ``distro.config`` file::
 
    # Inherit sign_rpm.bbclass to enable signing functionality
    INHERIT += " sign_rpm"
Signature · 1 line
2.48.1
#1 lore raw

PATCH 2/2 release-notes-5.2: add information about rpm and sequoia

---
 documentation/migration-guides/release-notes-5.2.rst | 4 ++++
 1 file changed, 4 insertions(+)
documentation/migration-guides/release-notes-5.2.rst +4 -0
index 06dce8d17..b0e538700 100644
@@ -226,6 +226,9 @@ New Features / Enhancements in |yocto-ver|
    -  ``package_rpm``: restrict RPM packaging to 4 threads to improve
       the compression speed.
 
+   -  ``sign_rpm``: ``rpm`` needs the ``sequoia`` :term:`PACKAGECONFIG`
+      config set to be able to generate signed packages.
+
 -  LLVM related changes:
 
 -  SPDX-related changes:
@@ -300,6 +303,7 @@ New Features / Enhancements in |yocto-ver|
       -  ``gdk-pixbuf``: ``gif``, ``others``
       -  ``libpam``: ``selinux``
       -  ``libsecret``: ``pam``
+      -  ``rpm``: ``sequoia``
 
 -  Miscellaneous changes:
 
Signature · 1 line
2.48.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [docs] [PATCH 2/2] release-notes-5.2: add information about rpm and sequoia

Quoted 20 lines · Zoltan Boszormenyi via lists.yoctoproject.org
---
 documentation/migration-guides/release-notes-5.2.rst | 4 ++++
 1 file changed, 4 insertions(+)
documentation/migration-guides/release-notes-5.2.rst +3 -0
index 06dce8d17..b0e538700 100644
@@ -226,6 +226,9 @@ New Features / Enhancements in |yocto-ver|
    -  ``package_rpm``: restrict RPM packaging to 4 threads to improve
       the compression speed.
 
+   -  ``sign_rpm``: ``rpm`` needs the ``sequoia`` :term:`PACKAGECONFIG`
+      config set to be able to generate signed packages.
+
 -  LLVM related changes:
 
 -  SPDX-related changes:

documentation/migration-guides/release-notes-5.2.rst New Features / Enhancements in |yocto-ver| · line 309

Quoted 7 lines
documentation/migration-guides/release-notes-5.2.rst +1 -0
@@ -300,6 +303,7 @@ New Features / Enhancements in |yocto-ver|
       -  ``gdk-pixbuf``: ``gif``, ``others``
       -  ``libpam``: ``selinux``
       -  ``libsecret``: ``pam``
+      -  ``rpm``: ``sequoia``
 
 -  Miscellaneous changes:
 

Thank you!
Antonin

Signature · 3 lines
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw
In reply to Zoltán Böszörményi

Hi Zoltán,

Quoted 10 lines · Zoltan Boszormenyi via lists.yoctoproject.org
---
 documentation/dev-manual/packages.rst | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
documentation/dev-manual/packages.rst +0 -0
index 4ba2dcae3..dba07a2c6 100644

documentation/dev-manual/packages.rst to use signed package feeds (repositories) when doing a build. · line 822

Quoted 7 lines
documentation/dev-manual/packages.rst +1 -3
@@ -819,9 +819,19 @@ to use signed package feeds (repositories) when doing a build.
 Signing RPM Packages
 --------------------
 
-To enable signing RPM packages, you must set up the following
-configurations in either your ``local.config`` or ``distro.config``
-file::
+To enable signing RPM packages, you must modify the RPM package

I would rephrase to

"""
you must modify the ``rpm`` recipe configuration to include... """

Because PACKAGECONFIG is a recipe-level variable, not a package-level variable.

documentation/dev-manual/packages.rst to use signed package feeds (repositories) when doing a build. · line 824

Quoted 2 lines
documentation/dev-manual/packages.rst +2 -0
+configuration to include support for OpenPGP signing. That may
+be done either in a recipe addendum called ``rpm_%.bbappend``:

This should end with :: for the code block below.

I would rather say

"""
in a ``.bbappend`` for the ``rpm`` recipe::
"""

Two reasons:

* ``.bbappend`` seems to be the most used way in the docs to denote a bbappend
* I think it's best to avoid encouraging people to use % for bbappends

documentation/dev-manual/packages.rst to use signed package feeds (repositories) when doing a build. · line 828

Quoted 4 lines
documentation/dev-manual/packages.rst +4 -0
+
+   PACKAGECONFIG:append = " sequoia"
+
+or in either your ``local.config`` or ``distro.config`` file:

This should end with :: for the code block below.

Not your fault, but modifying local.conf is also something we try not to encourage. And in any case, local.config is not a known conf file (local.conf is).

So I would just say:

"""
...or in a :term:Configuration File::
"""

documentation/dev-manual/packages.rst to use signed package feeds (repositories) when doing a build. · line 834

Quoted 6 lines
documentation/dev-manual/packages.rst +6 -0
+
+   PACKAGECONFIG:append:pn-rpm-native = " sequoia"
+   PACKAGECONFIG:append:pn-rpm = " sequoia"
+
+You must also set up the following configurations in either your
+``local.config`` or ``distro.config`` file::

Same here as above.

documentation/dev-manual/packages.rst to use signed package feeds (repositories) when doing a build. · line 837

Quoted 3 lines
documentation/dev-manual/packages.rst +0 -0
    # Inherit sign_rpm.bbclass to enable signing functionality
    INHERIT += " sign_rpm"

Thank you,
Antonin

Signature · 3 lines
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v2 1/1 dev-manual/packages: add information about signing changes

---
 documentation/dev-manual/packages.rst | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
documentation/dev-manual/packages.rst +13 -3
index 4ba2dcae3..8845bf2fa 100644
@@ -819,9 +819,19 @@ to use signed package feeds (repositories) when doing a build.
 Signing RPM Packages
 --------------------
 
-To enable signing RPM packages, you must set up the following
-configurations in either your ``local.config`` or ``distro.config``
-file::
+To enable signing RPM packages, you must modify the ``rpm``
+recipe configuration to include support for OpenPGP signing.
+That may be done either in a ``.bbappend`` for the ``rpm`` recipe::
+
+   PACKAGECONFIG:append = " sequoia"
+
+or in a :term:`Configuration File`::
+
+   PACKAGECONFIG:append:pn-rpm-native = " sequoia"
+   PACKAGECONFIG:append:pn-rpm = " sequoia"
+
+You must also set up the following settings in a
+:term:`Configuration File`::
 
    # Inherit sign_rpm.bbclass to enable signing functionality
    INHERIT += " sign_rpm"
Signature · 1 line
2.48.1
Reviewed-by on v2 1/1
#5 lore raw

Hi Zoltán,

Quoted 22 lines · Zoltán Böszörményi
---
 documentation/dev-manual/packages.rst | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
documentation/dev-manual/packages.rst +6 -3
index 4ba2dcae3..8845bf2fa 100644
@@ -819,9 +819,19 @@ to use signed package feeds (repositories) when doing a build.
 Signing RPM Packages
 --------------------
 
-To enable signing RPM packages, you must set up the following
-configurations in either your ``local.config`` or ``distro.config``
-file::
+To enable signing RPM packages, you must modify the ``rpm``
+recipe configuration to include support for OpenPGP signing.
+That may be done either in a ``.bbappend`` for the ``rpm`` recipe::
+
+   PACKAGECONFIG:append = " sequoia"
+

documentation/dev-manual/packages.rst to use signed package feeds (repositories) when doing a build. · line 837

Quoted 10 lines
documentation/dev-manual/packages.rst +7 -0
+or in a :term:`Configuration File`::
+
+   PACKAGECONFIG:append:pn-rpm-native = " sequoia"
+   PACKAGECONFIG:append:pn-rpm = " sequoia"
+
+You must also set up the following settings in a
+:term:`Configuration File`::
 
    # Inherit sign_rpm.bbclass to enable signing functionality
    INHERIT += " sign_rpm"

Looking good, thanks!

Antonin

Signature · 3 lines
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com