package/psplash: add support for two configure options
PATCH 1/1 package/psplash: add support for two configure options
Add support for two configure options:
--disable-progress-bar, via BR2_PACKAGE_PSPLAH_PROGRESS_BAR --disable-startup-msg, via BR2_PACKAGE_PSPLASH_STARTUP_MSG
Both buildroot options will default to 'y' to be compatible with the previous behaviour, since those were enable by default by not specifying the disable config flag.
--- package/psplash/Config.in | 12 ++++++++++++ package/psplash/psplash.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)
package/psplash/Config.in +12 -0
@@ -35,6 +35,18 @@ config BR2_PACKAGE_PSPLASH_IMAGE Use a personalized png image as boot splash. Let it empty if you want to keep the psplash default image. +config BR2_PACKAGE_PSPLASH_PROGRESS_BAR + bool "enable progress bar" + default y + help + Enable management of the progress bar via the "PROGRESS" command. + +config BR2_PACKAGE_PSPLASH_STARTUP_MSG + bool "enable startup message" + default y + help + Enable text banner output on startup. + endif comment "psplash needs a toolchain w/ wchar"
package/psplash/psplash.mk +12 -0
@@ -19,6 +19,18 @@ else PSPLASH_CONF_OPTS += --without-systemd endif +ifeq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-progress-bar +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-startup-msg +endif + PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE)) ifneq ($(PSPLASH_IMAGE),)
---
base-commit: 175dbdf3fc67775486ddf121b6deb651e2bf7c06
change-id: 20241122-psplash_options-f8ef9770390d
Best regards,
Signature · 6 lines
Olivier Benjamin <[email protected]> _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Bringing this back up.
Could we consider this simple patch?
Quoted 66 lines · Olivier Benjamin via buildroot
Add support for two configure options:
--disable-progress-bar, viaBR2_PACKAGE_PSPLAH_PROGRESS_BAR--disable-startup-msg, viaBR2_PACKAGE_PSPLASH_STARTUP_MSGBoth buildroot options will default to 'y' to be compatible with the previous behaviour, since those were enable by default by not specifying the disable config flag.
Signed-off-by Olivier Benjamin <[email protected]>--- package/psplash/Config.in | 12 ++++++++++++ package/psplash/psplash.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)package/psplash/Config.in +12
-0@@ -35,6 +35,18 @@ config BR2_PACKAGE_PSPLASH_IMAGE Use a personalized png image as boot splash. Let it empty if you want to keep the psplash default image. +config BR2_PACKAGE_PSPLASH_PROGRESS_BAR + bool "enable progress bar" + default y + help + Enable management of the progress bar via the "PROGRESS" command. + +config BR2_PACKAGE_PSPLASH_STARTUP_MSG + bool "enable startup message" + default y + help + Enable text banner output on startup. + endif comment "psplash needs a toolchain w/ wchar"package/psplash/psplash.mk +12
-1@@ -19,6 +19,18 @@ else PSPLASH_CONF_OPTS += --without-systemd endif +ifeq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-progress-bar +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-startup-msg +endif + PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE)) ifneq ($(PSPLASH_IMAGE),) ---base-commit:
175dbdf3fc67775486ddf121b6deb651e2bf7c06
change-id: 20241122-psplash_options-f8ef9770390dBest regards,
Signature · 8 lines
Olivier Benjamin, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v2 1/1 package/psplash: add support for two configure options
Small patch for the psplash package to add two configure options:
--disable-progress-bar, via BR2_PACKAGE_PSPLAH_PROGRESS_BAR --disable-startup-msg, via BR2_PACKAGE_PSPLASH_STARTUP_MSG
Both buildroot options will default to 'y' to be compatible with the previous behaviour, since those were enable by default by not specifying the disable config flag.
---
v1 -> v2:
* Fix warnings from check-package
In-Reply-To: [email protected]
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 1/1 package/psplash: add support for two configure options
Add support for two configure options:
--disable-progress-bar, via BR2_PACKAGE_PSPLAH_PROGRESS_BAR --disable-startup-msg, via BR2_PACKAGE_PSPLASH_STARTUP_MSG
Both buildroot options will default to 'y' to be compatible with the previous behaviour, since those were enable by default by not specifying the disable config flag.
--- package/psplash/Config.in | 12 ++++++++++++ package/psplash/psplash.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)
package/psplash/Config.in +12 -0
@@ -35,6 +35,18 @@ config BR2_PACKAGE_PSPLASH_IMAGE Use a personalized png image as boot splash. Let it empty if you want to keep the psplash default image. +config BR2_PACKAGE_PSPLASH_PROGRESS_BAR + bool "enable progress bar" + default y + help + Enable progress bar management via the "PROGRESS" command. + +config BR2_PACKAGE_PSPLASH_STARTUP_MSG + bool "enable startup message" + default y + help + Enable text banner output on startup. + endif comment "psplash needs a toolchain w/ wchar"
package/psplash/psplash.mk +12 -0
@@ -19,6 +19,18 @@ else PSPLASH_CONF_OPTS += --without-systemd endif +ifeq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-progress-bar +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG), y) +PSPLASH_CONF_OPTS += +else +PSPLASH_CONF_OPTS += --disable-startup-msg +endif + PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE)) ifneq ($(PSPLASH_IMAGE),)
Signature · 6 lines
2.47.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Olivier,
Thanks for the patch! Something was wrong in your setup: your cover letter had [PATCH v2 1/1] while it should have been [PATCH v2 0/1], and this patch had [PATCH 1/1] while it should have had [PATCH v2 1/1].
I.e, this series should have looked like this:
[PATCH v2 0/1] Title of your cover letter
[PATCH v2 1/1] package/psplash: ...
However, for a single patch, a cover letter is really useless.
See below some more comments.
Quoted 6 lines · On Thu, 30 Jan 2025 17:07:39 +0100 Olivier Benjamin…
Add support for two configure options:
--disable-progress-bar, viaBR2_PACKAGE_PSPLAH_PROGRESS_BAR--disable-startup-msg, viaBR2_PACKAGE_PSPLASH_STARTUP_MSGBoth buildroot options will default to 'y' to be compatible with the previous behaviour, since those were enable by default by
^^^^ enabled
Quoted 5 lines
not specifying the disable config flag.
Signed-off-by Olivier Benjamin <[email protected]>+ifeq ($(BR2_PACKAGE_PSPLASH_PROGRESS_BAR), y)
^^ no space here
Quoted 1 line
+PSPLASH_CONF_OPTS +=
We want this non-empty and explicit, i.e --enable-progress-bar
package/psplash/psplash.mk else · line 28
Quoted 5 lines
package/psplash/psplash.mk +5
-0+else +PSPLASH_CONF_OPTS += --disable-progress-bar +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_STARTUP_MSG), y)
Same.
Quoted 1 line
+PSPLASH_CONF_OPTS +=
Same.
I fixed those minor issues, and applied. Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot