Skip to contentSkip to conversation

dma/idxd: add device ids for new HW versions

PATCH In review Bruce Richardson 4 participants 6 messages Jan 30, 2025 – Feb 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma/idxd: add device ids for new HW versions

Add in two extra PCI device id's for future HW versions to be supported by idxd driver. This aligns with the definitions present in kernel idxd driver [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma/idxd/registers.h#n9

---
Cc: [email protected]

Since this only adds a couple of device IDs, and there are no other changes to the dma/idxd driver in 25.03, perhaps this could be considered for backport for 24.11?

---
 drivers/dma/idxd/idxd_pci.c | 4 ++++
 usertools/dpdk-devbind.py   | 7 ++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)
drivers/dma/idxd/idxd_pci.c +4 -0
index 5c05762d03..214f6f22d5 100644
@@ -11,6 +11,8 @@
 
 #define IDXD_VENDOR_ID		0x8086
 #define IDXD_DEVICE_ID_SPR	0x0B25
+#define IDXD_DEVICE_ID_GNRD	0x11FB
+#define IDXD_DEVICE_ID_DMR	0x1212
 
 #define DEVICE_VERSION_1	0x100
 #define DEVICE_VERSION_2	0x200
@@ -24,6 +26,8 @@
 
 const struct rte_pci_id pci_id_idxd_map[] = {
 	{ RTE_PCI_DEVICE(IDXD_VENDOR_ID, IDXD_DEVICE_ID_SPR) },
+	{ RTE_PCI_DEVICE(IDXD_VENDOR_ID, IDXD_DEVICE_ID_GNRD) },
+	{ RTE_PCI_DEVICE(IDXD_VENDOR_ID, IDXD_DEVICE_ID_DMR) },
 	{ .vendor_id = 0, /* sentinel */ },
 };
 
usertools/dpdk-devbind.py +6 -1
index 283707fc16..62edbba095 100755
@@ -62,6 +62,10 @@
                   'SVendor': None, 'SDevice': None}
 intel_idxd_spr = {'Class': '08', 'Vendor': '8086', 'Device': '0b25',
                   'SVendor': None, 'SDevice': None}
+intel_idxd_gnrd = {'Class': '08', 'Vendor': '8086', 'Device': '11fb',
+                  'SVendor': None, 'SDevice': None}
+intel_idxd_dmr = {'Class': '08', 'Vendor': '8086', 'Device': '1212',
+                  'SVendor': None, 'SDevice': None}
 intel_ntb_skx = {'Class': '06', 'Vendor': '8086', 'Device': '201c',
                  'SVendor': None, 'SDevice': None}
 intel_ntb_icx = {'Class': '06', 'Vendor': '8086', 'Device': '347e',
@@ -84,7 +88,8 @@
 baseband_devices = [acceleration_class]
 crypto_devices = [encryption_class, intel_processor_class]
 dma_devices = [cnxk_dma, hisilicon_dma,
-               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
+               intel_idxd_gnrd, intel_idxd_dmr, intel_idxd_spr,
+               intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
                odm_dma]
 eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, cnxk_sso]
 mempool_devices = [cavium_fpa, cnxk_npa]
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#3 lore raw
In reply to Bruce Richardson
Quoted 10 lines · Bruce Richardson

Add in two extra PCI device id's for future HW versions to be supported by idxd driver. This aligns with the definitions present in kernel idxd driver [1].

[1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma/idxd/registers.h#n9

---
Cc:[email protected]

Quoted 8 lines

Since this only adds a couple of device IDs, and there are no other changes to the dma/idxd driver in 25.03, perhaps this could be considered for backport for 24.11?

---
  drivers/dma/idxd/idxd_pci.c | 4 ++++
  usertools/dpdk-devbind.py   | 7 ++++++-
  2 files changed, 10 insertions(+), 1 deletion(-)
#4 lore raw
In reply to Bruce Richardson
Quoted 7 lines · Bruce Richardson

Add in two extra PCI device id's for future HW versions to be supported by idxd driver. This aligns with the definitions present in kernel idxd driver [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma/idxd/registers.h#n9

Quoted 7 lines

---
Cc: [email protected]

Since this only adds a couple of device IDs, and there are no other changes to the dma/idxd driver in 25.03, perhaps this could be considered for backport for 24.11?

I prefer not to mark with Cc: [email protected], because this is too vague and LTS maintainers may apply this for 22.11 or 23.11. For this special request against 24.11, the simpler is to send an explicit backport request to [email protected] with a 24.11 prefix in the title (and copy Kevin, who handles 24.11).

Patch applied, thanks.

Signature · 1 line
David Marchand
#5 lore raw
Quoted 17 lines · David Marchand
Quoted 7 lines · Bruce Richardson

Add in two extra PCI device id's for future HW versions to be supported by idxd driver. This aligns with the definitions present in kernel idxd driver [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma/idxd/registers.h#n9

Quoted 7 lines

---
Cc: [email protected]

Since this only adds a couple of device IDs, and there are no other changes to the dma/idxd driver in 25.03, perhaps this could be considered for backport for 24.11?

Quoted 8 lines

I prefer not to mark with Cc: [email protected], because this is too vague and LTS maintainers may apply this for 22.11 or 23.11. For this special request against 24.11, the simpler is to send an explicit backport request to [email protected] with a 24.11 prefix in the title (and copy Kevin, who handles 24.11).

Patch applied, thanks.

Ok, will do.
In practice, I think it would be harmless and work fine in all the older releases, but I'll just target 24.11 for safety.

/Bruce