Skip to contentSkip to conversation

sifive_unleashed: Rename "spi-nor_qemu" variant to "spi_nor_qemu"

PATCH In review Tom Rini 1 participant 3 messages Jan 31, 2025 – Feb 4, 2025 SiFive drivers

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 sifive_unleashed: Rename "spi-nor_qemu" variant to "spi_nor_qemu"

Given how files are searched and parsed, py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py was not being used due to the dash in the name. Use an underbar for consistency.

---
 ..._unleashed_spi-nor_qemu => conf.sifive_unleashed_spi_nor_qemu} | 0
 ...r_qemu.py => u_boot_boardenv_sifive_unleashed_spi_nor_qemu.py} | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename bin/travis-ci/{conf.sifive_unleashed_spi-nor_qemu => conf.sifive_unleashed_spi_nor_qemu} (100%)
 rename py/travis-ci/{u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py => u_boot_boardenv_sifive_unleashed_spi_nor_qemu.py} (100%)
bin/travis-ci/conf.sifive_unleashed_spi_nor_qemu renamed from bin/travis-ci/conf.sifive_unleashed_spi-nor_qemu +0 -0
similarity index 100%
rename from bin/travis-ci/conf.sifive_unleashed_spi-nor_qemu
rename to bin/travis-ci/conf.sifive_unleashed_spi_nor_qemu
py/travis-ci/u_boot_boardenv_sifive_unleashed_spi_nor_qemu.py renamed from py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py +0 -0
similarity index 100%
rename from py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py
rename to py/travis-ci/u_boot_boardenv_sifive_unleashed_spi_nor_qemu.py
Signature · 1 line
2.43.0
author
#1 lore raw
Quoted 9 lines · Tom Rini

Given how files are searched and parsed, py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py was not being used due to the dash in the name. Use an underbar for consistency.

---
 ..._unleashed_spi-nor_qemu => conf.sifive_unleashed_spi_nor_qemu} | 0
 ...r_qemu.py => u_boot_boardenv_sifive_unleashed_spi_nor_qemu.py} | 0
 2 files changed, 0 insertions(+), 0 deletions(-)

Note that the issue is that in test/py/conftest.py we have a specific replace - with _ in the boardenv file, so there's a handful of others that need this change as well.

I also don't quite understand why we do the rename, but since it's been there since day 1, we should fix the bad examples to not break the working deployments people have.

Signature · 1 line
Tom
author
#2 lore raw
In reply to Tom Rini
Quoted 5 lines · Tom Rini

Given how files are searched and parsed, py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py was not being used due to the dash in the name. Use an underbar for consistency.

Applied to u-boot/u-boot-test-hooks.git/master, thanks!

Signature · 1 line
Tom