crypto: crct10dif - remove from crypto API
Subsystems (7)
Eric Biggers
maintainerPATCH 1/1 crypto: crct10dif - remove from crypto API
From: Eric Biggers <[email protected]>
Remove the "crct10dif" shash algorithm from the crypto API. It has no known user now that the lib is no longer built on top of it. It has no remaining references in kernel code. The only other potential users would be the usual components that allow specifying arbitrary hash
algorithms by name, namely AF_ALG and dm-integrity. However there are
no indications that "crct10dif" is being used with these components. Debian Code Search and web searches don't find anything relevant, and explicitly grepping the source code of the usual suspects (cryptsetup, libell, iwd) finds no matches either. "crc32" and "crc32c" are used in a few more places, but that doesn't seem to be the case for "crct10dif".
crc_t10dif_update() is also tested by crc_kunit now, so the test coverage provided via the crypto self-tests is no longer needed.
Also note that the "crct10dif" shash algorithm was inconsistent with the rest of the shash API in that it wrote the digest in CPU endianness, making the resulting byte array differ on little endian vs. big endian platforms. This means it was effectively just built for use by the lib functions, and it was not actually correct to treat it as "just another hash function" that could be dropped in via the shash API.
---
I'm planning to take this via the crc tree.
arch/mips/configs/decstation_64_defconfig | 1 - arch/mips/configs/decstation_defconfig | 1 - arch/mips/configs/decstation_r4k_defconfig | 1 - crypto/Kconfig | 9 - crypto/Makefile | 2 - crypto/crct10dif_generic.c | 168 ---------- crypto/tcrypt.c | 8 - crypto/testmgr.c | 7 - crypto/testmgr.h | 288 ------------------ include/linux/crc-t10dif.h | 3 - .../testing/selftests/arm64/fp/kernel-test.c | 1 - 11 files changed, 489 deletions(-) delete mode 100644 crypto/crct10dif_generic.c
arch/mips/configs/decstation_64_defconfig +0 -1
@@ -178,11 +178,10 @@ CONFIG_CRYPTO_OFB=m CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_XTS=m CONFIG_CRYPTO_CMAC=m CONFIG_CRYPTO_XCBC=m CONFIG_CRYPTO_CRC32=m -CONFIG_CRYPTO_CRCT10DIF=m CONFIG_CRYPTO_MD4=m CONFIG_CRYPTO_MICHAEL_MIC=m CONFIG_CRYPTO_RMD160=m CONFIG_CRYPTO_SHA512=m CONFIG_CRYPTO_WP512=m
arch/mips/configs/decstation_defconfig +0 -1
@@ -173,11 +173,10 @@ CONFIG_CRYPTO_OFB=m CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_XTS=m CONFIG_CRYPTO_CMAC=m CONFIG_CRYPTO_XCBC=m CONFIG_CRYPTO_CRC32=m -CONFIG_CRYPTO_CRCT10DIF=m CONFIG_CRYPTO_MD4=m CONFIG_CRYPTO_MICHAEL_MIC=m CONFIG_CRYPTO_RMD160=m CONFIG_CRYPTO_SHA512=m CONFIG_CRYPTO_WP512=m
arch/mips/configs/decstation_r4k_defconfig +0 -1
@@ -173,11 +173,10 @@ CONFIG_CRYPTO_OFB=m CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_XTS=m CONFIG_CRYPTO_CMAC=m CONFIG_CRYPTO_XCBC=m CONFIG_CRYPTO_CRC32=m -CONFIG_CRYPTO_CRCT10DIF=m CONFIG_CRYPTO_MD4=m CONFIG_CRYPTO_MICHAEL_MIC=m CONFIG_CRYPTO_RMD160=m CONFIG_CRYPTO_SHA512=m CONFIG_CRYPTO_WP512=m
crypto/Kconfig +0 -9
@@ -1079,19 +1079,10 @@ config CRYPTO_CRC32 help CRC32 CRC algorithm (IEEE 802.3) Used by RoCEv2 and f2fs. -config CRYPTO_CRCT10DIF - tristate "CRCT10DIF" - select CRYPTO_HASH - select CRC_T10DIF - help - CRC16 CRC algorithm used for the T10 (SCSI) Data Integrity Field (DIF) - - CRC algorithm used by the SCSI Block Commands standard. - endmenu menu "Compression" config CRYPTO_DEFLATE
crypto/Makefile +0 -2
@@ -153,12 +153,10 @@ obj-$(CONFIG_CRYPTO_DEFLATE) += deflate.o obj-$(CONFIG_CRYPTO_MICHAEL_MIC) += michael_mic.o obj-$(CONFIG_CRYPTO_CRC32C) += crc32c_generic.o obj-$(CONFIG_CRYPTO_CRC32) += crc32_generic.o CFLAGS_crc32c_generic.o += -DARCH=$(ARCH) CFLAGS_crc32_generic.o += -DARCH=$(ARCH) -obj-$(CONFIG_CRYPTO_CRCT10DIF) += crct10dif_generic.o -CFLAGS_crct10dif_generic.o += -DARCH=$(ARCH) obj-$(CONFIG_CRYPTO_AUTHENC) += authenc.o authencesn.o obj-$(CONFIG_CRYPTO_LZO) += lzo.o lzo-rle.o obj-$(CONFIG_CRYPTO_LZ4) += lz4.o obj-$(CONFIG_CRYPTO_LZ4HC) += lz4hc.o obj-$(CONFIG_CRYPTO_XXHASH) += xxhash_generic.o
crypto/crct10dif_generic.c deleted +0 -168
168 lines not on this page · raw message
crypto/tcrypt.c +0 -8
@@ -1652,14 +1652,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)case 46 : ret =min (ret,tcrypt_test ("ghash" ));break ; -case 47 : - ret =min (ret,tcrypt_test ("crct10dif" )); -break ; -case 48 : ret =min (ret,tcrypt_test ("sha3-224" ));break ;case 49 :
@@ -2270,14 +2266,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb) fallthrough;case 319 :test_hash_speed ("crc32c" , sec, generic_hash_speed_template);if (mode >300 && mode <400 )break ; fallthrough; -case 320 : -test_hash_speed ("crct10dif" , sec, generic_hash_speed_template); -if (mode >300 && mode <400 )break ; - fallthrough;case 321 :test_hash_speed ("poly1305" , sec, poly1305_speed_template);if (mode >300 && mode <400 )break ; fallthrough;case 322 :
crypto/testmgr.c +0 -7
@@ -4757,17 +4757,10 @@ static const struct alg_test_desc alg_test_descs[] = { .test = alg_test_crc32c, .fips_allowed = 1, .suite = { .hash = __VECS(crc32c_tv_template) } - }, { - .alg = "crct10dif", - .test = alg_test_hash, - .fips_allowed = 1, - .suite = { - .hash = __VECS(crct10dif_tv_template) - } }, { .alg = "ctr(aes)", .test = alg_test_skcipher, .fips_allowed = 1, .suite = {
crypto/testmgr.h +0 -288
298 lines not on this page · raw message
include/linux/crc-t10dif.h +0 -3
@@ -2,13 +2,10 @@#ifndef _LINUX_CRC_T10DIF_H#define _LINUX_CRC_T10DIF_H#include <linux/types.h> -#define CRC_T10DIF_DIGEST_SIZE 2 -#define CRC_T10DIF_BLOCK_SIZE 1 -u16 crc_t10dif_arch (u16 crc,const u8 *p,size_t len);u16 crc_t10dif_generic (u16 crc,const u8 *p,size_t len);static inline u16 crc_t10dif_update (u16 crc,const u8 *p,size_t len) {
tools/testing/selftests/arm64/fp/kernel-test.c +0 -1
@@ -44,11 +44,10 @@ static void handle_kick_signal(int sig, siginfo_t *info, void *context) { sigs++; }static char *drivers[] = { -"crct10dif-arm64" ,"sha1-ce" ,"sha224-arm64" ,"sha224-arm64-neon" ,"sha224-ce" ,"sha256-arm64" ,
base-commit: 8c50e1db89da675917fb6297026f46cf32c515d5
Signature · 1 line
2.48.1
Eric,
Quoted 11 lines
Remove the "crct10dif" shash algorithm from the crypto API. It has no known user now that the lib is no longer built on top of it. It has no remaining references in kernel code. The only other potential users would be the usual components that allow specifying arbitrary hash algorithms by name, namely
AF_ALGand dm-integrity. However there are no indications that "crct10dif" is being used with these components. Debian Code Search and web searches don't find anything relevant, and explicitly grepping the source code of the usual suspects (cryptsetup, libell, iwd) finds no matches either. "crc32" and "crc32c" are used in a few more places, but that doesn't seem to be the case for "crct10dif".
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 29 lines · Eric Biggers
From: Eric Biggers <[email protected]>
Remove the "crct10dif" shash algorithm from the crypto API. It has no known user now that the lib is no longer built on top of it. It has no remaining references in kernel code. The only other potential users would be the usual components that allow specifying arbitrary hash
algorithms by name, namelyAF_ALGand dm-integrity. However there are
no indications that "crct10dif" is being used with these components. Debian Code Search and web searches don't find anything relevant, and explicitly grepping the source code of the usual suspects (cryptsetup, libell, iwd) finds no matches either. "crc32" and "crc32c" are used in a few more places, but that doesn't seem to be the case for "crct10dif".
crc_t10dif_update()is also tested bycrc_kunitnow, so the test coverage provided via the crypto self-tests is no longer needed.Also note that the "crct10dif" shash algorithm was inconsistent with the rest of the shash API in that it wrote the digest in CPU endianness, making the resulting byte array differ on little endian vs. big endian platforms. This means it was effectively just built for use by the lib functions, and it was not actually correct to treat it as "just another hash function" that could be dropped in via the shash API.
Signed-off-by Eric Biggers <[email protected]>---
I'm planning to take this via the crc tree.
Quoted 14 lines
arch/mips/configs/decstation_64_defconfig | 1 - arch/mips/configs/decstation_defconfig | 1 - arch/mips/configs/decstation_r4k_defconfig | 1 - crypto/Kconfig | 9 - crypto/Makefile | 2 - crypto/crct10dif_generic.c | 168 ---------- crypto/tcrypt.c | 8 - crypto/testmgr.c | 7 - crypto/testmgr.h | 288 ------------------ include/linux/crc-t10dif.h | 3 - .../testing/selftests/arm64/fp/kernel-test.c | 1 - 11 files changed, 489 deletions(-) delete mode 100644 crypto/crct10dif_generic.c