Skip to contentSkip to conversation

PCI: hv: Correct a comment

PATCH Applied Easwar Hariharan 5 participants 9 messages Feb 7, 2025 – Feb 24, 2025

Subsystems (4)
PCI PCI native host bridge and endpoint drivers Hyper-V/Azure core and drivers Microsoft MANA RDMA driver
lore
Share & tools
lore

Easwar Hariharan

author
#0 lore raw

PATCH v2 1/1 PCI: hv: Correct a comment

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Signed-off-by Easwar Hariharan <[email protected]>
---
 drivers/pci/controller/pci-hyperv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-hyperv.c +1 -1
index 6084b38bdda1..3ae3a8a79dcf 100644
@@ -1356,7 +1356,7 @@ static struct pci_ops hv_pcifront_ops = {
  *
  * If the PF driver wishes to initiate communication, it can "invalidate" one or
  * more of the first 64 blocks.  This invalidation is delivered via a callback
- * supplied by the VF driver by this driver.
+ * supplied to the VF driver by this driver.
  *
  * No protocol is implied, except that supplied by the PF and VF drivers.
  */
Signature · 1 line
2.43.0
Reviewed-by on v2 1/1
#1 lore raw

From: Easwar Hariharan <[email protected]> Sent: Friday, February 7, 2025 11:07 AM

Quoted 24 lines

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Signed-off-by Easwar Hariharan <[email protected]>
---
 drivers/pci/controller/pci-hyperv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-hyperv.c +1 -2
index 6084b38bdda1..3ae3a8a79dcf 100644
@@ -1356,7 +1356,7 @@ static struct pci_ops hv_pcifront_ops = {
  *
  * If the PF driver wishes to initiate communication, it can "invalidate" one or
  * more of the first 64 blocks.  This invalidation is delivered via a callback
- * supplied by the VF driver by this driver.
+ * supplied to the VF driver by this driver.
  *
  * No protocol is implied, except that supplied by the PF and VF drivers.
  */
--
Quoted 2 lines

2.43.0

Reviewed-by Michael Kelley <[email protected]>
Reviewed-by on v2 1/1
#2 lore raw
In reply to Easwar Hariharan
Quoted 5 lines · Easwar Hariharan

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Signed-off-by Easwar Hariharan <[email protected]>
Reviewed-by Manivannan Sadhasivam <[email protected]>
Quoted 1 line

---

Where is the changelog?

- Mani

Quoted 19 lines
 drivers/pci/controller/pci-hyperv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-hyperv.c +1 -1
index 6084b38bdda1..3ae3a8a79dcf 100644
@@ -1356,7 +1356,7 @@ static struct pci_ops hv_pcifront_ops = {
  *
  * If the PF driver wishes to initiate communication, it can "invalidate" one or
  * more of the first 64 blocks.  This invalidation is delivered via a callback
- * supplied by the VF driver by this driver.
+ * supplied to the VF driver by this driver.
  *
  * No protocol is implied, except that supplied by the PF and VF drivers.
  */
Signature · 1 line
2.43.0
Signature · 1 line
மணிவண்ணன் சதாசிவம்
author
#3 lore raw
Quoted 7 lines · Manivannan Sadhasivam
Quoted 5 lines · Easwar Hariharan

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Signed-off-by Easwar Hariharan <[email protected]>
Quoted 8 lines
Reviewed-by Manivannan Sadhasivam <[email protected]>
Quoted 1 line

---

Where is the changelog?

- Mani

Yes, sorry, I realized it after I sent it.

Thanks for the review!

- Easwar (he/him)

#5 lore raw

Hello,

Quoted 7 lines
Quoted 5 lines

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Signed-off-by Easwar Hariharan <[email protected]>

Applied. Thanks.

Would you mind if I take this via the PCI tree?

Thank you!

Krzysztof

maintainer
#6 lore raw
Quoted 11 lines · Krzysztof Wilczyński

Hello,

Quoted 7 lines
Quoted 5 lines

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Signed-off-by Easwar Hariharan <[email protected]>

Applied. Thanks.

Would you mind if I take this via the PCI tree?

No problem. I can drop that from my tree.

Thanks,
Wei.

Quoted 4 lines

Thank you!

Krzysztof

#7 lore raw

Hello,

[...]

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Applied. Thanks.

Would you mind if I take this via the PCI tree?

No problem. I can drop that from my tree.

Thank you!

Krzysztof

Applied
#8 lore raw
In reply to Easwar Hariharan

Hello,

Quoted 3 lines

The VF driver controls an endpoint attached to the pci-hyperv controller. An invalidation sent by the PF driver in the host would be delivered *to* the endpoint driver by the controller driver.

Applied to controller/hyperv, thank you!

Krzysztof