Skip to contentSkip to conversation

lib/crc-t10dif: remove crc_t10dif_is_optimized()

PATCH In review Eric Biggers 2 participants 2 messages Feb 8, 2025 – Feb 9, 2025

Subsystems (6)
Arm (32-bit) x86 PowerPC Crypto API +2 more subsystems
lore
Share & tools
lore

Eric Biggers

author maintainer
#0 lore raw

PATCH 1/1 lib/crc-t10dif: remove crc_t10dif_is_optimized()

From: Eric Biggers <[email protected]>

With the "crct10dif" algorithm having been removed from the crypto API, crc_t10dif_is_optimized() is no longer used.

---

This applies to
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

 arch/arm/lib/crc-t10dif-glue.c     | 6 ------
 arch/arm64/lib/crc-t10dif-glue.c   | 6 ------
 arch/powerpc/lib/crc-t10dif-glue.c | 6 ------
 arch/x86/lib/crc-t10dif-glue.c     | 6 ------
 include/linux/crc-t10dif.h         | 9 ---------
 5 files changed, 33 deletions(-)
arch/arm/lib/crc-t10dif-glue.c +0 -6
index d24dee62670e..f3584ba70e57 100644
@@ -67,14 +67,8 @@ arch_initcall(crc_t10dif_arm_init);
 static void __exit crc_t10dif_arm_exit(void)
 {
 }
 module_exit(crc_t10dif_arm_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-	return static_key_enabled(&have_neon);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_AUTHOR("Ard Biesheuvel <[email protected]>");
 MODULE_DESCRIPTION("Accelerated CRC-T10DIF using ARM NEON and Crypto Extensions");
 MODULE_LICENSE("GPL v2");
arch/arm64/lib/crc-t10dif-glue.c +0 -6
index dab7e3796232..a007d0c5f3fe 100644
@@ -68,14 +68,8 @@ arch_initcall(crc_t10dif_arm64_init);
 static void __exit crc_t10dif_arm64_exit(void)
 {
 }
 module_exit(crc_t10dif_arm64_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-	return static_key_enabled(&have_asimd);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_AUTHOR("Ard Biesheuvel <[email protected]>");
 MODULE_DESCRIPTION("CRC-T10DIF using arm64 NEON and Crypto Extensions");
 MODULE_LICENSE("GPL v2");
arch/powerpc/lib/crc-t10dif-glue.c +0 -6
index 730850dbc51d..f411b0120cc5 100644
@@ -76,14 +76,8 @@ arch_initcall(crc_t10dif_powerpc_init);
 static void __exit crc_t10dif_powerpc_exit(void)
 {
 }
 module_exit(crc_t10dif_powerpc_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-	return static_key_enabled(&have_vec_crypto);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_AUTHOR("Daniel Axtens <[email protected]>");
 MODULE_DESCRIPTION("CRCT10DIF using vector polynomial multiply-sum instructions");
 MODULE_LICENSE("GPL");
arch/x86/lib/crc-t10dif-glue.c +0 -6
index 13f07ddc9122..7734bdbc2e39 100644
@@ -39,13 +39,7 @@ arch_initcall(crc_t10dif_x86_init);
 static void __exit crc_t10dif_x86_exit(void)
 {
 }
 module_exit(crc_t10dif_x86_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-	return static_key_enabled(&have_pclmulqdq);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_DESCRIPTION("CRC-T10DIF using PCLMULQDQ instructions");
 MODULE_LICENSE("GPL");
include/linux/crc-t10dif.h +0 -9
index d0706544fc11..a559fdff3f7e 100644
@@ -17,15 +17,6 @@ static inline u16 crc_t10dif_update(u16 crc, const u8 *p, size_t len)
 static inline u16 crc_t10dif(const u8 *p, size_t len)
 {
 	return crc_t10dif_update(0, p, len);
 }
 
-#if IS_ENABLED(CONFIG_CRC_T10DIF_ARCH)
-bool crc_t10dif_is_optimized(void);
-#else
-static inline bool crc_t10dif_is_optimized(void)
-{
-	return false;
-}
-#endif
-
 #endif

base-commit: 3dceb9c4f1202d2c374976936ef803bf4b076fa7

Signature · 1 line
2.48.1
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Eric Biggers

From: Eric Biggers <[email protected]>

With the "crct10dif" algorithm having been removed from the crypto API, crc_t10dif_is_optimized() is no longer used.

---

This applies to
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

Quoted 7 lines
 arch/arm/lib/crc-t10dif-glue.c     | 6 ------
 arch/arm64/lib/crc-t10dif-glue.c   | 6 ------
 arch/powerpc/lib/crc-t10dif-glue.c | 6 ------
 arch/x86/lib/crc-t10dif-glue.c     | 6 ------
 include/linux/crc-t10dif.h         | 9 ---------
 5 files changed, 33 deletions(-)
Quoted 100 lines
arch/arm/lib/crc-t10dif-glue.c +0 -6
index d24dee62670e..f3584ba70e57 100644
@@ -67,14 +67,8 @@ arch_initcall(crc_t10dif_arm_init);
 static void __exit crc_t10dif_arm_exit(void)
 {
 }
 module_exit(crc_t10dif_arm_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-       return static_key_enabled(&have_neon);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_AUTHOR("Ard Biesheuvel <[email protected]>");
 MODULE_DESCRIPTION("Accelerated CRC-T10DIF using ARM NEON and Crypto Extensions");
 MODULE_LICENSE("GPL v2");
arch/arm64/lib/crc-t10dif-glue.c +0 -6
index dab7e3796232..a007d0c5f3fe 100644
@@ -68,14 +68,8 @@ arch_initcall(crc_t10dif_arm64_init);
 static void __exit crc_t10dif_arm64_exit(void)
 {
 }
 module_exit(crc_t10dif_arm64_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-       return static_key_enabled(&have_asimd);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_AUTHOR("Ard Biesheuvel <[email protected]>");
 MODULE_DESCRIPTION("CRC-T10DIF using arm64 NEON and Crypto Extensions");
 MODULE_LICENSE("GPL v2");
arch/powerpc/lib/crc-t10dif-glue.c +0 -6
index 730850dbc51d..f411b0120cc5 100644
@@ -76,14 +76,8 @@ arch_initcall(crc_t10dif_powerpc_init);
 static void __exit crc_t10dif_powerpc_exit(void)
 {
 }
 module_exit(crc_t10dif_powerpc_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-       return static_key_enabled(&have_vec_crypto);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_AUTHOR("Daniel Axtens <[email protected]>");
 MODULE_DESCRIPTION("CRCT10DIF using vector polynomial multiply-sum instructions");
 MODULE_LICENSE("GPL");
arch/x86/lib/crc-t10dif-glue.c +0 -6
index 13f07ddc9122..7734bdbc2e39 100644
@@ -39,13 +39,7 @@ arch_initcall(crc_t10dif_x86_init);
 static void __exit crc_t10dif_x86_exit(void)
 {
 }
 module_exit(crc_t10dif_x86_exit);
 
-bool crc_t10dif_is_optimized(void)
-{
-       return static_key_enabled(&have_pclmulqdq);
-}
-EXPORT_SYMBOL(crc_t10dif_is_optimized);
-
 MODULE_DESCRIPTION("CRC-T10DIF using PCLMULQDQ instructions");
 MODULE_LICENSE("GPL");
include/linux/crc-t10dif.h +0 -9
index d0706544fc11..a559fdff3f7e 100644
@@ -17,15 +17,6 @@ static inline u16 crc_t10dif_update(u16 crc, const u8 *p, size_t len)
 static inline u16 crc_t10dif(const u8 *p, size_t len)
 {
        return crc_t10dif_update(0, p, len);
 }
 
-#if IS_ENABLED(CONFIG_CRC_T10DIF_ARCH)
-bool crc_t10dif_is_optimized(void);
-#else
-static inline bool crc_t10dif_is_optimized(void)
-{
-       return false;
-}
-#endif
-
 #endif

base-commit: 3dceb9c4f1202d2c374976936ef803bf4b076fa7 --
2.48.1