Skip to contentSkip to conversation

arm64: dts: socfpga: agilex5: add NAND daughter board

PATCH Applied [email protected] 4 participants 7 messages Feb 10, 2025 – Feb 11, 2025 Device tree bindings

lore
Share & tools
lore
#0 lore raw

v3 cover arm64: dts: socfpga: agilex5: add NAND daughter board

From: Niravkumar L Rabara <[email protected]>

Agilex5 SoCFPGA devkit supports a separate NAND daughter board. Document NAND daughter board compatible string and add board file.

Changes in v3:
* Document Agilex5 NAND daughter board and use that compatible in the device tree.

link to v2:
- https://lore.kernel.org/all/[email protected]/

Changes in v2:
* Use nand flash node name according to dt bindings to fix dt build warnings.
* Arrange node in sequence.

link to v1:
- https://lore.kernel.org/all/[email protected]/

Niravkumar L Rabara (2):
dt-bindings: intel: document Agilex5 NAND daughter board
arm64: dts: socfpga: agilex5: add NAND daughter board

 .../bindings/arm/intel,socfpga.yaml           |  1 +
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_nand.dts  | 89 +++++++++++++++++++
 3 files changed, 91 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 1/2 dt-bindings: intel: document Agilex5 NAND daughter board

From: Niravkumar L Rabara <[email protected]>

Agilex5 devkit supports a separate NAND daughter board. Document Agilex5 NAND daughter board compatible.

---
 Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/intel,socfpga.yaml +1 -0
index 2ee0c740eb56..c75cd7d29f1a 100644
@@ -25,6 +25,7 @@ properties:
         items:
           - enum:
               - intel,socfpga-agilex5-socdk
+              - intel,socfpga-agilex5-socdk-nand
           - const: intel,socfpga-agilex5
 
 additionalProperties: true
Signature · 1 line
2.25.1
Acked-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: intel: document Agilex5 NAND daughter board

Quoted 9 lines · On Mon, Feb 10, 2025 at 03:46:03PM +0800, [email protected] wrote:

From: Niravkumar L Rabara <[email protected]>

Agilex5 devkit supports a separate NAND daughter board. Document Agilex5 NAND daughter board compatible.

---
 Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 +
 1 file changed, 1 insertion(+)

Best regards,
Krzysztof

#3 lore raw

PATCH v3 2/2 arm64: dts: socfpga: agilex5: add NAND daughter board

In reply to [email protected]

From: Niravkumar L Rabara <[email protected]>

The Agilex5 devkit supports a separate NAND daughter card. The NAND daughter card replaces the SDMMC slot that is on the default daughter card thus requires a separate board dts file.

---
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_nand.dts  | 89 +++++++++++++++++++
 2 files changed, 90 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts
arch/arm64/boot/dts/intel/Makefile +1 -0
index d39cfb723f5b..33f6d01266b1 100644
@@ -3,5 +3,6 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
 				socfpga_agilex_socdk.dtb \
 				socfpga_agilex_socdk_nand.dtb \
 				socfpga_agilex5_socdk.dtb \
+				socfpga_agilex5_socdk_nand.dtb \
 				socfpga_n5x_socdk.dtb
 dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts new file +89 -0

89 lines not on this page · raw message

Signature · 1 line
2.25.1
Reviewed-by on v3 2/2
#4 lore raw
Quoted 6 lines · On Mon, Feb 10, 2025 at 03:46:04PM +0800, [email protected] wrote:

From: Niravkumar L Rabara <[email protected]>

The Agilex5 devkit supports a separate NAND daughter card. The NAND daughter card replaces the SDMMC slot that is on the default daughter card thus requires a separate board dts file.

Quoted 7 lines
---
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_nand.dts  | 89 +++++++++++++++++++
 2 files changed, 90 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts

Reported warning comes from existing DTSI, I think, so:

Best regards,
Krzysztof

#5 lore raw
In reply to [email protected]
Quoted 23 lines · On Mon, 10 Feb 2025 15:46:02 +0800, [email protected] wrote:

From: Niravkumar L Rabara <[email protected]>

Agilex5 SoCFPGA devkit supports a separate NAND daughter board. Document NAND daughter board compatible string and add board file.

Changes in v3:
* Document Agilex5 NAND daughter board and use that compatible in the device tree.

link to v2:
- https://lore.kernel.org/all/[email protected]/

Changes in v2:
* Use nand flash node name according to dt bindings to fix dt build warnings.
* Arrange node in sequence.

link to v1:
- https://lore.kernel.org/all/[email protected]/

Niravkumar L Rabara (2):
dt-bindings: intel: document Agilex5 NAND daughter board
arm64: dts: socfpga: agilex5: add NAND daughter board

Quoted 11 lines
 .../bindings/arm/intel,socfpga.yaml           |  1 +
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_nand.dts  | 89 +++++++++++++++++++
 3 files changed, 91 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts

--
2.25.1

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/intel/' for [email protected]:

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dtb: clock-controller@ffd10000: 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/clock/intel,easic-n5x.yaml#

Applied
#6 lore raw
In reply to [email protected]
Quoted 23 lines · On 2/10/25 01:46, [email protected] wrote:

From: Niravkumar L Rabara <[email protected]>

Agilex5 SoCFPGA devkit supports a separate NAND daughter board. Document NAND daughter board compatible string and add board file.

Changes in v3:
* Document Agilex5 NAND daughter board and use that compatible in the device tree.

link to v2:
- https://lore.kernel.org/all/[email protected]/

Changes in v2:
* Use nand flash node name according to dt bindings to fix dt build warnings.
* Arrange node in sequence.

link to v1:
- https://lore.kernel.org/all/[email protected]/

Niravkumar L Rabara (2):
dt-bindings: intel: document Agilex5 NAND daughter board
arm64: dts: socfpga: agilex5: add NAND daughter board

Quoted 6 lines
  .../bindings/arm/intel,socfpga.yaml           |  1 +
  arch/arm64/boot/dts/intel/Makefile            |  1 +
  .../dts/intel/socfpga_agilex5_socdk_nand.dts  | 89 +++++++++++++++++++
  3 files changed, 91 insertions(+)

create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts

Applied!

Thanks,
Dinh