FAILED: patch "[PATCH] soc: mediatek: mtk-devapc: Fix leaking IO map on error paths" failed to apply to 6.1-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
git checkout FETCH_HEAD
git cherry-pick -x c0eb059a4575ed57f265d9883a5203799c19982c
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025021059-repulsive-savor-1f9d@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From c0eb059a4575ed57f265d9883a5203799c19982c Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 4 Jan 2025 15:20:11 +0100
Subject: [PATCH] soc: mediatek: mtk-devapc: Fix leaking IO map on error paths
Error paths of mtk_devapc_probe() should unmap the memory. Reported by Smatch:
drivers/soc/mediatek/mtk-devapc.c:292 mtk_devapc_probe() warn: 'ctx->infra_base' from of_iomap() not released on lines: 277,281,286.
drivers/soc/mediatek/mtk-devapc.c +13 -5
@@ -273,23 +273,31 @@ static int mtk_devapc_probe(struct platform_device *pdev)return -EINVAL ; devapc_irq =irq_of_parse_and_map (node,0 ); -if (!devapc_irq) -return -EINVAL ; +if (!devapc_irq) { + ret = -EINVAL ; + goto err; + } ctx->infra_clk =devm_clk_get_enabled (&pdev->dev,"devapc-infra-clock" ); -if (IS_ERR (ctx->infra_clk)) -return -EINVAL ; +if (IS_ERR (ctx->infra_clk)) { + ret = -EINVAL ; + goto err; + } ret =devm_request_irq (&pdev->dev, devapc_irq, devapc_violation_irq,IRQF_TRIGGER_NONE ,"devapc" , ctx);if (ret) -return ret; + goto err;platform_set_drvdata (pdev, ctx);start_devapc (ctx);return 0 ; + +err: +iounmap (ctx->infra_base); +return ret; }static void mtk_devapc_remove (struct platform_device *pdev)