ACPI: platform_profile: Improve platform_profile_unregister
Subsystems (2)
PATCH 1/1 ACPI: platform_profile: Improve platform_profile_unregister
Drivers usually call this method on error/exit paths and do not check for it's return value, which is always 0 anyway, so make it void. This is safe to do as currently all drivers use devm_platform_profile_register().
While at it improve the style and make the function safer by checking for IS_ERR_OR_NULL before dereferencing the device pointer.
Signed-off-by Kurt Borja <[email protected]>
---
Hi Rafael,
Please tell me if you prefer different commits for this. Also, should we WARN_ON(IS_ERR_OR_NULL(dev))?
Based on the acpi branch of the linux-pm tree.
~ Kurt
--- drivers/acpi/platform_profile.c | 15 ++++++--------- include/linux/platform_profile.h | 2 +- 2 files changed, 7 insertions(+), 10 deletions(-)
drivers/acpi/platform_profile.c +6 -9
@@ -569,24 +569,21 @@ EXPORT_SYMBOL_GPL(platform_profile_register);/** * platform_profile_remove - Unregisters a platform profile class device * @dev: Class device -* -* Return: 0 */ -int platform_profile_remove (struct device *dev) +void platform_profile_remove (struct device *dev) {struct platform_profile_handler *pprof =to_pprof_handler (dev); -int id; + +if (IS_ERR_OR_NULL (dev)) +return ; +guard (mutex)(&profile_lock); - id = pprof->minor; +ida_free (&platform_profile_ida, pprof->minor);device_unregister (&pprof->dev); -ida_free (&platform_profile_ida, id);sysfs_notify (acpi_kobj,NULL ,"platform_profile" ); -sysfs_update_group (acpi_kobj, &platform_profile_group); - -return 0 ; }EXPORT_SYMBOL_GPL (platform_profile_remove);
include/linux/platform_profile.h +1 -1
@@ -47,7 +47,7 @@ struct platform_profile_ops {struct device *platform_profile_register (struct device *dev,const char *name,void *drvdata,const struct platform_profile_ops *ops); -int platform_profile_remove (struct device *dev); +void platform_profile_remove (struct device *dev);struct device *devm_platform_profile_register (struct device *dev,const char *name,void *drvdata,const struct platform_profile_ops *ops);
base-commit: 3e3e377dd1f300bbdd230533686ce9c9f4f8a90d
Signature · 1 line
2.48.1