Skip to contentSkip to conversation

gpiolib: acpi: Add a quirk for Acer Nitro ANV14

PATCH Applied Mario Limonciello 4 participants 5 messages Feb 11, 2025 – Feb 12, 2025

Subsystems (3)
Stable branch ACPI GPIO
lore
Share & tools
lore

Mario Limonciello

author
#0 lore raw

PATCH 1/1 gpiolib: acpi: Add a quirk for Acer Nitro ANV14

From: Mario Limonciello <[email protected]>

Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.

Block the interrupt from getting set up for this GPIO on this device.

Cc [email protected]
Reported-and-tested-by Delgan <[email protected]>

Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954

Signed-off-by Mario Limonciello <[email protected]>
---
 drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/gpio/gpiolib-acpi.c +14 -0
index 1f9fe50bba005..f7746c57ba76a 100644
@@ -1689,6 +1689,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "PNP0C50:00@8",
 		},
 	},
+	{
+		/*
+		 * Spurious wakeups from GPIO 11
+		 * Found in BIOS 1.04
+		 * https://gitlab.freedesktop.org/drm/amd/-/issues/3954
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_FAMILY, "Acer Nitro V 14"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_interrupt = "AMDI0030:00@11",
+		},
+	},
 	{} /* Terminating entry */
 };
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.

Quoted 6 lines

Block the interrupt from getting set up for this GPIO on this device.

Cc [email protected]
Reported-and-tested-by Delgan <[email protected]>

Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954

Signed-off-by Mario Limonciello <[email protected]>
Acked-by Mika Westerberg <[email protected]>
Applied
#2 lore raw
In reply to Mario Limonciello

From: Bartosz Golaszewski <[email protected]>

Quoted 8 lines · Mario Limonciello

Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.

Block the interrupt from getting set up for this GPIO on this device.

[...]

Applied, thanks!

[1/1] gpiolib: acpi: Add a quirk for Acer Nitro ANV14

      commit: 8743d66979e494c5378563e6b5a32e913380abd8

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>
#3 lore raw
In reply to Mario Limonciello
Quoted 11 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.

Block the interrupt from getting set up for this GPIO on this device.

Cc [email protected]
Reported-and-tested-by Delgan <[email protected]>

Please refer to process/submitting-patches.rst - don't combine tags.

Quoted 1 line

Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954

This should be Closes, not Close.

I fixed the two above myself but please keep it in mind next time.

Bartosz

Acked-by on v1 1/1
#4 lore raw
In reply to Mario Limonciello
Quoted 11 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.

Block the interrupt from getting set up for this GPIO on this device.

Cc [email protected]
Reported-and-tested-by Delgan <[email protected]>

Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954

Closes:

Otherwise,

Acked-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards,
Andy Shevchenko