FAILED: patch "[PATCH] fs: fix adding security options to statmount.mnt_opt" failed to apply to 6.13-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.13-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.13.y
git checkout FETCH_HEAD
git cherry-pick -x 5eb987105357cb7cfa7cf3b1e2f66d5c0977e412
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025021142-whoops-explicit-4d75@gregkh' --subject-prefix 'PATCH 6.13.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 5eb987105357cb7cfa7cf3b1e2f66d5c0977e412 Mon Sep 17 00:00:00 2001
From: Miklos Szeredi <[email protected]>
Date: Wed, 29 Jan 2025 16:12:53 +0100
Subject: [PATCH] fs: fix adding security options to statmount.mnt_opt
Prepending security options was made conditional on sb->s_op->show_options, but security options are independent of sb options.
fs/namespace.c +16 -17
@@ -5087,31 +5087,30 @@ static int statmount_mnt_opts(struct kstatmount *s, struct seq_file *seq) {struct vfsmount *mnt = s->mnt;struct super_block *sb = mnt->mnt_sb; +size_t start = seq->count;int err; + err =security_sb_show_options (seq, sb); +if (err) +return err; +if (sb->s_op->show_options) { -size_t start = seq->count; - - err =security_sb_show_options (seq, sb); -if (err) -return err; - err = sb->s_op->show_options (seq, mnt->mnt_root);if (err)return err; - -if (unlikely (seq_has_overflowed (seq))) -return -EAGAIN ; - -if (seq->count == start) -return 0 ; - -/* skip leading comma */ -memmove (seq->buf + start, seq->buf + start +1 , - seq->count - start -1 ); - seq->count--; } +if (unlikely (seq_has_overflowed (seq))) +return -EAGAIN ; + +if (seq->count == start) +return 0 ; + +/* skip leading comma */ +memmove (seq->buf + start, seq->buf + start +1 , + seq->count - start -1 ); + seq->count--; +return 0 ; }
Quoted 6 lines · On Tue, Feb 11, 2025 at 10:54 AM <[email protected]> wrote:
The patch below does not apply to the 6.13-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Please apply the following prerequisite:
056d33137bf9 ("fs: prepend statmount.mnt_opts string with security_sb_mnt_opts()")
Thanks,
Miklos
Greg KH
maintainerQuoted 8 lines · Miklos Szeredi
Quoted 6 lines · On Tue, Feb 11, 2025 at 10:54 AM <[email protected]> wrote:
The patch below does not apply to the 6.13-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Quoted 4 lines
Please apply the following prerequisite:
056d33137bf9("fs: prepend statmount.mnt_opts string withsecurity_sb_mnt_opts()")
That worked, thanks!
greg k-h