drm/msm/dp: Fix Type-C Timing
v2 cover drm/msm/dp: Fix Type-C Timing
SDM845 Type-C DisplayPort output inactive on DP Monitor and tears on HDMI.
During testing and research found that the dp and dpu drivers more closely match later incarnations of the Android driver. Compared against the 4.9 Android and found the porch timing and wide bus elements were disabled.
Tested by commenting out code and the graphical glitches on HDMI improved.
Fully turning off wide_bus resolved the single vertical line and vblank errors when using non-native resolutions.
Removing the porch adjustment fixed HDMI and DisplayPort operated correctly (for the first time) for all monitor supported resolutions.
Changes v1:
- Patch 1/2: Separated the descriptor from the sc7180 and turned off wide_bus support.
- Patch 2/2: Removed porch timing adjustment.
Changes v2:
- Patch 1/2: Removed unneeded assignment. Increased verbosity of commit message.
- Patch 2/2: Added comments to explain use of wide_bus_en. Increased verbosity of commit message.
Verified functionality on SDM845 using Lantronix SOM. Tested with Type-C to DisplayPort and Dell Monitor. Tested with Type-C hub with HDMI to Samsung 4k TV.
James A. MacInnes (2):
drm/msm/dp: Disable wide bus support for SDM845
drm/msm/disp: Correct porch timing for SDM845
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 ++++---- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 2 files changed, 10 insertions(+), 5 deletions(-)
--
2.43.0
---
James A. MacInnes (2):
drm/msm/dp: Disable wide bus support for SDM845 drm/msm/disp: Correct porch timing for SDM845
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++----- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 2 files changed, 15 insertions(+), 6 deletions(-)
---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250212-sdm845_dp-6ed993977a53
Best regards,
Signature · 1 line
James A. MacInnes <[email protected]>
PATCH v2 1/2 drm/msm/dp: Disable wide bus support for SDM845
SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable wide_bus operation did not take into account the SDM845 and it got carried over by accident.
- Incorrect setting caused inoperable DisplayPort.
- Corrected by separating SDM845 into its own descriptor.
--- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/dp/dp_display.c +6 -1
@@ -126,6 +126,11 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = { {} }; +static const struct msm_dp_desc msm_dp_desc_sdm845[] = { + { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 }, + {} +}; +static const struct msm_dp_desc msm_dp_desc_sc7180[] = { { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 , .wide_bus_supported = true }, {}
@@ -178,7 +183,7 @@ static const struct of_device_id msm_dp_dt_match[] = { { .compatible = "qcom,sc8180x-edp", .data = &msm_dp_desc_sc8180x }, { .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp }, { .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp }, - { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sc7180 }, + { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 }, { .compatible = "qcom,sm8350-dp", .data = &msm_dp_desc_sc7180 }, { .compatible = "qcom,sm8650-dp", .data = &msm_dp_desc_sm8650 }, { .compatible = "qcom,x1e80100-dp", .data = &msm_dp_desc_x1e80100 },
Signature · 1 line
2.43.0
Marijn Suijten
reviewerRe: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845
Quoted 6 lines · James A. MacInnes
SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable
wide_busoperation did not take into account the SDM845 and it got carried over by accident.- Incorrect setting caused inoperable DisplayPort.
- Corrected by separating SDM845 into its own descriptor.
If anything I'd have appreciated to see our conversation in v1 pasted here verbatim which is of the right verbosity to explain this. I can't do much with a list of two items.
I don't have a clearer way of explaining what all I find confusing about this description, so let me propose what I would have written if this was my patch instead:
When widebus was enabled for DisplayPort in commit c7c412202623 ("drm/msm/dp:
enable widebus on all relevant chipsets") it was clarified that it is only supported on DPU 5.0.0 onwards which includes SC7180 on DPU revision 6.2. However, this patch missed that the description structure for SC7180 is also reused for SDM845 (because of identical io_start address) which is only DPU 4.0.0, leading to a wrongly enbled widebus feature and corruption on that platform.
Create a separate msm_dp_desc_sdm845 structure for this SoC compatible, with the wide_bus_supported flag turned off.
Note that no other DisplayPort compatibles currently exist for SoCs older than DPU 4.0.0 besides SDM845.
Hope I'm not considered being too picky. I first sketch **how** the original patch created a problem, then explain how this patch is intending to fix it, and finally describe that we went a step further and ensured no other SoCs are suffering from a similar problem.
- Marijn
Quoted 36 lines
Fixes c7c412202623 ("drm/msm/dp: enable widebus on all relevant chipsets")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/dp/dp_display.c +6
-1@@ -126,6 +126,11 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = { {} }; +static const struct msm_dp_desc msm_dp_desc_sdm845[] = { + { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 }, + {} +}; +static const struct msm_dp_desc msm_dp_desc_sc7180[] = { { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 , .wide_bus_supported = true }, {}@@ -178,7 +183,7 @@ static const struct of_device_id msm_dp_dt_match[] = { { .compatible = "qcom,sc8180x-edp", .data = &msm_dp_desc_sc8180x }, { .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp }, { .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp }, - { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sc7180 }, + { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 }, { .compatible = "qcom,sm8350-dp", .data = &msm_dp_desc_sc7180 }, { .compatible = "qcom,sm8650-dp", .data = &msm_dp_desc_sm8650 }, { .compatible = "qcom,x1e80100-dp", .data = &msm_dp_desc_x1e80100 },Signature · 2 lines
-- 2.43.0
Dmitry Baryshkov
Reviewed-byRe: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845
Quoted 24 lines · Marijn Suijten
Quoted 6 lines · James A. MacInnes
SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable
wide_busoperation did not take into account the SDM845 and it got carried over by accident.- Incorrect setting caused inoperable DisplayPort.
- Corrected by separating SDM845 into its own descriptor.If anything I'd have appreciated to see our conversation in v1 pasted here verbatim which is of the right verbosity to explain this. I can't do much with a list of two items.
I don't have a clearer way of explaining what all I find confusing about this description, so let me propose what I would have written if this was my patch instead:
When widebus was enabled for DisplayPort in commit
c7c412202623("drm/msm/dp:
enable widebus on all relevant chipsets") it was clarified that it is only supported on DPU 5.0.0 onwards which includes SC7180 on DPU revision 6.2. However, this patch missed that the description structure for SC7180 is also reused for SDM845 (because of identicalio_startaddress) which is only DPU 4.0.0, leading to a wrongly enbled widebus feature and corruption on that platform.
Quoted 5 lines
Create a separate
msm_dp_desc_sdm845structure for this SoC compatible, with thewide_bus_supportedflag turned off.Note that no other DisplayPort compatibles currently exist for SoCs older than DPU 4.0.0 besides SDM845.
With more or less similar commit message:
Quoted 44 lines
Hope I'm not considered being too picky. I first sketch **how** the original patch created a problem, then explain how this patch is intending to fix it, and finally describe that we went a step further and ensured no other SoCs are suffering from a similar problem.
- Marijn
Quoted 36 lines
Fixes c7c412202623 ("drm/msm/dp: enable widebus on all relevant chipsets")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/dp/dp_display.c +6
-1@@ -126,6 +126,11 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = { {} }; +static const struct msm_dp_desc msm_dp_desc_sdm845[] = { + { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 }, + {} +}; +static const struct msm_dp_desc msm_dp_desc_sc7180[] = { { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 , .wide_bus_supported = true }, {}@@ -178,7 +183,7 @@ static const struct of_device_id msm_dp_dt_match[] = { { .compatible = "qcom,sc8180x-edp", .data = &msm_dp_desc_sc8180x }, { .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp }, { .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp }, - { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sc7180 }, + { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 }, { .compatible = "qcom,sm8350-dp", .data = &msm_dp_desc_sc7180 }, { .compatible = "qcom,sm8650-dp", .data = &msm_dp_desc_sm8650 }, { .compatible = "qcom,x1e80100-dp", .data = &msm_dp_desc_x1e80100 },Signature · 2 lines
-- 2.43.0
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845
Quoted 29 lines · On Thu, 13 Feb 2025 01:58:06 +0200 Dmitry Baryshkov…
Quoted 28 lines · Marijn Suijten
Quoted 6 lines · James A. MacInnes
SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable
wide_busoperation did not take into account the SDM845 and it got carried over by accident.- Incorrect setting caused inoperable DisplayPort.
- Corrected by separating SDM845 into its own descriptor.If anything I'd have appreciated to see our conversation in v1 pasted here verbatim which is of the right verbosity to explain this. I can't do much with a list of two items.
I don't have a clearer way of explaining what all I find confusing about this description, so let me propose what I would have written if this was my patch instead:
When widebus was enabled for DisplayPort in commit
c7c412202623("drm/msm/dp: enable widebus on all relevant chipsets") it was clarified that it is only supported on DPU 5.0.0 onwards which includes SC7180 on DPU revision 6.2. However, this patch missed that the description structure for SC7180 is also reused for SDM845 (because of identicalio_startaddress) which is only DPU 4.0.0, leading to a wrongly enbled widebus feature and corruption on that platform.Create a separate
msm_dp_desc_sdm845structure for this SoC
compatible, with thewide_bus_supportedflag turned off.
Quoted 18 lines
Quoted 2 lines
Note that no other DisplayPort compatibles currently exist
for SoCs older than DPU 4.0.0 besides SDM845.With more or less similar commit message:
Reviewed-by Dmitry Baryshkov <[email protected]>Quoted 9 lines
Hope I'm not considered being too picky. I first sketch **how** the original patch created a problem, then explain how this patch is intending to fix it, and finally describe that we went a step further and ensured no other SoCs are suffering from a similar problem.
- Marijn
Not too picky at all. I will use your text. I apologize as I had changed the cover instead of the patch. I will do my best to balance too many words and not enough.
Would it be appropriate to split this patch and the other into separate submissions?
Thank you again.
- James
Quoted 40 lines
Quoted 39 lines
Quoted 39 lines
Fixes c7c412202623 ("drm/msm/dp: enable widebus on all relevantchipsets") Signed-off-by: James A. MacInnes
<[email protected]> ---drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/msm/dp/dp_display.cindexaff51bb973eb..e30cccd63910100644 ---a/drivers/gpu/drm/msm/dp/dp_display.c+++b/drivers/gpu/drm/msm/dp/dp_display.c@@ -126,6 +126,11 @@ static const structmsm_dp_descmsm_dp_desc_sa8775p[] = { {}
};drivers/gpu/drm/msm/dp/dp_display.c +5
-0+static const struct msm_dp_desc msm_dp_desc_sdm845[] = { + { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 }, + {} +}; +static const struct msm_dp_desc msm_dp_desc_sc7180[] = { { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 ,.wide_bus_supported = true }, {}
(quoted diff) +0
-0@@ -178,7 +183,7 @@ static const struct of_device_idmsm_dp_dt_match[] = { { .compatible = "qcom,sc8180x-edp", .data =
&msm_dp_desc_sc8180x}, { .compatible = "qcom,sc8280xp-dp", .data =&msm_dp_desc_sc8280xp}, { .compatible = "qcom,sc8280xp-edp", .data =&msm_dp_desc_sc8280xp},(quoted diff) +0
-1- { .compatible = "qcom,sdm845-dp", .data =
&msm_dp_desc_sc7180},(quoted diff) +1
-0+ { .compatible = "qcom,sdm845-dp", .data =
&msm_dp_desc_sdm845}, { .compatible = "qcom,sm8350-dp", .data =&msm_dp_desc_sc7180}, { .compatible = "qcom,sm8650-dp", .data =&msm_dp_desc_sm8650}, { .compatible = "qcom,x1e80100-dp", .data =&msm_dp_desc_x1e80100},Signature · 1 line
2.43.0
Abhinav Kumar
Reviewed-byRe: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845
In reply to Marijn SuijtenQuoted 24 lines · Marijn Suijten
Quoted 6 lines · James A. MacInnes
SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable
wide_busoperation did not take into account the SDM845 and it got carried over by accident.- Incorrect setting caused inoperable DisplayPort.
- Corrected by separating SDM845 into its own descriptor.If anything I'd have appreciated to see our conversation in v1 pasted here verbatim which is of the right verbosity to explain this. I can't do much with a list of two items.
I don't have a clearer way of explaining what all I find confusing about this description, so let me propose what I would have written if this was my patch instead:
When widebus was enabled for DisplayPort in commit
c7c412202623("drm/msm/dp:
enable widebus on all relevant chipsets") it was clarified that it is only supported on DPU 5.0.0 onwards which includes SC7180 on DPU revision 6.2. However, this patch missed that the description structure for SC7180 is also reused for SDM845 (because of identicalio_startaddress) which is only DPU 4.0.0, leading to a wrongly enbled widebus feature and corruption on that platform.
Quoted 6 lines
Create a separate
msm_dp_desc_sdm845structure for this SoC compatible, with thewide_bus_supportedflag turned off.Note that no other DisplayPort compatibles currently exist for SoCs older than DPU 4.0.0 besides SDM845.
Yes, this is good description. Thanks Marijn!
Quoted 7 lines
Hope I'm not considered being too picky. I first sketch **how** the original patch created a problem, then explain how this patch is intending to fix it, and finally describe that we went a step further and ensured no other SoCs are suffering from a similar problem.
- Marijn
Its indeed a bug introduced due to msm_dp_desc_sc7180 re-use. There is no widebus on this chipset.
With the commit text fixed like above,
Quoted 36 lines
Quoted 36 lines
Fixes c7c412202623 ("drm/msm/dp: enable widebus on all relevant chipsets")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/dp/dp_display.c +6
-1@@ -126,6 +126,11 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = { {} }; +static const struct msm_dp_desc msm_dp_desc_sdm845[] = { + { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 }, + {} +}; +static const struct msm_dp_desc msm_dp_desc_sc7180[] = { { .io_start =0x0ae90000 , .id =MSM_DP_CONTROLLER_0 , .wide_bus_supported = true }, {}@@ -178,7 +183,7 @@ static const struct of_device_id msm_dp_dt_match[] = { { .compatible = "qcom,sc8180x-edp", .data = &msm_dp_desc_sc8180x }, { .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp }, { .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp }, - { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sc7180 }, + { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 }, { .compatible = "qcom,sm8350-dp", .data = &msm_dp_desc_sc7180 }, { .compatible = "qcom,sm8650-dp", .data = &msm_dp_desc_sm8650 }, { .compatible = "qcom,x1e80100-dp", .data = &msm_dp_desc_x1e80100 },Signature · 2 lines
-- 2.43.0
PATCH v2 2/2 drm/msm/disp: Correct porch timing for SDM845
In reply to James A. MacInnesType-C DisplayPort inoperable due to incorrect porch settings.
- Re-used wide_bus_en as flag to prevent porch shifting
--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +9 -5
@@ -94,17 +94,21 @@ static void drm_mode_to_intf_timing_params( timing->vsync_polarity =0 ; } -/* for DP/EDP, Shift timings to align it to bottom right */ -if (phys_enc->hw_intf->cap->type ==INTF_DP ) { + timing->wide_bus_en =dpu_encoder_is_widebus_enabled (phys_enc->parent); + timing->compression_en =dpu_encoder_is_dsc_enabled (phys_enc->parent); + +/* +* For DP/EDP, Shift timings to align it to bottom right. +* wide_bus_en is set for everything excluding SDM845 & +* porch changes cause DisplayPort failure and HDMI tearing. +*/ +if (phys_enc->hw_intf->cap->type ==INTF_DP && timing->wide_bus_en) { timing->h_back_porch += timing->h_front_porch; timing->h_front_porch =0 ; timing->v_back_porch += timing->v_front_porch; timing->v_front_porch =0 ; } - timing->wide_bus_en =dpu_encoder_is_widebus_enabled (phys_enc->parent); - timing->compression_en =dpu_encoder_is_dsc_enabled (phys_enc->parent); -/* * for DP, divide the horizonal parameters by 2 when * widebus is enabled
Signature · 1 line
2.43.0
Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845
Quoted 2 lines · James A. MacInnes
Type-C DisplayPort inoperable due to incorrect porch settings.
- Re-usedwide_bus_enas flag to prevent porch shifting
Unfortunately I don't know enough details to comment on this change. Maybe Abhinav can check it. I can only notice that msm-4.14 disables programmable_fetch_config for non-DSI calls. Would disabling that call for DP interface fix your issue?
Quoted 42 lines
Fixes c943b4948b58 ("drm/msm/dp: add displayPort driver support")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +9
-5@@ -94,17 +94,21 @@ static void drm_mode_to_intf_timing_params( timing->vsync_polarity =0 ; } -/* for DP/EDP, Shift timings to align it to bottom right */ -if (phys_enc->hw_intf->cap->type ==INTF_DP ) { + timing->wide_bus_en =dpu_encoder_is_widebus_enabled (phys_enc->parent); + timing->compression_en =dpu_encoder_is_dsc_enabled (phys_enc->parent); + +/* +* For DP/EDP, Shift timings to align it to bottom right. +* wide_bus_en is set for everything excluding SDM845 & +* porch changes cause DisplayPort failure and HDMI tearing. +*/ +if (phys_enc->hw_intf->cap->type ==INTF_DP && timing->wide_bus_en) { timing->h_back_porch += timing->h_front_porch; timing->h_front_porch =0 ; timing->v_back_porch += timing->v_front_porch; timing->v_front_porch =0 ; } - timing->wide_bus_en =dpu_encoder_is_widebus_enabled (phys_enc->parent); - timing->compression_en =dpu_encoder_is_dsc_enabled (phys_enc->parent); -/* * for DP, divide the horizonal parameters by 2 when * widebus is enabled Signature · 2 lines
-- 2.43.0
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845
Quoted 9 lines · Dmitry Baryshkov
Quoted 2 lines · James A. MacInnes
Type-C DisplayPort inoperable due to incorrect porch settings.
- Re-usedwide_bus_enas flag to prevent porch shiftingUnfortunately I don't know enough details to comment on this change. Maybe Abhinav can check it. I can only notice that msm-4.14 disables
programmable_fetch_configfor non-DSI calls. Would disabling that call for DP interface fix your issue?
Yes, this piece of timing adjustment matches what we have even without widebus.
I do agree about the programmable fetch that it is enabled only on DSI even on the latest kernels.
698 if (phys_enc->hw_intf->cap->type == INTF_DSI)
699 programmable_fetch_config(phys_enc, &timing_params);
We can try if that works.
Quoted 43 lines
Quoted 42 lines
Fixes c943b4948b58 ("drm/msm/dp: add displayPort driver support")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +9
-5@@ -94,17 +94,21 @@ static void drm_mode_to_intf_timing_params( timing->vsync_polarity =0 ; } -/* for DP/EDP, Shift timings to align it to bottom right */ -if (phys_enc->hw_intf->cap->type ==INTF_DP ) { + timing->wide_bus_en =dpu_encoder_is_widebus_enabled (phys_enc->parent); + timing->compression_en =dpu_encoder_is_dsc_enabled (phys_enc->parent); + +/* +* For DP/EDP, Shift timings to align it to bottom right. +* wide_bus_en is set for everything excluding SDM845 & +* porch changes cause DisplayPort failure and HDMI tearing. +*/ +if (phys_enc->hw_intf->cap->type ==INTF_DP && timing->wide_bus_en) { timing->h_back_porch += timing->h_front_porch; timing->h_front_porch =0 ; timing->v_back_porch += timing->v_front_porch; timing->v_front_porch =0 ; } - timing->wide_bus_en =dpu_encoder_is_widebus_enabled (phys_enc->parent); - timing->compression_en =dpu_encoder_is_dsc_enabled (phys_enc->parent); -/* * for DP, divide the horizonal parameters by 2 when * widebus is enabled Signature · 2 lines
-- 2.43.0
Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845
In reply to James A. MacInnesQuoted 9 lines · James A. MacInnes
Type-C DisplayPort inoperable due to incorrect porch settings.
- Re-usedwide_bus_enas flag to prevent porch shiftingFixes c943b4948b58 ("drm/msm/dp: add displayPort driver support")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
I was able to run DP tests on SDM845. These changes are required on that platform, disabling programmable fetch is not enough.
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845
In reply to James A. MacInnesQuoted 9 lines · James A. MacInnes
Type-C DisplayPort inoperable due to incorrect porch settings.
- Re-usedwide_bus_enas flag to prevent porch shiftingFixes c943b4948b58 ("drm/msm/dp: add displayPort driver support")Signed-off-by James A. MacInnes <[email protected]>--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
Signature · 2 lines
With best wishes Dmitry