Skip to contentSkip to conversation

mm: Remove redundant PageMemcgKmem(page) call

PATCH In review Shengken Lin 2 participants 4 messages Feb 12, 2025 – Feb 20, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Remove redundant PageMemcgKmem(page) call

The function of PageMemcgKmem(page) is the same as that of folio_memcg_kmem(folio).

Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to check if a folio has been uncharged, calling PageMemcgKmem(page) before __memcg_kmem_uncharge_page is redundant.

---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
index 579789600a3c..5a76760de495 100644
@@ -1055,7 +1055,7 @@ __always_inline bool free_pages_prepare(struct page *page,
 	trace_mm_page_free(page, order);
 	kmsan_free_page(page, order);
 
-	if (memcg_kmem_online() && PageMemcgKmem(page))
+	if (memcg_kmem_online())
 		__memcg_kmem_uncharge_page(page, order);
 
 	/*

--
2.34.1

#1 lore raw
Quoted 6 lines · Shengken Lin

The function of PageMemcgKmem(page) is the same as that of folio_memcg_kmem(folio).

Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to check if a folio has been uncharged, calling PageMemcgKmem(page) before __memcg_kmem_uncharge_page is redundant.

But it saves a function call. NAK.

#2 lore raw
Quoted 9 lines · Matthew Wilcox
Quoted 6 lines · Shengken Lin

The function of PageMemcgKmem(page) is the same as that of folio_memcg_kmem(folio).

Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to check if a folio has been uncharged, calling PageMemcgKmem(page) before __memcg_kmem_uncharge_page is redundant.

But it saves a function call. NAK.

Hi Matthew Wilcox,
If it can save a function call, then adding PageMemcgKmem(page) in include/linux/memcontrol.h would make the code more consistent. If this is considered more reasonable, I can submit a new patch.

include/linux/memcontrol.h +1 -2
@@ -1707,7 +1707,7 @@ static inline int memcg_kmem_charge_page(struct page *page, gfp_t gfp,
 
 static inline void memcg_kmem_uncharge_page(struct page *page, int order)
 {
-       if (memcg_kmem_online())
+       if (memcg_kmem_online() && PageMemcgKmem(page))
                __memcg_kmem_uncharge_page(page, order);
 }
--

Best regards,
Shengken Lin

#3 lore raw
Quoted 2 lines · On Thu, Feb 20, 2025 at 05:47:56PM +0800, [email protected] wrote:

If it can save a function call, then adding PageMemcgKmem(page) in include/linux/memcontrol.h would make the code more consistent.

The code is fine the way it is.