riscv: dts: starfive: remove non-existent dac from jh7110
Subsystems (3)
Conor Dooley
maintainerPATCH 1/1 riscv: dts: starfive: remove non-existent dac from jh7110
From: Conor Dooley <[email protected]>
The jh7110 boards do not have a Rohm DAC on them as far as I can tell, and they certainly do not have a dh2228fv, as this device does not actually exist! Remove the dac nodes from the devicetrees as it is not acceptable to pretend to have a device on a board in order to bind the spidev driver in Linux.
---
CC: Emil Renner Berthing <[email protected]>
CC: Conor Dooley <[email protected]>
CC: Rob Herring <[email protected]>
CC: Krzysztof Kozlowski <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 6 ------ 1 file changed, 6 deletions(-)
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0 -6
@@ -350,12 +350,6 @@ &pwm { &spi0 { pinctrl-names = "default"; pinctrl-0 = <&spi0_pins>; - - spi_dev0: spi@0 { - compatible = "rohm,dh2228fv"; - reg = <0>; - spi-max-frequency = <10000000>; - }; }; &syscrg {
Signature · 1 line
2.45.2
Quoted 9 lines · Conor Dooley
From: Conor Dooley <[email protected]>
The jh7110 boards do not have a Rohm DAC on them as far as I can tell, and they certainly do not have a dh2228fv, as this device does not actually exist! Remove the dac nodes from the devicetrees as it is not acceptable to pretend to have a device on a board in order to bind the spidev driver in Linux.
Signed-off-by Conor Dooley <[email protected]>
Hmm.. I thought we already did this, but it must have been another board. In any case
Thanks!
/Emil
Quoted 32 lines
---
CC: Emil Renner Berthing <[email protected]>
CC: Conor Dooley <[email protected]>
CC: Rob Herring <[email protected]>
CC: Krzysztof Kozlowski <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]--- arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 6 ------ 1 file changed, 6 deletions(-)arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0
-7@@ -350,12 +350,6 @@ &pwm { &spi0 { pinctrl-names = "default"; pinctrl-0 = <&spi0_pins>; - - spi_dev0: spi@0 { - compatible = "rohm,dh2228fv"; - reg = <0>; - spi-max-frequency = <10000000>; - }; }; &syscrg { --2.45.2
From: Conor Dooley <[email protected]>
Quoted 8 lines · Conor Dooley
The jh7110 boards do not have a Rohm DAC on them as far as I can tell, and they certainly do not have a dh2228fv, as this device does not actually exist! Remove the dac nodes from the devicetrees as it is not acceptable to pretend to have a device on a board in order to bind the spidev driver in Linux.
[...]
Applied to riscv-dt-for-next, thanks!
[1/1] riscv: dts: starfive: remove non-existent dac from jh7110
https://git.kernel.org/conor/c/4bdea6e33946
Thanks,
Conor.