ACPI: OSL: ratelimit ACPICA kernel messages
PATCH 1/1 ACPI: OSL: ratelimit ACPICA kernel messages
In cases where the ACPI AML contains errors there can be quite a large amount of ACPICA kernel log spamming. Reduce this by rate limiting the messages.
--- drivers/acpi/osl.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)
drivers/acpi/osl.c +12 -8
@@ -159,17 +159,21 @@ void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args)if (acpi_in_debugger) {kdb_printf ("%s" , buffer); }else { -if (printk_get_level (buffer)) -printk ("%s" , buffer); -else -printk (KERN_CONT "%s" , buffer); +if (printk_ratelimit ()) { +if (printk_get_level (buffer)) +printk ("%s" , buffer); +else +printk (KERN_CONT "%s" , buffer); + } }#else if (acpi_debugger_write_log (buffer) <0 ) { -if (printk_get_level (buffer)) -printk ("%s" , buffer); -else -printk (KERN_CONT "%s" , buffer); +if (printk_ratelimit ()) { +if (printk_get_level (buffer)) +printk ("%s" , buffer); +else +printk (KERN_CONT "%s" , buffer); + } }#endif }
Signature · 1 line
2.47.2
Rafael J. Wysocki
maintainer+Saket Dumbre
Quoted 3 lines · Colin Ian King
In cases where the ACPI AML contains errors there can be quite a large amount of ACPICA kernel log spamming.
Except when someone wants to see them all which also happens.
And wouldn't this also rate limit debug messages from ACPICA specifically enabled via the kernel command line?
If so, I'd rather find a way to tell ACPICA to be less verbose.
Quoted 42 lines
Reduce this by rate limiting the messages.
Signed-off-by Colin Ian King <[email protected]>--- drivers/acpi/osl.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)drivers/acpi/osl.c +12
-9@@ -159,17 +159,21 @@ void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args)if (acpi_in_debugger) {kdb_printf ("%s" , buffer); }else { -if (printk_get_level (buffer)) -printk ("%s" , buffer); -else -printk (KERN_CONT "%s" , buffer); +if (printk_ratelimit ()) { +if (printk_get_level (buffer)) +printk ("%s" , buffer); +else +printk (KERN_CONT "%s" , buffer); + } }#else if (acpi_debugger_write_log (buffer) <0 ) { -if (printk_get_level (buffer)) -printk ("%s" , buffer); -else -printk (KERN_CONT "%s" , buffer); +if (printk_ratelimit ()) { +if (printk_get_level (buffer)) +printk ("%s" , buffer); +else +printk (KERN_CONT "%s" , buffer); + } }#endif } --
Quoted 7 lines · Rafael J. Wysocki
+Saket Dumbre
Quoted 3 lines · Colin Ian King
In cases where the ACPI AML contains errors there can be quite a large amount of ACPICA kernel log spamming.
Quoted 6 lines
Except when someone wants to see them all which also happens.
And wouldn't this also rate limit debug messages from ACPICA specifically enabled via the kernel command line?
If so, I'd rather find a way to tell ACPICA to be less verbose.
Yep, makes sense Rafael. The crux of the matter is that there should be some way to reduce repeated identical "ACPI BIOS Error" messages, especially when the AML is triggering this 10+ times a second :-)
Colin
Quoted 43 lines
Quoted 43 lines
Reduce this by rate limiting the messages.
Signed-off-by Colin Ian King <[email protected]>--- drivers/acpi/osl.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)drivers/acpi/osl.c +12
-9@@ -159,17 +159,21 @@ void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args)if (acpi_in_debugger) {kdb_printf ("%s" , buffer); }else { -if (printk_get_level (buffer)) -printk ("%s" , buffer); -else -printk (KERN_CONT "%s" , buffer); +if (printk_ratelimit ()) { +if (printk_get_level (buffer)) +printk ("%s" , buffer); +else +printk (KERN_CONT "%s" , buffer); + } }#else if (acpi_debugger_write_log (buffer) <0 ) { -if (printk_get_level (buffer)) -printk ("%s" , buffer); -else -printk (KERN_CONT "%s" , buffer); +if (printk_ratelimit ()) { +if (printk_get_level (buffer)) +printk ("%s" , buffer); +else +printk (KERN_CONT "%s" , buffer); + } }#endif } --