misc: pci_endpoint_test: Fix potential truncation in pci_endpoint_test_probe()
Subsystems (3)
PATCH 1/1 misc: pci_endpoint_test: Fix potential truncation in pci_endpoint_test_probe()
Increase the size of the string buffer to avoid potential truncation in pci_endpoint_test_probe().
This fixes the following build warning when compiling with W=1:
drivers/misc/pci_endpoint_test.c:29:49: note: directive argument in the range [0, 2147483647]
29 | #define DRV_MODULE_NAME "pci-endpoint-test"
| ^~~~~~~~~~~~~~~~~~~
drivers/misc/pci_endpoint_test.c:998:38: note: in expansion of macro ‘DRV_MODULE_NAME’
998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id);
| ^~~~~~~~~~~~~~~
drivers/misc/pci_endpoint_test.c:998:9: note: ‘snprintf’ output between 20 and 29 bytes into a destination of size 24
998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~--- drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/pci_endpoint_test.c +1 -1
@@ -912,7 +912,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, {int ret;int id; -char name[24 ]; +char name[29 ];enum pci_barno bar;void __iomem *base;struct device *dev = &pdev->dev;
Signature · 1 line
2.48.1
Quoted 15 lines · Niklas Cassel
Increase the size of the string buffer to avoid potential truncation in
pci_endpoint_test_probe().This fixes the following build warning when compiling with W=1:
drivers/misc/pci_endpoint_test.c:29:49: note: directive argument in the range [0, 2147483647]29 | #define DRV_MODULE_NAME "pci-endpoint-test" | ^~~~~~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:38: note: in expansion of macro ‘DRV_MODULE_NAME’ 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:9: note: ‘snprintf’ output between 20 and 29 bytes into a destination of size 24 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 2 lines
Signed-off-by Niklas Cassel <[email protected]>---
Quoted 19 lines
drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/pci_endpoint_test.c +1
-2@@ -912,7 +912,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, {int ret;int id; -char name[24 ]; +char name[29 ];enum pci_barno bar;void __iomem *base;struct device *dev = &pdev->dev; --2.48.1
Quoted 15 lines · Niklas Cassel
Increase the size of the string buffer to avoid potential truncation in
pci_endpoint_test_probe().This fixes the following build warning when compiling with W=1:
drivers/misc/pci_endpoint_test.c:29:49: note: directive argument in the range [0, 2147483647]29 | #define DRV_MODULE_NAME "pci-endpoint-test" | ^~~~~~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:38: note: in expansion of macro ‘DRV_MODULE_NAME’ 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:9: note: ‘snprintf’ output between 20 and 29 bytes into a destination of size 24 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 1 line
Signed-off-by Niklas Cassel <[email protected]>
- Mani
Quoted 20 lines
--- drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/pci_endpoint_test.c +1
-1@@ -912,7 +912,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, {int ret;int id; -char name[24 ]; +char name[29 ];enum pci_barno bar;void __iomem *base;struct device *dev = &pdev->dev;Signature · 1 line
2.48.1
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Quoted 36 lines · Niklas Cassel
Increase the size of the string buffer to avoid potential truncation in
pci_endpoint_test_probe().This fixes the following build warning when compiling with W=1:
drivers/misc/pci_endpoint_test.c:29:49: note: directive argument in the range [0, 2147483647]29 | #define DRV_MODULE_NAME "pci-endpoint-test" | ^~~~~~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:38: note: in expansion of macro ‘DRV_MODULE_NAME’ 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:9: note: ‘snprintf’ output between 20 and 29 bytes into a destination of size 24 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Signed-off-by Niklas Cassel <[email protected]>--- drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/pci_endpoint_test.c +1
-1@@ -912,7 +912,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, {int ret;int id; -char name[24 ]; +char name[29 ];enum pci_barno bar;void __iomem *base;struct device *dev = &pdev->dev;Signature · 1 line
2.48.1
Gentle ping.
Kind regards,
Niklas
Manivannan Sadhasivam
AppliedQuoted 15 lines · Niklas Cassel
Increase the size of the string buffer to avoid potential truncation in
pci_endpoint_test_probe().This fixes the following build warning when compiling with W=1:
drivers/misc/pci_endpoint_test.c:29:49: note: directive argument in the range [0, 2147483647]29 | #define DRV_MODULE_NAME "pci-endpoint-test" | ^~~~~~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:38: note: in expansion of macro ‘DRV_MODULE_NAME’ 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~ drivers/misc/pci_endpoint_test.c:998:9: note: ‘snprintf’ output between 20 and 29 bytes into a destination of size 24 998 | snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 1 line
Signed-off-by Niklas Cassel <[email protected]>
Applied to pci/endpoint!
- Mani
Quoted 20 lines
--- drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/pci_endpoint_test.c +1
-1@@ -912,7 +912,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, {int ret;int id; -char name[24 ]; +char name[29 ];enum pci_barno bar;void __iomem *base;struct device *dev = &pdev->dev;Signature · 1 line
2.48.1
Signature · 1 line
மணிவண்ணன் சதாசிவம்