Add character devices for indices, platform-dump
Subsystems (2)
v6 cover Add character devices for indices, platform-dump
Several APIs such as rtas_get_indices(), rtas_get_dynamic_sensor(), rtas_set_dynamic_indicator(), rtas_platform_dump() and rtas_physical_attestation() provided by librtas library are implemented in user space using rtas syscall in combination with writable mappings of /dev/mem. But this implementation is not compatible with system lockdown which prohibits /dev/mem access. The current kernel already provides char based driver interfaces for several RTAS calls such as VPD and system parameters to support lockdown feature.
This patch series adds new char based drivers, /dev/papr-indices for ibm,get-indices, ibm,get-dynamic-sensor-state and ibm,set-dynamic-indicator RTAS Calls. /dev/papr-platform-dump for ibm,platform-dump and /dev/papr-physical-attestation fir ibm,physical-attestation. Providing the similar open/ioctl/read interfaces to the user space as in the case of VPD and system parameters.
I have made changes to librtas library to use the new kernel interfaces if the corresponding device entry is available.
This patch series has the following patches:
powerpc/pseries: Define common functions for RTAS sequence calls
- For some of sequence based RTAS calls, the OS should not start another sequence with different input until the previous sequence is completed. So the sequence should be completed during ioctl() and expose the entire buffer during read(). ibm,get-indices is sequence based RTAS function similar to ibm,get-vpd and we already have the corresponding implementation for VPD driver. So update papr_rtas_sequence struct for RTAS call specific functions and move the top level sequence functions in to a separate file.
powerpc/pseries: Define papr_indices_io_block for papr-indices ioctls
- /dev/papr-indices driver supports ibm,get-indices, ibm,get-dynamic-sensor-state and ibm,set-dynamic-indicator RTAS Calls. papr-indices.h introduces 3 different ioctls for these RTAS calls and the corresponding ioctl input buffer.
powerpc/pseries: Add papr-indices char driver for ibm,get-indices
- Introduce /dev/papr-indices char based driver and add support for get-indices RTAS function
powerpc/pseries: Add ibm,set-dynamic-indicator RTAS call support
- Update /dev/papr-indices for set-dynamic-indicator RTAS function
powerpc/pseries: Add ibm,get-dynamic-sensor-state RTAS call support
- Update /dev/papr-indices for get-dynamic-sensor-state RTAS function
powerpc/pseries: Add papr-platform-dump character driver for dump
retrieval
- Introduce /dev/papr-platform-dump char driver and adds support for ibm,platform-dump. Received suggestions from the previous post as a separate patch - Updated the patch with invalidating the dump using a separate ioctl.
powerpc/pseries: Add a char driver for papr-physical-attestation RTAS
- Introduce /dev/papr-physical-attestation char driver to provide kernel interface for ibm,physical-attestation RTAS function.
Changelog:
v6:
- Define the proper command ID for PAPR_PHY_ATTEST_IOC_HANDLE ioctl
- Update ioctls description in ioctl-number.rst.
v5:
- Return with -EINPROGRESS in papr_platform_dump_invalidate_ioctl() if the complete dump is not read (Suggested by Michal Suchánek).
v4:
- Include patch "Add char driver for papr-physical-attestation RTAS" in this series. ibm,physical-attestation is sequence based RTAS call and the implementation is also similar to ibm,get-vpd and ibm,get-indices.
v3:
- put_unused_fd() only after get_unused_fd() successful for the failure case later ("Add papr-platform-dump character driver for dump retrieval" patch).
v2:
- Added unlock rtas_ibm_set_dynamic_indicator_lock and rtas_ibm_get_dynamic_sensor_state_lock mutex for failure cases as reported by Dan Carpenter
- Fixed build warnings for the proper function parameter descriptions as reported by kernel test robot <[email protected]>
Haren Myneni (7):
powerpc/pseries: Define common functions for RTAS sequence calls powerpc/pseries: Define papr_indices_io_block for papr-indices ioctls powerpc/pseries: Add papr-indices char driver for ibm,get-indices powerpc/pseries: Add ibm,set-dynamic-indicator RTAS call support powerpc/pseries: Add ibm,get-dynamic-sensor-state RTAS call support powerpc/pseries: Add papr-platform-dump character driver for dump
retrieval
powerpc/pseries: Add a char driver for physical-attestation RTAS
.../userspace-api/ioctl/ioctl-number.rst | 6 + arch/powerpc/include/asm/rtas.h | 4 + arch/powerpc/include/uapi/asm/papr-indices.h | 41 ++ .../uapi/asm/papr-physical-attestation.h | 31 ++ .../include/uapi/asm/papr-platform-dump.h | 15 + arch/powerpc/kernel/rtas.c | 8 +- arch/powerpc/platforms/pseries/Makefile | 3 +- arch/powerpc/platforms/pseries/papr-indices.c | 488 ++++++++++++++++++ .../platforms/pseries/papr-phy-attest.c | 287 ++++++++++ .../platforms/pseries/papr-platform-dump.c | 411 +++++++++++++++ .../platforms/pseries/papr-rtas-common.c | 313 +++++++++++ .../platforms/pseries/papr-rtas-common.h | 61 +++ arch/powerpc/platforms/pseries/papr-vpd.c | 350 ++----------- 13 files changed, 1706 insertions(+), 312 deletions(-) create mode 100644 arch/powerpc/include/uapi/asm/papr-indices.h create mode 100644 arch/powerpc/include/uapi/asm/papr-physical-attestation.h create mode 100644 arch/powerpc/include/uapi/asm/papr-platform-dump.h create mode 100644 arch/powerpc/platforms/pseries/papr-indices.c create mode 100644 arch/powerpc/platforms/pseries/papr-phy-attest.c create mode 100644 arch/powerpc/platforms/pseries/papr-platform-dump.c create mode 100644 arch/powerpc/platforms/pseries/papr-rtas-common.c create mode 100644 arch/powerpc/platforms/pseries/papr-rtas-common.h
Signature · 1 line
2.43.5
PATCH v6 1/7 powerpc/pseries: Define common functions for RTAS sequence calls
The RTAS call can be normal where retrieves the data form the hypervisor once or sequence based RTAS call which has to issue multiple times until the complete data is obtained. For some of these sequence RTAS calls, the OS should not interleave calls with different input until the sequence is completed. The data is collected for each call and copy to the buffer for the entire sequence during ioctl() handle and then expose this buffer to the user space with read() handle.
One such sequence RTAS call is ibm,get-vpd and its support is already included in the current code. To add the similar support for other sequence based calls, move the common functions in to separate file and update papr_rtas_sequence struct with the following callbacks so that RTAS call specific code will be defined and executed to complete the sequence.
struct papr_rtas_sequence {
int error;
void params;
void (*begin) (struct papr_rtas_sequence *);
void (*end) (struct papr_rtas_sequence *);
const char * (*work) (struct papr_rtas_sequence *, size_t *);
};params: Input parameters used to pass for RTAS call.
Begin: RTAS call specific function to initialize data
including work area allocation.
End: RTAS call specific function to free up resources
(free work area) after the sequence is completed.
Work: The actual RTAS call specific function which collects
the data from the hypervisor.
--- arch/powerpc/platforms/pseries/Makefile | 2 +- .../platforms/pseries/papr-rtas-common.c | 313 ++++++++++++++++ .../platforms/pseries/papr-rtas-common.h | 61 +++ arch/powerpc/platforms/pseries/papr-vpd.c | 350 +++--------------- 4 files changed, 418 insertions(+), 308 deletions(-) create mode 100644 arch/powerpc/platforms/pseries/papr-rtas-common.c create mode 100644 arch/powerpc/platforms/pseries/papr-rtas-common.h
arch/powerpc/platforms/pseries/Makefile +1 -1
@@ -3,7 +3,7 @@ ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG obj-y := lpar.o hvCall.o nvram.o reconfig.o \ of_helpers.o rtas-work-area.o papr-sysparm.o \ - papr-vpd.o \ + papr-rtas-common.o papr-vpd.o \ setup.o iommu.o event_sources.o ras.o \ firmware.o power.o dlpar.o mobility.o rng.o \ pci.o pci_dlpar.o eeh_pseries.o msi.o \
arch/powerpc/platforms/pseries/papr-rtas-common.c new file +313 -0
313 lines not on this page · raw message
arch/powerpc/platforms/pseries/papr-rtas-common.h new file +61 -0
61 lines not on this page · raw message
arch/powerpc/platforms/pseries/papr-vpd.c +43 -307
440 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v6 2/7 powerpc/pseries: Define papr_indices_io_block for papr-indices ioctls
In reply to Haren MyneniTo issue ibm,get-indices, ibm,set-dynamic-indicator and ibm,get-dynamic-sensor-state in the user space, the RMO buffer is allocated for the work area which is restricted under system lockdown. So instead of user space execution, the kernel will provide /dev/papr-indices interface to execute these RTAS calls.
The user space assigns data in papr_indices_io_block struct depends on the specific HCALL and passes to the following ioctls:
PAPR_INDICES_IOC_GET: Use for ibm,get-indices. Returns a
get-indices handle fd to read data.PAPR_DYNAMIC_SENSOR_IOC_GET: Use for ibm,get-dynamic-sensor-state.
Updates the sensor state in papr_indices_io_block.dynamic_param.state
PAPR_DYNAMIC_INDICATOR_IOC_SET: Use for ibm,set-dynamic-indicator.
Sets the new state for the input indicator.
--- .../userspace-api/ioctl/ioctl-number.rst | 2 + arch/powerpc/include/uapi/asm/papr-indices.h | 41 +++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 arch/powerpc/include/uapi/asm/papr-indices.h
Documentation/userspace-api/ioctl/ioctl-number.rst +2 -0
@@ -363,6 +363,8 @@ Code Seq# Include File Comments <mailto:linuxppc-dev> 0xB2 01-02 arch/powerpc/include/uapi/asm/papr-sysparm.h powerpc/pseries system parameter API <mailto:linuxppc-dev> +0xB2 03-05 arch/powerpc/include/uapi/asm/papr-indices.h powerpc/pseries indices API + <mailto:linuxppc-dev> 0xB3 00 linux/mmc/ioctl.h 0xB4 00-0F linux/gpio.h <mailto:[email protected]> 0xB5 00-0F uapi/linux/rpmsg.h <mailto:[email protected]>
arch/powerpc/include/uapi/asm/papr-indices.h new file +41 -0
41 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v6 3/7 powerpc/pseries: Add papr-indices char driver for ibm,get-indices
In reply to Haren MyneniThe RTAS call ibm,get-indices is used to obtain indices and location codes for a specified indicator or sensor token. The current implementation uses rtas_get_indices() API provided by librtas library which allocates RMO buffer and issue this RTAS call in the user space. But writable mapping /dev/mem access by the user space is prohibited under system lockdown.
To overcome the restricted access in the user space, the kernel provide interfaces to collect indices data from the hypervisor. This patch adds papr-indices character driver and expose standard interfaces such as open / ioctl/ read to user space in ways that are compatible with lockdown.
PAPR (2.13 7.3.17 ibm,get-indices RTAS Call) describes the following steps to retrieve all indices data:
- User input parameters to the RTAS call: sensor or indicator, and indice type
- ibm,get-indices is sequence RTAS call which means has to issue multiple times to get the entire list of indicators or sensors of a particular type. The hypervisor expects the first RTAS call with the sequence 1 and the subsequent calls with the sequence number returned from the previous calls.
- The OS may not interleave calls to ibm,get-indices for different indicator or sensor types. Means other RTAS calls with different type should not be issued while the previous type sequence is in progress. So collect the entire list of indices and copied to buffer BLOB during ioctl() and expose this buffer to the user space with the file descriptor.
- The hypervisor fills the work area with a specific format but does not return the number of bytes written to the buffer. Instead of parsing the data for each call to determine the data length, copy the work area size (RTAS_GET_INDICES_BUF_SIZE) to the buffer. Return work-area size of data to the user space for each read() call.
Expose these interfaces to user space with a /dev/papr-indices character device using the following programming model:
int devfd = open("/dev/papr-indices", O_RDONLY);
int fd = ioctl(devfd, PAPR_INDICES_IOC_GET,
struct papr_indices_io_block)
- Collect all indices data for the specified token to the buffer
char *buf = malloc(RTAS_GET_INDICES_BUF_SIZE);
length = read(fd, buf, RTAS_GET_INDICES_BUF_SIZE)
- RTAS_GET_INDICES_BUF_SIZE of data is returned to the user space.
- The user space retrieves the indices and their location codes from the buffer
- Should issue multiple read() calls until reaches the end of BLOB buffer.
The read() should use the file descriptor obtained from ioctl to get the data that is exposed to file descriptor. Implemented support in librtas (rtas_get_indices()) for this new ABI for system lockdown.
--- arch/powerpc/include/asm/rtas.h | 1 + arch/powerpc/kernel/rtas.c | 2 +- arch/powerpc/platforms/pseries/Makefile | 2 +- arch/powerpc/platforms/pseries/papr-indices.c | 301 ++++++++++++++++++ 4 files changed, 304 insertions(+), 2 deletions(-) create mode 100644 arch/powerpc/platforms/pseries/papr-indices.c
arch/powerpc/include/asm/rtas.h +1 -0
@@ -515,6 +515,7 @@ extern char rtas_data_buf[RTAS_DATA_BUF_SIZE];extern unsigned long rtas_rmo_buf;extern struct mutex rtas_ibm_get_vpd_lock; +extern struct mutex rtas_ibm_get_indices_lock;#define GLOBAL_INTERRUPT_QUEUE 9005
arch/powerpc/kernel/rtas.c +1 -1
@@ -93,11 +93,11 @@ struct rtas_function {*/ static DEFINE_MUTEX (rtas_ibm_activate_firmware_lock);static DEFINE_MUTEX (rtas_ibm_get_dynamic_sensor_state_lock); -static DEFINE_MUTEX (rtas_ibm_get_indices_lock);static DEFINE_MUTEX (rtas_ibm_lpar_perftools_lock);static DEFINE_MUTEX (rtas_ibm_physical_attestation_lock);static DEFINE_MUTEX (rtas_ibm_set_dynamic_indicator_lock);DEFINE_MUTEX (rtas_ibm_get_vpd_lock); +DEFINE_MUTEX (rtas_ibm_get_indices_lock);static struct rtas_function rtas_function_table[]__ro_after_init = { [RTAS_FNIDX__CHECK_EXCEPTION ] = {
arch/powerpc/platforms/pseries/Makefile +1 -1
@@ -3,7 +3,7 @@ ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG obj-y := lpar.o hvCall.o nvram.o reconfig.o \ of_helpers.o rtas-work-area.o papr-sysparm.o \ - papr-rtas-common.o papr-vpd.o \ + papr-rtas-common.o papr-vpd.o papr-indices.o \ setup.o iommu.o event_sources.o ras.o \ firmware.o power.o dlpar.o mobility.o rng.o \ pci.o pci_dlpar.o eeh_pseries.o msi.o \
arch/powerpc/platforms/pseries/papr-indices.c new file +301 -0
301 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v6 4/7 powerpc/pseries: Add ibm,set-dynamic-indicator RTAS call support
In reply to Haren MyneniThe RTAS call ibm,set-dynamic-indicator is used to set the new indicator state identified by a location code. The current implementation uses rtas_set_dynamic_indicator() API provided by librtas library which allocates RMO buffer and issue this RTAS call in the user space. But /dev/mem access by the user space is prohibited under system lockdown.
This patch provides an interface with new ioctl PAPR_DYNAMIC_INDICATOR_IOC_SET to the papr-indices character driver and expose this interface to the user space that is compatible with lockdown.
Refer PAPR 7.3.18 ibm,set-dynamic-indicator for more information on this RTAS call.
- User input parameters to the RTAS call: location code string, indicator token and new state
Expose these interfaces to user space with a /dev/papr-indices character device using the following programming model:
int fd = open("/dev/papr-indices", O_RDWR);
int ret = ioctl(fd, PAPR_DYNAMIC_INDICATOR_IOC_SET,
struct papr_indices_io_block)
- The user space passes input parameters in papr_indices_io_block struct
--- arch/powerpc/include/asm/rtas.h | 1 + arch/powerpc/kernel/rtas.c | 2 +- arch/powerpc/platforms/pseries/papr-indices.c | 120 ++++++++++++++++++ 3 files changed, 122 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/rtas.h +1 -0
@@ -516,6 +516,7 @@ extern unsigned long rtas_rmo_buf;extern struct mutex rtas_ibm_get_vpd_lock;extern struct mutex rtas_ibm_get_indices_lock; +extern struct mutex rtas_ibm_set_dynamic_indicator_lock;#define GLOBAL_INTERRUPT_QUEUE 9005
arch/powerpc/kernel/rtas.c +1 -1
@@ -95,9 +95,9 @@ static DEFINE_MUTEX(rtas_ibm_activate_firmware_lock);static DEFINE_MUTEX (rtas_ibm_get_dynamic_sensor_state_lock);static DEFINE_MUTEX (rtas_ibm_lpar_perftools_lock);static DEFINE_MUTEX (rtas_ibm_physical_attestation_lock); -static DEFINE_MUTEX (rtas_ibm_set_dynamic_indicator_lock);DEFINE_MUTEX (rtas_ibm_get_vpd_lock);DEFINE_MUTEX (rtas_ibm_get_indices_lock); +DEFINE_MUTEX (rtas_ibm_set_dynamic_indicator_lock);static struct rtas_function rtas_function_table[]__ro_after_init = { [RTAS_FNIDX__CHECK_EXCEPTION ] = {
arch/powerpc/platforms/pseries/papr-indices.c +120 -0
144 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v6 5/7 powerpc/pseries: Add ibm,get-dynamic-sensor-state RTAS call support
In reply to Haren MyneniThe RTAS call ibm,get-dynamic-sensor-state is used to get the sensor state identified by the location code and the sensor token. The librtas library provides an API rtas_get_dynamic_sensor() which uses /dev/mem access for work area allocation but is restricted under system lockdown.
This patch provides an interface with new ioctl
PAPR_DYNAMIC_SENSOR_IOC_GET to the papr-indices character
driver which executes this HCALL and copies the sensor state in the user specified ioctl buffer.
Refer PAPR 7.3.19 ibm,get-dynamic-sensor-state for more information on this RTAS call.
- User input parameters to the RTAS call: location code string and the sensor token
Expose these interfaces to user space with a /dev/papr-indices character device using the following programming model:
int fd = open("/dev/papr-indices", O_RDWR);
int ret = ioctl(fd, PAPR_DYNAMIC_SENSOR_IOC_GET,
struct papr_indices_io_block)
- The user space specifies input parameters in papr_indices_io_block struct
- Returned state for the specified sensor is copied to papr_indices_io_block.dynamic_param.state
--- arch/powerpc/include/asm/rtas.h | 1 + arch/powerpc/kernel/rtas.c | 2 +- arch/powerpc/platforms/pseries/papr-indices.c | 67 +++++++++++++++++++ 3 files changed, 69 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/rtas.h +1 -0
@@ -517,6 +517,7 @@ extern unsigned long rtas_rmo_buf;extern struct mutex rtas_ibm_get_vpd_lock;extern struct mutex rtas_ibm_get_indices_lock;extern struct mutex rtas_ibm_set_dynamic_indicator_lock; +extern struct mutex rtas_ibm_get_dynamic_sensor_state_lock;#define GLOBAL_INTERRUPT_QUEUE 9005
arch/powerpc/kernel/rtas.c +1 -1
@@ -92,12 +92,12 @@ struct rtas_function {* Per-function locks for sequence-based RTAS functions. */ static DEFINE_MUTEX (rtas_ibm_activate_firmware_lock); -static DEFINE_MUTEX (rtas_ibm_get_dynamic_sensor_state_lock);static DEFINE_MUTEX (rtas_ibm_lpar_perftools_lock);static DEFINE_MUTEX (rtas_ibm_physical_attestation_lock);DEFINE_MUTEX (rtas_ibm_get_vpd_lock);DEFINE_MUTEX (rtas_ibm_get_indices_lock);DEFINE_MUTEX (rtas_ibm_set_dynamic_indicator_lock); +DEFINE_MUTEX (rtas_ibm_get_dynamic_sensor_state_lock);static struct rtas_function rtas_function_table[]__ro_after_init = { [RTAS_FNIDX__CHECK_EXCEPTION ] = {
arch/powerpc/platforms/pseries/papr-indices.c +67 -0
85 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v6 6/7 powerpc/pseries: Add papr-platform-dump character driver for dump retrieval
In reply to Haren Myneniibm,platform-dump RTAS call in combination with writable mapping /dev/mem is issued to collect platform dump from the hypervisor and may need multiple calls to get the complete dump. The current implementation uses rtas_platform_dump() API provided by librtas library to issue these RTAS calls. But /dev/mem access by the user space is prohibited under system lockdown.
The solution should be to restrict access to RTAS function in user space and provide kernel interfaces to collect dump. This patch adds papr-platform-dump character driver and expose standard interfaces such as open / ioctl/ read to user space in ways that are compatible with lockdown.
PAPR (7.3.3.4.1 ibm,platform-dump) provides a method to obtain the complete dump:
- Each dump will be identified by ID called dump tag.
- A sequence of RTAS calls have to be issued until retrieve the complete dump. The hypervisor expects the first RTAS call with the sequence 0 and the subsequent calls with the sequence number returned from the previous calls.
- The hypervisor returns "dump complete" status once the complete dump is retrieved. But expects one more RTAS call from the partition with the NULL buffer to invalidate dump which means the dump will be removed in the hypervisor.
- Sequence of calls are allowed with different dump IDs at the same time but not with the same dump ID.
Expose these interfaces to user space with a /dev/papr-platform-dump character device using the following programming model:
int devfd = open("/dev/papr-platform-dump", O_RDONLY); int fd = ioctl(devfd,PAPR_PLATFORM_DUMP_IOC_CREATE_HANDLE, &dump_id)
- Restrict user space to access with the same dump ID. Typically we do not expect user space requests the dump again for the same dump ID.
char *buf = malloc(size);
length = read(fd, buf, size);
- size should be minimum 1K based on PAPR and <= 4K based on RTAS work area size. It will be restrict to RTAS work area size. Using 4K work area based on the current implementation in librtas library
- Each read call issue RTAS call to get the data based on the size requirement and returns bytes returned from the hypervisor
- If the previous call returns dump complete status, the next read returns 0 like EOF.
ret = ioctl(PAPR_PLATFORM_DUMP_IOC_INVALIDATE, &dump_id)
- RTAS call with NULL buffer to invalidates the dump.
The read API should use the file descriptor obtained from ioctl based on dump ID so that gets dump contents for the corresponding dump ID. Implemented support in librtas (rtas_platform_dump()) for this new ABI to support system lockdown.
--- .../userspace-api/ioctl/ioctl-number.rst | 2 + .../include/uapi/asm/papr-platform-dump.h | 15 + arch/powerpc/platforms/pseries/Makefile | 1 + .../platforms/pseries/papr-platform-dump.c | 411 ++++++++++++++++++ 4 files changed, 429 insertions(+) create mode 100644 arch/powerpc/include/uapi/asm/papr-platform-dump.h create mode 100644 arch/powerpc/platforms/pseries/papr-platform-dump.c
Documentation/userspace-api/ioctl/ioctl-number.rst +2 -0
@@ -365,6 +365,8 @@ Code Seq# Include File Comments <mailto:linuxppc-dev> 0xB2 03-05 arch/powerpc/include/uapi/asm/papr-indices.h powerpc/pseries indices API <mailto:linuxppc-dev> +0xB2 06-07 arch/powerpc/include/uapi/asm/papr-platform-dump.h powerpc/pseries Platform Dump API + <mailto:linuxppc-dev> 0xB3 00 linux/mmc/ioctl.h 0xB4 00-0F linux/gpio.h <mailto:[email protected]> 0xB5 00-0F uapi/linux/rpmsg.h <mailto:[email protected]>
arch/powerpc/include/uapi/asm/papr-platform-dump.h new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef _UAPI_PAPR_PLATFORM_DUMP_H_ +#define _UAPI_PAPR_PLATFORM_DUMP_H_ + +#include <asm/ioctl.h> +#include <asm/papr-miscdev.h> + +/* +* ioctl for /dev/papr-platform-dump. Returns a platform-dump handle fd +* corresponding to dump tag. +*/ +#define PAPR_PLATFORM_DUMP_IOC_CREATE_HANDLE _IOW(PAPR_MISCDEV_IOC_ID, 6, __u64) +#define PAPR_PLATFORM_DUMP_IOC_INVALIDATE _IOW(PAPR_MISCDEV_IOC_ID, 7, __u64) + +#endif /* _UAPI_PAPR_PLATFORM_DUMP_H_ */
arch/powerpc/platforms/pseries/Makefile +1 -0
@@ -4,6 +4,7 @@ ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG obj-y := lpar.o hvCall.o nvram.o reconfig.o \ of_helpers.o rtas-work-area.o papr-sysparm.o \ papr-rtas-common.o papr-vpd.o papr-indices.o \ + papr-platform-dump.o \ setup.o iommu.o event_sources.o ras.o \ firmware.o power.o dlpar.o mobility.o rng.o \ pci.o pci_dlpar.o eeh_pseries.o msi.o \
arch/powerpc/platforms/pseries/papr-platform-dump.c new file +411 -0
411 lines not on this page · raw message
Signature · 1 line
2.43.5
PATCH v6 7/7 powerpc/pseries: Add a char driver for physical-attestation RTAS
In reply to Haren MyneniThe RTAS call ibm,physical-attestation is used to retrieve information about the trusted boot state of the firmware and hypervisor on the system, and also Trusted Platform Modules (TPM) data if the system is TCG 2.0 compliant.
This RTAS interface expects the caller to define different command structs such as RetrieveTPMLog, RetrievePlatformCertificat and etc, in a work area with a maximum size of 4K bytes and the response buffer will be returned in the same work area.
The current implementation of this RTAS function is in the user space but allocation of the work area is restricted with the system lockdown. So this patch implements this RTAS function in the kernel and expose to the user space with open/ioctl/read interfaces.
PAPR (2.13+ 21.3 ibm,physical-attestation) defines RTAS function:
- Pass the command struct to obtain the response buffer for the specific command.
- This RTAS function is sequence RTAS call and has to issue RTAS call multiple times to get the complete response buffer (max 64K). The hypervisor expects the first RTAS call with the sequence 1 and the subsequent calls with the sequence number returned from the previous calls.
Expose these interfaces to user space with a /dev/papr-physical-attestation character device using the following programming model:
int devfd = open("/dev/papr-physical-attestation"); int fd = ioctl(devfd, PAPR_PHY_ATTEST_IOC_HANDLE,
struct papr_phy_attest_io_block);
- The user space defines the command struct and requests the response for any command.
- Obtain the complete response buffer and returned the buffer as blob to the command specific FD.
size = read(fd, buf, len);
- Can retrieve the response buffer once or multiple times until the end of BLOB buffer.
Implemented this new kernel ABI support in librtas library for system lockdown
--- .../userspace-api/ioctl/ioctl-number.rst | 2 + arch/powerpc/include/asm/rtas.h | 1 + .../uapi/asm/papr-physical-attestation.h | 31 ++ arch/powerpc/kernel/rtas.c | 2 +- arch/powerpc/platforms/pseries/Makefile | 2 +- .../platforms/pseries/papr-phy-attest.c | 287 ++++++++++++++++++ 6 files changed, 323 insertions(+), 2 deletions(-) create mode 100644 arch/powerpc/include/uapi/asm/papr-physical-attestation.h create mode 100644 arch/powerpc/platforms/pseries/papr-phy-attest.c
Documentation/userspace-api/ioctl/ioctl-number.rst +2 -0
@@ -367,6 +367,8 @@ Code Seq# Include File Comments <mailto:linuxppc-dev> 0xB2 06-07 arch/powerpc/include/uapi/asm/papr-platform-dump.h powerpc/pseries Platform Dump API <mailto:linuxppc-dev> +0xB2 08 arch/powerpc/include/uapi/asm/papr-physical-attestation.h powerpc/pseries Physical Attestation API + <mailto:linuxppc-dev> 0xB3 00 linux/mmc/ioctl.h 0xB4 00-0F linux/gpio.h <mailto:[email protected]> 0xB5 00-0F uapi/linux/rpmsg.h <mailto:[email protected]>
arch/powerpc/include/asm/rtas.h +1 -0
@@ -518,6 +518,7 @@ extern struct mutex rtas_ibm_get_vpd_lock;extern struct mutex rtas_ibm_get_indices_lock;extern struct mutex rtas_ibm_set_dynamic_indicator_lock;extern struct mutex rtas_ibm_get_dynamic_sensor_state_lock; +extern struct mutex rtas_ibm_physical_attestation_lock;#define GLOBAL_INTERRUPT_QUEUE 9005
arch/powerpc/include/uapi/asm/papr-physical-attestation.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef _UAPI_PAPR_PHYSICAL_ATTESTATION_H_ +#define _UAPI_PAPR_PHYSICAL_ATTESTATION_H_ + +#include <linux/types.h> +#include <asm/ioctl.h> +#include <asm/papr-miscdev.h> + +#define PAPR_PHYATTEST_MAX_INPUT 4084/* Max 4K buffer: 4K-12 */ + +/* +* Defined in PAPR 2.13+ 21.6 Attestation Command Structures. +* User space pass this struct and the max size should be 4K. +*/ +struct papr_phy_attest_io_block { +__u8 version; +__u8 command; +__u8 TCG_major_ver; +__u8 TCG_minor_ver; +__be32 length; +__be32 correlator; +__u8 payload[PAPR_PHYATTEST_MAX_INPUT ]; +}; + +/* +* ioctl for /dev/papr-physical-attestation. Returns a attestation +* command fd handle +*/ +#define PAPR_PHY_ATTEST_IOC_HANDLE _IOW(PAPR_MISCDEV_IOC_ID, 8, struct papr_phy_attest_io_block) + +#endif /* _UAPI_PAPR_PHYSICAL_ATTESTATION_H_ */
arch/powerpc/kernel/rtas.c +1 -1
@@ -93,7 +93,7 @@ struct rtas_function {*/ static DEFINE_MUTEX (rtas_ibm_activate_firmware_lock);static DEFINE_MUTEX (rtas_ibm_lpar_perftools_lock); -static DEFINE_MUTEX (rtas_ibm_physical_attestation_lock); +DEFINE_MUTEX (rtas_ibm_physical_attestation_lock);DEFINE_MUTEX (rtas_ibm_get_vpd_lock);DEFINE_MUTEX (rtas_ibm_get_indices_lock);DEFINE_MUTEX (rtas_ibm_set_dynamic_indicator_lock);
arch/powerpc/platforms/pseries/Makefile +1 -1
@@ -4,7 +4,7 @@ ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG obj-y := lpar.o hvCall.o nvram.o reconfig.o \ of_helpers.o rtas-work-area.o papr-sysparm.o \ papr-rtas-common.o papr-vpd.o papr-indices.o \ - papr-platform-dump.o \ + papr-platform-dump.o papr-phy-attest.o \ setup.o iommu.o event_sources.o ras.o \ firmware.o power.o dlpar.o mobility.o rng.o \ pci.o pci_dlpar.o eeh_pseries.o msi.o \
arch/powerpc/platforms/pseries/papr-phy-attest.c new file +287 -0
287 lines not on this page · raw message
Signature · 1 line
2.43.5