Skip to contentSkip to conversation

linux-next: build failure after merge of the mm tree

DISCUSSION Stephen Rothwell 2 participants 3 messages Feb 16, 2025 – Feb 17, 2025 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the mm tree, today's linux-next build (powerpc native perf) failed like this:

In file included from threadmap.c:4:
tools/include/linux/refcount.h: In function 'refcount_set_release':
tools/include/linux/refcount.h:65:9: error: implicit declaration of function 'atomic_set_release'; did you mean 'refcount_set_release'? [-Wimplicit-function-declaration]

   65 |         atomic_set_release(&r->refs, n);
      |         ^~~~~~~~~~~~~~~~~~
      |         refcount_set_release

tools/include/linux/refcount.h:65:9: error: nested extern declaration of 'atomic_set_release' [-Werror=nested-externs]
cc1: all warnings being treated as errors

(and several more similar)

Caused by commit

1465347e498f ("mm: make vma cache SLAB_TYPESAFE_BY_RCU")

from the mm-unstable branch of the mm tree.

I have reverted that commit for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 17 lines · Stephen Rothwell

Hi all,

After merging the mm tree, today's linux-next build (powerpc native perf) failed like this:

In file included from threadmap.c:4:
tools/include/linux/refcount.h: In function 'refcount_set_release':
tools/include/linux/refcount.h:65:9: error: implicit declaration of function 'atomic_set_release'; did you mean 'refcount_set_release'? [-Wimplicit-function-declaration]

   65 |         atomic_set_release(&r->refs, n);
      |         ^~~~~~~~~~~~~~~~~~
      |         refcount_set_release

tools/include/linux/refcount.h:65:9: error: nested extern declaration of 'atomic_set_release' [-Werror=nested-externs]
cc1: all warnings being treated as errors

(and several more similar)

Quoted 7 lines

Caused by commit

1465347e498f ("mm: make vma cache SLAB_TYPESAFE_BY_RCU")

from the mm-unstable branch of the mm tree.

I have reverted that commit for today.

Thanks! I'll see if I can fix it quickly. I must be missing this function under tools/ in some specific config.

Quoted 4 lines

--
Cheers,
Stephen Rothwell

#2 lore raw
Quoted 21 lines · Suren Baghdasaryan
Quoted 19 lines · Stephen Rothwell

Hi all,

After merging the mm tree, today's linux-next build (powerpc native perf) failed like this:

In file included from threadmap.c:4:
tools/include/linux/refcount.h: In function 'refcount_set_release':
tools/include/linux/refcount.h:65:9: error: implicit declaration of function 'atomic_set_release'; did you mean 'refcount_set_release'? [-Wimplicit-function-declaration]

   65 |         atomic_set_release(&r->refs, n);
      |         ^~~~~~~~~~~~~~~~~~
      |         refcount_set_release

tools/include/linux/refcount.h:65:9: error: nested extern declaration of 'atomic_set_release' [-Werror=nested-externs]
cc1: all warnings being treated as errors

(and several more similar)

Caused by commit

Quoted 8 lines
Quoted 5 lines

1465347e498f ("mm: make vma cache SLAB_TYPESAFE_BY_RCU")

from the mm-unstable branch of the mm tree.

I have reverted that commit for today.

Thanks! I'll see if I can fix it quickly. I must be missing this function under tools/ in some specific config.

I just posted a fix at:
https://lore.kernel.org/all/[email protected]/

Quoted 5 lines
Quoted 5 lines

--
Cheers,
Stephen Rothwell