Skip to contentSkip to conversation

mm-hugetlb-avoid-fallback-for-specific-node-allocation-of-1g-pages.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Feb 18, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: hugetlb: avoid fallback for specific node allocation of 1G pages
has been removed from the -mm tree. Its filename was
mm-hugetlb-avoid-fallback-for-specific-node-allocation-of-1g-pages.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Luiz Capitulino <[email protected]>
Subject: mm: hugetlb: avoid fallback for specific node allocation of 1G pages
Date: Mon, 10 Feb 2025 22:48:56 -0500

When using the HugeTLB kernel command-line to allocate 1G pages from a specific node, such as:

default_hugepagesz=1G hugepages=1:1

If node 1 happens to not have enough memory for the requested number of 1G pages, the allocation falls back to other nodes. A quick way to reproduce this is by creating a KVM guest with a memory-less node and trying to allocate 1 1G page from it. Instead of failing, the allocation will fallback to other nodes.

This defeats the purpose of node specific allocation. Also, specific node allocation for 2M pages don't have this behavior: the allocation will just fail for the pages it can't satisfy.

This issue happens because HugeTLB calls memblock_alloc_try_nid_raw() for 1G boot-time allocation as this function falls back to other nodes if the allocation can't be satisfied. Use memblock_alloc_exact_nid_raw() instead, which ensures that the allocation will only be satisfied from the specified node.

Fixes b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")
Cc "Mike Rapoport (IBM)" <[email protected]>
Cc Muchun Song <[email protected]>
Cc Zhenguo Yao <[email protected]>
Cc Frank van der Linden <[email protected]>

---

 mm/hugetlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c renamed from mm/hugetlb.c~mm-hugetlb-avoid-fallback-for-specific-node-allocation-of-1g-pages +1 -1
@@ -3145,7 +3145,7 @@ int __alloc_bootmem_huge_page(struct hst
 
 	/* do node specific alloc */
 	if (nid != NUMA_NO_NODE) {
-		m = memblock_alloc_try_nid_raw(huge_page_size(h), huge_page_size(h),
+		m = memblock_alloc_exact_nid_raw(huge_page_size(h), huge_page_size(h),
 				0, MEMBLOCK_ALLOC_ACCESSIBLE, nid);
 		if (!m)
 			return 0;

_

Patches currently in -mm which might be from [email protected] are