Skip to contentSkip to conversation

use flags from user if it is set

PATCH In review Minggang Li(Gavin) 3 participants 6 messages Feb 18, 2025 – Feb 20, 2025

lore
Share & tools
lore
#0 lore raw

cover use flags from user if it is set

This patch series also fixed mlx5 release notes on VXLAN limitations.

Minggang Li (Gavin) (2):
doc: fix mlx5 VXLAN matching limitations
app/testpmd: use flags from user if it is set

 app/test-pmd/cmdline_flow.c | 3 ++-
 doc/guides/nics/mlx5.rst    | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 doc: fix mlx5 VXLAN matching limitations

P bit of VXLAN-GPE and G bit of VXLAN-GBP should be set when matching the protocols.

Fixes 49765b78c81b ("net/mlx5/hws: match all VXLAN fields")
---
 doc/guides/nics/mlx5.rst | 4 ++++
 1 file changed, 4 insertions(+)
doc/guides/nics/mlx5.rst +4 -0
index 690b46a974..caf711ce67 100644
@@ -339,6 +339,10 @@ Limitations
   - For ConnectX-5, the UDP destination port must be the standard one (4789).
   - Default UDP destination is 4789 if not explicitly specified.
   - Group zero's behavior may differ which depends on FW.
+  - User should set different flags when matching on VXLAN-GPE/GBP:
+
+   - for VXLAN-GPE - P flag
+   - for VXLAN-GBP - G flag
 
 - Matching on VXLAN-GPE header fields:
 
Signature · 1 line
2.34.1
Acked-by on v1 1/2
#2 lore raw

RE: [PATCH 1/2] doc: fix mlx5 VXLAN matching limitations

Quoted 14 lines

-----Original Message-----
From: Minggang(Gavin) Li <[email protected]>
Sent: Tuesday, February 18, 2025 11:33
To: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Dariusz Sosnowski <[email protected]>; Bing Zhao <[email protected]>; Suanming Mou <[email protected]>; Alex Vesker <[email protected]>; rongwei liu <[email protected]>
Cc: [email protected]; Raslan Darawsheh <[email protected]>
Subject: [PATCH 1/2] doc: fix mlx5 VXLAN matching limitations

Quoted 5 lines

P bit of VXLAN-GPE and G bit of VXLAN-GBP should be set when matching the protocols.

Fixes 49765b78c81b ("net/mlx5/hws: match all VXLAN fields")

Best regards,
Dariusz Sosnowski

#3 lore raw

PATCH 2/2 app/testpmd: use flags from user if it is set

In reply to Minggang Li(Gavin)

It's user's responsibility to set correct flags, especially the G bit, to distinguish the protocols, VXLAN and VXLAN-GBP, sharing the same port 4789.

It will be set to 0x8 if user does not specify the flags.

Fixes da118115d95c ("app/testpmd: support matching any VXLAN field")
---
 app/test-pmd/cmdline_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
app/test-pmd/cmdline_flow.c +2 -1
index e1720e54d7..3947304b63 100644
@@ -13598,7 +13598,8 @@ update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto)
 		break;
 	case RTE_FLOW_ITEM_TYPE_VXLAN:
 		vxlan = (struct rte_vxlan_hdr *)buf;
-		vxlan->vx_flags = 0x08;
+		if (!vxlan->flags)
+			vxlan->flags = 0x08;
 		break;
 	case RTE_FLOW_ITEM_TYPE_VXLAN_GPE:
 		gpe = (struct rte_vxlan_gpe_hdr *)buf;
Signature · 1 line
2.34.1
Acked-by on v1 2/2
#4 lore raw

RE: [PATCH 2/2] app/testpmd: use flags from user if it is set

Quoted 15 lines

-----Original Message-----
From: Minggang Li(Gavin) <[email protected]>
Sent: Tuesday, February 18, 2025 11:33
To: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Aman Singh <[email protected]>; Minggang(Gavin) Li <[email protected]>
Cc: [email protected]; Raslan Darawsheh <[email protected]>
Subject: [PATCH 2/2] app/testpmd: use flags from user if it is set

External email: Use caution opening links or attachments

Quoted 7 lines

It's user's responsibility to set correct flags, especially the G bit, to distinguish the protocols, VXLAN and VXLAN-GBP, sharing the same port 4789.

It will be set to 0x8 if user does not specify the flags.

Fixes da118115d95c ("app/testpmd: support matching any VXLAN field")

Best regards,
Dariusz Sosnowski

#5 lore raw
In reply to Minggang Li(Gavin)
Quoted 10 lines · On Tue, 18 Feb 2025 12:33:20 +0200 "Minggang Li(Gavin)" <[email protected]>…

This patch series also fixed mlx5 release notes on VXLAN limitations.

Minggang Li (Gavin) (2):
doc: fix mlx5 VXLAN matching limitations
app/testpmd: use flags from user if it is set

 app/test-pmd/cmdline_flow.c | 3 ++-
 doc/guides/nics/mlx5.rst    | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

Applied to next-net.
Checkpatches gives warnings because the entry in mailmap has a space before the parenthesis part and the Signed-off-by does not. I resolved it by putting space in the Signed-off-by but probably want to fix your mail settings to match.

Also added cc to stable on both