Skip to contentSkip to conversation

media: vim2m: print device name after registering device

PATCH In review Matthew Majewski 4 participants 8 messages Feb 19, 2025 – Mar 6, 2025 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: vim2m: print device name after registering device

Move the v4l2_info() call displaying the video device name after the device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0" since it was reading from the vfd before it was registered.

---
 drivers/media/test-drivers/vim2m.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/test-drivers/vim2m.c +3 -3
index 6c24dcf27eb0..0fe97e208c02 100644
@@ -1314,9 +1314,6 @@ static int vim2m_probe(struct platform_device *pdev)
 	vfd->v4l2_dev = &dev->v4l2_dev;
 
 	video_set_drvdata(vfd, dev);
-	v4l2_info(&dev->v4l2_dev,
-		  "Device registered as /dev/video%d\n", vfd->num);
-
 	platform_set_drvdata(pdev, dev);
 
 	dev->m2m_dev = v4l2_m2m_init(&m2m_ops);
@@ -1343,6 +1340,9 @@ static int vim2m_probe(struct platform_device *pdev)
 		goto error_m2m;
 	}
 
+	v4l2_info(&dev->v4l2_dev,
+		  "Device registered as /dev/video%d\n", vfd->num);
+
 #ifdef CONFIG_MEDIA_CONTROLLER
 	ret = v4l2_m2m_register_media_controller(dev->m2m_dev, vfd,
 						 MEDIA_ENT_F_PROC_VIDEO_SCALER);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Matthew Majewski

Move the v4l2_info() call displaying the video device name after the device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0" since it was reading from the vfd before it was registered.

---

Thanks. Applied for 6.15-rc1 to be included in pull request to media maintainer.

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=vimc

thanks,
-- Shuah

#3 lore raw
Quoted 10 lines · Uwe Kleine-Konig
Quoted 7 lines · Matthew Majewski

Move the v4l2_info() call displaying the video device name after the device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0" since it was reading from the vfd before it was registered.

A Fixes: tag would be great.

Matthew, there is no need to resend the patch. Just send me the Fixes tag and I will update the repo.

thanks,
-- Shuah

#4 lore raw
Quoted 10 lines · Shuah Khan
Quoted 9 lines · Uwe Kleine-Konig
Quoted 8 lines · Matthew Majewski

Move the v4l2_info() call displaying the video device name after the
device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0"
since it was reading from the vfd before it was registered.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

A Fixes: tag would be great.

Matthew, there is no need to resend the patch. Just send me the Fixes tag and I will update the repo.

Ok, here is the fixes tag:

Fixes cf7f34777a5b4100a ("media: vim2m: Register video device after

setting up internals")

Thank you both for your time.

Best,
Matthew

#5 lore raw
Quoted 20 lines · Matthew Majewski
Quoted 10 lines · Shuah Khan
Quoted 9 lines · Uwe Kleine-Konig
Quoted 8 lines · Matthew Majewski

Move the v4l2_info() call displaying the video device name after the
device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0"
since it was reading from the vfd before it was registered.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

A Fixes: tag would be great.

Matthew, there is no need to resend the patch. Just send me the Fixes tag and I will update the repo.

Quoted 5 lines

Ok, here is the fixes tag:

Fixes cf7f34777a5b4100a ("media: vim2m: Register video device after

setting up internals")

Thank you. commit is now updated.

thanks,
-- Shuah

#6 lore raw

Hi Shuah,

Quoted 23 lines · Shuah Khan
Quoted 22 lines · Matthew Majewski
Quoted 10 lines · Shuah Khan
Quoted 9 lines · Uwe Kleine-Konig
Quoted 8 lines · Matthew Majewski

Move the v4l2_info() call displaying the video device name after the
device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0"
since it was reading from the vfd before it was registered.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

A Fixes: tag would be great.

Matthew, there is no need to resend the patch. Just send me the Fixes tag and I will update the repo.

Ok, here is the fixes tag:

Quoted 9 lines
Quoted 3 lines
Fixes cf7f34777a5b4100a ("media: vim2m: Register video device after

setting up internals")

Thank you. commit is now updated.

thanks,
-- Shuah

Please post your PR today, if possible. Otherwise it might slip to the v6.16. Alternatively, I can take this patch myself.

Also, why did you pick up this vim2m patch? I was a bit surprised by that.

Regards,

Hans

#7 lore raw
Quoted 30 lines · Hans Verkuil

Hi Shuah,

Quoted 27 lines · Shuah Khan
Quoted 25 lines · Matthew Majewski
Quoted 10 lines · Shuah Khan
Quoted 9 lines · Uwe Kleine-Konig
Quoted 8 lines · Matthew Majewski

Move the v4l2_info() call displaying the video device name after the
device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0"
since it was reading from the vfd before it was registered.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

A Fixes: tag would be great.

Matthew, there is no need to resend the patch. Just send me the Fixes tag and I will update the repo.

Ok, here is the fixes tag:

Fixes cf7f34777a5b4100a ("media: vim2m: Register video device after

setting up internals")

Quoted 8 lines
Quoted 5 lines

Thank you. commit is now updated.

thanks,
-- Shuah

Please post your PR today, if possible. Otherwise it might slip to the v6.16. Alternatively, I can take this patch myself.

Thanks for the reminder - I have to send a vimc PR

Please take this through your tree.

Quoted 2 lines

Also, why did you pick up this vim2m patch? I was a bit surprised by that.

By mistake - Blame it on jet lag - sorry. Explains why Matthew sent series for my review.

thanks,
-- Shuah