Skip to contentSkip to conversation

ata: sata_via: Use str_up_down() helper in vt6420_prereset()

PATCH Applied Salah Triki 2 participants 2 messages Feb 20, 2025 libata

lore
Share & tools
lore

Salah Triki

author
#0 lore raw

PATCH v2 1/1 ata: sata_via: Use str_up_down() helper in vt6420_prereset()

Remove hard-coded strings by using the str_up_down() helper function.

Signed-off-by Salah Triki <[email protected]>
---
 drivers/ata/sata_via.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/sata_via.c +2 -1
index 57cbf2cef618..4ecd8f33b082 100644
@@ -25,6 +25,7 @@
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_host.h>
 #include <linux/libata.h>
+#include <linux/string_choices.h>
 
 #define DRV_NAME	"sata_via"
 #define DRV_VERSION	"2.6"

@@ -359,7 +360,7 @@ static int vt6420_prereset(struct ata_link *link, unsigned long deadline)
 
 	ata_port_info(ap,
 		      "SATA link %s 1.5 Gbps (SStatus %X SControl %X)\n",
-		      online ? "up" : "down", sstatus, scontrol);
+		      str_up_down(online), sstatus, scontrol);
 
 	/* SStatus is read one more time */
 	svia_scr_read(link, SCR_STATUS, &sstatus);
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 3 lines · Salah Triki

Remove hard-coded strings by using the str_up_down() helper function.

Applied to libata/linux.git (for-6.15), thanks!

[1/1] ata: sata_via: Use str_up_down() helper in vt6420_prereset()

      https://git.kernel.org/libata/linux/c/0ce4a0d1

Kind regards,
Niklas