Skip to contentSkip to conversation

dma: dw-axi-dmac: remove unnecessary axi_dma_enable() calling

PATCH Superseded [email protected] 1 participant 1 message Feb 20, 2025

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 dma: dw-axi-dmac: remove unnecessary axi_dma_enable() calling

From: Niravkumar L Rabara <[email protected]>

DMA is always enabled before calling axi_chan_block_xfer_start(), so it does not need to be enabled again here.

Re-enabling DMA causes random failures in the dmatest test when running multiple iterations.
e.g.

[   29.600722] dmatest: dma0chan2-copy0: summary 100 tests, 1 failures 160.26 iops 1299 KB/s (0)
Fixes 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")

---

Changes in v4:
* Add fixes tag
* Rebase to v6.14-rc1

link to v3:
- https://lore.kernel.org/all/[email protected]/

 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
 1 file changed, 2 deletions(-)
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +0 -2
index b23536645ff7..43d30c7b8f03 100644
@@ -435,8 +435,6 @@ static void axi_chan_block_xfer_start(struct axi_dma_chan *chan,
 		return;
 	}
 
-	axi_dma_enable(chan->chip);
-
 	config.dst_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
 	config.src_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
 	config.tt_fc = DWAXIDMAC_TT_FC_MEM_TO_MEM_DMAC;
Signature · 1 line
2.25.1