pinctrl: wpcm450: Switch to use for_each_gpiochip_node() helper
Subsystems (3)
PATCH v2 1/1 pinctrl: wpcm450: Switch to use for_each_gpiochip_node() helper
Switch the code to use for_each_gpiochip_node() helper.
While at it, correct header inclusion as device property APIs are provided in property.h.
Reviewed-by J. Neuschäfer <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
v2: fixed Subject, added tag (J. Neuschäfer)
drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +2 -5
@@ -10,7 +10,6 @@// block, shared between all GPIO banks #include <linux/device.h> -#include <linux/fwnode.h> #include <linux/gpio/driver.h> #include <linux/interrupt.h> #include <linux/irq.h>
@@ -18,6 +17,7 @@#include <linux/module.h> #include <linux/mod_devicetable.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/regmap.h> #include <linux/pinctrl/pinconf.h>
@@ -1033,7 +1033,7 @@ static int wpcm450_gpio_register(struct platform_device *pdev,return dev_err_probe (dev,PTR_ERR (pctrl->gpio_base),"Resource fail for GPIO controller\n" ); -device_for_each_child_node (dev, child) { +for_each_gpiochip_node (dev, child) {void __iomem *dat =NULL ;void __iomem *set =NULL ;void __iomem *dirout =NULL ;
@@ -1044,9 +1044,6 @@ static int wpcm450_gpio_register(struct platform_device *pdev,u32 reg;int i; -if (!fwnode_property_read_bool (child,"gpio-controller" )) -continue ; - ret =fwnode_property_read_u32 (child,"reg" , ®);if (ret <0 )return ret;
Signature · 1 line
2.45.1.3035.g276e886db78b
Quoted 4 lines · Andy Shevchenko
Switch the code to use
for_each_gpiochip_node()helper.While at it, correct header inclusion as device property APIs are provided in
property.h.
Linus, Are you okay with the change?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Switch the code to use
for_each_gpiochip_node()helper.While at it, correct header inclusion as device property APIs are provided in
property.h.Reviewed-by J. Neuschäfer <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Patch applied!
Yours,
Linus Walleij