leds: add new LED driver for TI LP5812

From: Nam Tran <[email protected]>
To: Pavel Machek <[email protected]>, Lee Jones <[email protected]>
Cc: [email protected], [email protected]

This patch series adds support for the Texas Instruments LP5812 LED driver. Patch 1 adds the Device Tree (DT) bindings documentation.
Patch 2 introduces the core driver implementation.

The LP5812 is an I2C-controlled LED driver capable of driving up to 4 LEDs with independent brightness control and pattern programming. This driver provides support through the Linux LED framework and includes device tree bindings for proper integration.

This driver has been tested on Raspberry Pi 4 B using kernel version 6.1.13.

I kindly request feedback from the community to ensure that this driver adheres to the Linux LED subsystem standards.

Thank you for your consideration.

Best regards,
Nam

---

Changes in v1:
- Initial submission.

This documentation ensures proper integration of the LP5812 in Device Tree-based systems.

---
 .../devicetree/bindings/leds/leds-lp5812.yaml | 34 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++++
 2 files changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lp5812.yaml

new file mode 100644
index 000000000000..1eb395230531
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+
+title: LED driver for LP5812 LED from Texas Instruments.
+
+maintainers:
+
+description: |
+  The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
+
+properties:
+  compatible:
+    const: ti,lp5812
+
+  reg:
+    description: I2C slave address
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c1 {
+      lp5812@1b {
+        compatible = "ti,lp5812";
+        reg = <0x1b>;
+      };
+    };
+
+...

index 4e17764cb6ed..7efbd6f0c79e 100644
@@ -23489,6 +23489,12 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml
 F:	drivers/leds/leds-lp8864.c
 
+TEXAS INSTRUMENTS' LP5812 LED DRIVER
+M:	Nam Tran <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/leds/leds-lp5812.yaml
+
 TEXAS INSTRUMENTS' SYSTEM CONTROL INTERFACE (TISCI) PROTOCOL DRIVER
 M:	Nishanth Menon <[email protected]>
 M:	Tero Kristo <[email protected]>

2.25.1

Thank you for your patch. There is something to discuss/improve.

Describe the hardware, not that DT is DT.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.

Please kindly resend and include all necessary To/Cc entries. </form letter>

Filename based on compatible.

More review when you test it.

Best regards,
Krzysztof

The chip can drive LED matrix 4x3.
This driver uses I2C to communicate with the chip.

---
 MAINTAINERS                       |    6 +
 drivers/leds/Kconfig              |   13 +
 drivers/leds/Makefile             |    2 +
 drivers/leds/leds-lp5812-common.c | 1097 ++++++++++++++
 drivers/leds/leds-lp5812-common.h |  323 ++++
 drivers/leds/leds-lp5812-regs.h   |   96 ++
 drivers/leds/leds-lp5812.c        | 2319 +++++++++++++++++++++++++++++
 7 files changed, 3856 insertions(+)
 create mode 100644 drivers/leds/leds-lp5812-common.c
 create mode 100644 drivers/leds/leds-lp5812-common.h
 create mode 100644 drivers/leds/leds-lp5812-regs.h
 create mode 100644 drivers/leds/leds-lp5812.c

index 7efbd6f0c79e..d357383c2ad3 100644
@@ -23494,6 +23494,12 @@ M:	Nam Tran <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/devicetree/bindings/leds/leds-lp5812.yaml
+F:	drivers/leds/Kconfig
+F:	drivers/leds/Makefile
+F:	drivers/leds/leds-lp5812-common.c
+F:	drivers/leds/leds-lp5812-common.h
+F:	drivers/leds/leds-lp5812-regs.h
+F:	drivers/leds/leds-lp5812.c
 
 TEXAS INSTRUMENTS' SYSTEM CONTROL INTERFACE (TISCI) PROTOCOL DRIVER
 M:	Nishanth Menon <[email protected]>

index 2b27d043921c..e43dbd5a4d8c 100644
@@ -483,6 +483,19 @@ config LEDS_LP5569
 	  Driver provides direct control via LED class and interface for
 	  programming the engines.
 
+config LEDS_LP5812
+	bool "Enable LP5812 support LED matrix 4x3"
+	depends on LEDS_CLASS && I2C
+	depends on LEDS_CLASS_MULTICOLOR
+	help
+	  If you say Y here you get support for TI LP5812 LED driver.
+
+	  The LP5812 is an I2C-based RGB LED driver that supports a 4x3 LED matrix.
+	  It provides independent brightness control and color mixing for each LED.
+	  This driver integrates with the Linux LED framework and LED multicolor class.
+
+	  If unsure, say N.
+
 config LEDS_LP8501
 	tristate "LED Support for TI LP8501 LED driver chip"
 	depends on LEDS_CLASS && I2C

index 6ad52e219ec6..2b95463c9ba7 100644
@@ -54,6 +54,8 @@ obj-$(CONFIG_LEDS_LP5523)		+= leds-lp5523.o
 obj-$(CONFIG_LEDS_LP5562)		+= leds-lp5562.o
 obj-$(CONFIG_LEDS_LP5569)		+= leds-lp5569.o
 obj-$(CONFIG_LEDS_LP55XX_COMMON)	+= leds-lp55xx-common.o
+obj-$(CONFIG_LEDS_LP5812) 		+= leds-lp5812.o
+leds-lp5812-objs				:= leds-lp5812.o leds-lp5812-common.o
 obj-$(CONFIG_LEDS_LP8501)		+= leds-lp8501.o
 obj-$(CONFIG_LEDS_LP8788)		+= leds-lp8788.o
 obj-$(CONFIG_LEDS_LP8860)		+= leds-lp8860.o

2.25.1

Part of the diff is not shown here. View the raw message.

Why none of the 10 existing drivers fit for your device?

Best regards,
Krzysztof