Skip to contentSkip to conversation

FAILED: patch "[PATCH] arm64: dts: rockchip: change eth phy mode to rgmii-id for" failed to apply to 6.12-stable tree

PATCH In review [email protected] 3 participants 3 messages Feb 24, 2025

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

To reproduce the conflict and resubmit, you may use the following commands:

git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x a6a7cba17c544fb95d5a29ab9d9ed4503029cb29
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025022431-print-cure-5210@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..

Possible dependencies:

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From a6a7cba17c544fb95d5a29ab9d9ed4503029cb29 Mon Sep 17 00:00:00 2001
From: Tianling Shen <[email protected]>
Date: Sun, 19 Jan 2025 17:11:54 +0800
Subject: [PATCH] arm64: dts: rockchip: change eth phy mode to rgmii-id for
orangepi r1 plus lts

In general the delay should be added by the PHY instead of the MAC, and this improves network stability on some boards which seem to need different delay.

Fixes 387b3bbac5ea ("arm64: dts: rockchip: Add Xunlong OrangePi R1 Plus LTS")
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus-lts.dts +1 -2
index 67c246ad8b8c..ec2ce894da1f 100644
@@ -17,8 +17,7 @@ / {
 
 &gmac2io {
 	phy-handle = <&yt8531c>;
-	tx_delay = <0x19>;
-	rx_delay = <0x05>;
+	phy-mode = "rgmii-id";
 	status = "okay";
 
 	mdio {
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dts +1 -0
index 324a8e951f7e..846b931e16d2 100644
@@ -15,6 +15,7 @@ / {
 
 &gmac2io {
 	phy-handle = <&rtl8211e>;
+	phy-mode = "rgmii";
 	tx_delay = <0x24>;
 	rx_delay = <0x18>;
 	status = "okay";
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dtsi +0 -1
index 4f193704e5dc..09508e324a28 100644
@@ -109,7 +109,6 @@ &gmac2io {
 	assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
 	assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
 	clock_in_out = "input";
-	phy-mode = "rgmii";
 	phy-supply = <&vcc_io>;
 	pinctrl-0 = <&rgmiim1_pins>;
 	pinctrl-names = "default";
#1 lore raw

PATCH 1/1 arm64: dts: rockchip: change eth phy mode to rgmii-id for orangepi r1 plus lts

In general the delay should be added by the PHY instead of the MAC, and this improves network stability on some boards which seem to need different delay.

Fixes 387b3bbac5ea ("arm64: dts: rockchip: Add Xunlong OrangePi R1 Plus LTS")
(cherry picked from commit a6a7cba17c544fb95d5a29ab9d9ed4503029cb29)
[Fix conflicts due to missing dtsi conversion]
---
 .../arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus-lts.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus-lts.dts +4 -2
index 4237f2ee8fee..f57d4acd9807 100644
@@ -15,9 +15,11 @@ / {
 };
 
 &gmac2io {
+	/delete-property/ tx_delay;
+	/delete-property/ rx_delay;
+
 	phy-handle = <&yt8531c>;
-	tx_delay = <0x19>;
-	rx_delay = <0x05>;
+	phy-mode = "rgmii-id";
 
 	mdio {
 		/delete-node/ ethernet-phy@1;
Signature · 1 line
2.48.1
maintainer
#2 lore raw

Re: [PATCH 6.12.y] arm64: dts: rockchip: change eth phy mode to rgmii-id for orangepi r1 plus lts

[ Sasha's backport helper bot ]

Hi,

Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it ℹ️ Patch is missing in 6.13.y (ignore if backport was sent)
⚠️ Commit missing in all newer stable branches

Found matching upstream commit: a6a7cba17c544fb95d5a29ab9d9ed4503029cb29

Status in newer kernel trees:
6.13.y | Not found

Note: The patch differs from the upstream commit:
---

1:  a6a7cba17c544 < -:  ------------- arm64: dts: rockchip: change eth phy mode to rgmii-id for orangepi r1 plus lts
-:  ------------- > 1:  2d087bdd21e9b arm64: dts: rockchip: change eth phy mode to rgmii-id for orangepi r1 plus lts

---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y       |  Success    |  Success   |