kbuild: hdrcheck: fix cross build with clang
PATCH v2 1/1 kbuild: hdrcheck: fix cross build with clang
From: Arnd Bergmann <[email protected]>
The headercheck tries to call clang with a mix of compiler arguments that don't include the target architecture. When building e.g. x86 headers on arm64, this produces a warning like
clang: warning: unknown platform, assuming -mfloat-abi=soft
Add in the CLANG_FLAGS, which contain the target, in order to make it build properly.
See also 1b71c2fb04e7 ("kbuild: userprogs: fix bitsize and target
Quoted 1 line
detection on clang").
---
v2: use same approach as the other patch.
--- usr/include/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
usr/include/Makefile +1 -1
@@ -10,7 +10,7 @@ UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration # In theory, we do not care -m32 or -m64 for header compile tests. # It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64. -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS)) +UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS)) # USERCFLAGS might contain sysroot location for CC. UAPI_CFLAGS += $(USERCFLAGS)
Signature · 1 line
2.39.5
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The headercheck tries to call clang with a mix of compiler arguments that don't include the target architecture. When building e.g. x86 headers on arm64, this produces a warning like
clang: warning: unknown platform, assuming -mfloat-abi=soft
Add in the
CLANG_FLAGS, which contain the target, in order to make it
Small nit, this should probably be KBUILD_CPPFLAGS now.
Quoted 4 lines
build properly.
See also
1b71c2fb04e7("kbuild: userprogs: fix bitsize and targetQuoted 1 line
detection on clang").
Extra '>' I think?
Quoted 2 lines
Signed-off-by Arnd Bergmann <[email protected]>
Perhaps this wants the same Fixes tag as the above referenced patch since I think that is the one that broke this?
Quoted 22 lines
---
v2: use same approach as the other patch.--- usr/include/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)usr/include/Makefile +1
-1@@ -10,7 +10,7 @@ UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration # In theory, we do not care -m32 or -m64 for header compile tests. # It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64. -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS)) +UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS)) # USERCFLAGS might contain sysroot location for CC. UAPI_CFLAGS += $(USERCFLAGS)Signature · 1 line
2.39.5